6.3.0.4: SdImportTest::testDocumentLayout fails

classic Classic list List threaded Threaded
8 messages Options
Paul Menzel Paul Menzel
Reply | Threaded
Open this post in threaded view
|

6.3.0.4: SdImportTest::testDocumentLayout fails

Dear LibreOffice folks,


Building LibreOffice 6.3.0.4 with `DISPLAY=` (unset) the test below fails.

```
bootstrapfixture.cxx:199:Assertion
Test name: SdImportTest::testDocumentLayout
equality assertion failed
- Expected: 0
- Actual  : 256
- failed to execute: sh
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/build/bin/odfvalidator.sh
-M
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng
-D
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-dsig-schema-v1.3+libreoffice.rng
-O
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng
-m
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/mathml2/mathml2.xsd
/tmp/lu933312w9ae3.tmp > /tmp/lu933312w9ae8.tmp

Failures !!!
Run: 84   Failure total: 1   Failures: 1   Errors: 0

Error: a unit test failed, please do one of:

make CppunitTest_sd_import_tests CPPUNITTRACE="gdb --args"
     # for interactive debugging on Linux
make CppunitTest_sd_import_tests VALGRIND=memcheck
     # for memory checking
make CppunitTest_sd_import_tests DEBUGCPPUNIT=TRUE
     # for exception catching

You can limit the execution to just one particular test by:

make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params...

make[1]: ***
[/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/solenv/gbuild/CppunitTest.mk:113:
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/build/workdir/CppunitTest/sd_import_tests.test]
Error 1
```

Kind regards,

Paul
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Thorsten Behrens-6 Thorsten Behrens-6
Reply | Threaded
Open this post in threaded view
|

Re: 6.3.0.4: SdImportTest::testDocumentLayout fails

Hi Paul,

Paul Menzel wrote:
> Building LibreOffice 6.3.0.4 with `DISPLAY=` (unset) the test below fails.
>
> ```

Can you run bin/odfvalidator.sh successfully from the shell? Possibly
it does not find the right JRE (>=1.8).

Cheers,

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (1K) Download Attachment
Paul Menzel Paul Menzel
Reply | Threaded
Open this post in threaded view
|

Re: 6.3.0.4: SdImportTest::testDocumentLayout fails

Dear Thorsten,


On 12.08.19 00:05, Thorsten Behrens wrote:

> Paul Menzel wrote:
>> Building LibreOffice 6.3.0.4 with `DISPLAY=` (unset) the test below fails.
>>
>> ```
>
> Can you run bin/odfvalidator.sh successfully from the shell? Possibly
> it does not find the right JRE (>=1.8).

     $ chmod +x bin/odfvalidator.sh
     $ ./bin/odfvalidator.sh -V
     odfvalidator v1.1.4


Kind regards,

Paul
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Stahl-3 Michael Stahl-3
Reply | Threaded
Open this post in threaded view
|

Re: 6.3.0.4: SdImportTest::testDocumentLayout fails


hi Paul,

On 12.08.19 02:01, Paul Menzel wrote:

> On 12.08.19 00:05, Thorsten Behrens wrote:
>
>> Paul Menzel wrote:
>>> Building LibreOffice 6.3.0.4 with `DISPLAY=` (unset) the test below
>>> fails.
>>>
>>> ```
>>
>> Can you run bin/odfvalidator.sh successfully from the shell? Possibly
>> it does not find the right JRE (>=1.8).
>
>      $ chmod +x bin/odfvalidator.sh
>      $ ./bin/odfvalidator.sh -V
>      odfvalidator v1.1.4


libreoffice-6-3 branch contains the following commit, but it is missing
in the 6.3.0.4 release. please apply it, it should give a better error
message; if you still don't see any reason why the validator fails it's
probably because the JVM doesn't even start.


commit 53ca96a5e0a77cd077f9b5690302d10faf8c5247
Author:     Michael Stahl <[hidden email]>
AuthorDate: Fri Jul 19 18:12:23 2019 +0200

     test: check validator exit code *after* checking validator output

     ODF validator may now actually exit with non-0 since commit
     b14e2f6c63c18894286c99ee8dde9070e24b41c2 - look for validation
errors in
     this case too.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Paul Menzel Paul Menzel
Reply | Threaded
Open this post in threaded view
|

Re: 6.3.0.4: SdImportTest::testDocumentLayout fails

Dear Michael,


On 12.08.19 11:07, Michael Stahl wrote:

> On 12.08.19 02:01, Paul Menzel wrote:
>> On 12.08.19 00:05, Thorsten Behrens wrote:
>>
>>> Paul Menzel wrote:
>>>> Building LibreOffice 6.3.0.4 with `DISPLAY=` (unset) the test below fails.
>>>>
>>>> ```
>>>
>>> Can you run bin/odfvalidator.sh successfully from the shell? Possibly
>>> it does not find the right JRE (>=1.8).
>>
>>      $ chmod +x bin/odfvalidator.sh
>>      $ ./bin/odfvalidator.sh -V
>>      odfvalidator v1.1.4
>
>
> libreoffice-6-3 branch contains the following commit, but it is
> missing in the 6.3.0.4 release. please apply it, it should give a
> better error message; if you still don't see any reason why the
> validator fails it's probably because the JVM doesn't even start.
>
> commit 53ca96a5e0a77cd077f9b5690302d10faf8c5247
> Author:     Michael Stahl <[hidden email]>
> AuthorDate: Fri Jul 19 18:12:23 2019 +0200
>
>     test: check validator exit code *after* checking validator output
>
>     ODF validator may now actually exit with non-0 since commit
>     b14e2f6c63c18894286c99ee8dde9070e24b41c2 - look for validation errors in
>     this case too.
After applying the patch, I see the results below.

```
$ make -j1 # still uses all threads though :(
[…]

make[1]: *** [/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/solenv/gbuild/CppunitTest.mk:113: /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/build/workdir/CppunitTest/sc_filters_test.test] Error 1

Exception in thread "main" java.lang.NullPointerException
        at org.odftoolkit.odfvalidator.ODFValidator.getValidatorForSchema(ODFValidator.java:286)
        at org.odftoolkit.odfvalidator.ODFValidator.getManifestValidator(ODFValidator.java:186)
        at org.odftoolkit.odfvalidator.ODFRootPackageValidator.validateManifest(ODFRootPackageValidator.java:170)
        at org.odftoolkit.odfvalidator.ODFRootPackageValidator.validatePre(ODFRootPackageValidator.java:93)
        at org.odftoolkit.odfvalidator.ODFPackageValidator._validate(ODFPackageValidator.java:111)
        at org.odftoolkit.odfvalidator.ODFPackageValidator.validate(ODFPackageValidator.java:81)
        at org.odftoolkit.odfvalidator.ODFValidator.validateFile(ODFValidator.java:163)
        at org.odftoolkit.odfvalidator.ODFValidator.validate(ODFValidator.java:125)
        at org.odftoolkit.odfvalidator.Main.main(Main.java:314)
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/test/source/bootstrapfixture.cxx:233:SdImportTest::testDocumentLayout
equality assertion failed
- Expected: 0
- Actual  : 256
- failed to execute: sh /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/build/bin/odfvalidator.sh -M /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng -D /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-dsig-schema-v1.3+libreoffice.rng -O /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng -m /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/mathml2/mathml2.xsd /tmp/lu167058k4jf7.tmp > /tmp/lu167058k4jfc.tmp
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng:  Fatal: /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng: file does not exist


SdImportTest::testDocumentLayout finished in: 19355ms

[…]

[CHK] sfx2
Exception in thread "main" java.lang.NullPointerException
        at org.odftoolkit.odfvalidator.ODFValidator.getValidatorForSchema(ODFValidator.java:286)
        at org.odftoolkit.odfvalidator.ODFValidator.getManifestValidator(ODFValidator.java:186)
        at org.odftoolkit.odfvalidator.ODFRootPackageValidator.validateManifest(ODFRootPackageValidator.java:170)
        at org.odftoolkit.odfvalidator.ODFRootPackageValidator.validatePre(ODFRootPackageValidator.java:93)
        at org.odftoolkit.odfvalidator.ODFPackageValidator._validate(ODFPackageValidator.java:111)
        at org.odftoolkit.odfvalidator.ODFPackageValidator.validate(ODFPackageValidator.java:81)
        at org.odftoolkit.odfvalidator.ODFValidator.validateFile(ODFValidator.java:163)
        at org.odftoolkit.odfvalidator.ODFValidator.validate(ODFValidator.java:125)
        at org.odftoolkit.odfvalidator.Main.main(Main.java:314)
file:///tmp/lu165138k4jdt.tmp/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/test/source/bootstrapfixture.cxx:233:PivotChartTest::testRoundtrip
equality assertion failed
- Expected: 0
- Actual  : 256
- failed to execute: sh /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/build/bin/odfvalidator.sh -M /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng -D /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-dsig-schema-v1.3+libreoffice.rng -O /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng -m /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/mathml2/mathml2.xsd /tmp/lu165138k4jdt.tmp > /tmp/lu165138k4jdz.tmp
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng:  Fatal: /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng: file does not exist


PivotChartTest::testRoundtrip finished in: 1778ms
PivotChartTest::testChangePivotTable finished in: 277ms

[…]
```

The file is indeed not there.

```
$ find . -name "*.rng"
./build/workdir/UnpackedTarball/liborcus/misc/OpenDocument-v1.2-os-schema.rng
./build/workdir/UnpackedTarball/raptor/tests/feeds/atom.rng
./build/workdir/UnpackedTarball/beanshell/docs/manual/foo.rng
./source/writerfilter/documentation/ooxml/model.rng
./source/xmloff/dtd/openoffice-2.0-schema.rng
```


Kind regards,

Paul


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

smime.p7s (6K) Download Attachment
Michael Stahl-3 Michael Stahl-3
Reply | Threaded
Open this post in threaded view
|

Re: 6.3.0.4: SdImportTest::testDocumentLayout fails

On 12.08.19 17:50, Paul Menzel wrote:
> On 12.08.19 11:07, Michael Stahl wrote:

> The file is indeed not there.
>
> ```
> $ find . -name "*.rng"
> ./build/workdir/UnpackedTarball/liborcus/misc/OpenDocument-v1.2-os-schema.rng
> ./build/workdir/UnpackedTarball/raptor/tests/feeds/atom.rng
> ./build/workdir/UnpackedTarball/beanshell/docs/manual/foo.rng
> ./source/writerfilter/documentation/ooxml/model.rng
> ./source/xmloff/dtd/openoffice-2.0-schema.rng
> ```

are you using tarballs to build? i believe the schema files are not in
the tarballs, intentionally, because they are not available with a FLOSS
license.

so you can either disable the validation, build from a git clone, or
copy the schema directory manually...
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Paul Menzel Paul Menzel
Reply | Threaded
Open this post in threaded view
|

Re: 6.3.0.4: SdImportTest::testDocumentLayout fails


Dear Michael,


On 12.08.19 17:55, Michael Stahl wrote:

> On 12.08.19 17:50, Paul Menzel wrote:
>> On 12.08.19 11:07, Michael Stahl wrote:
>
>> The file is indeed not there.
>>
>> ```
>> $ find . -name "*.rng"
>> ./build/workdir/UnpackedTarball/liborcus/misc/OpenDocument-v1.2-os-schema.rng
>> ./build/workdir/UnpackedTarball/raptor/tests/feeds/atom.rng
>> ./build/workdir/UnpackedTarball/beanshell/docs/manual/foo.rng
>> ./source/writerfilter/documentation/ooxml/model.rng
>> ./source/xmloff/dtd/openoffice-2.0-schema.rng
>> ```
>
> are you using tarballs to build?
Yes, of course. ;-)

> i believe the schema files are not in the tarballs, intentionally,
> because they are not available with a FLOSS license.
>
> so you can either disable the validation, build from a git clone, or
> copy the schema directory manually...

Since when is that the case? At least until LibreOffice 6.1.5.2 it worked.

So, tarball users should not run `make check`?


Kind regards,

Paul


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

smime.p7s (6K) Download Attachment
Michael Stahl-3 Michael Stahl-3
Reply | Threaded
Open this post in threaded view
|

Re: 6.3.0.4: SdImportTest::testDocumentLayout fails

On 12.08.19 18:03, Paul Menzel wrote:

>
> Dear Michael,
>
>
> On 12.08.19 17:55, Michael Stahl wrote:
>> On 12.08.19 17:50, Paul Menzel wrote:
>>> On 12.08.19 11:07, Michael Stahl wrote:
>>
>>> The file is indeed not there.
>>>
>>> ```
>>> $ find . -name "*.rng"
>>> ./build/workdir/UnpackedTarball/liborcus/misc/OpenDocument-v1.2-os-schema.rng
>>> ./build/workdir/UnpackedTarball/raptor/tests/feeds/atom.rng
>>> ./build/workdir/UnpackedTarball/beanshell/docs/manual/foo.rng
>>> ./source/writerfilter/documentation/ooxml/model.rng
>>> ./source/xmloff/dtd/openoffice-2.0-schema.rng
>>> ```
>>
>> are you using tarballs to build?
>
> Yes, of course. ;-)
>
>> i believe the schema files are not in the tarballs, intentionally,
>> because they are not available with a FLOSS license.
>>
>> so you can either disable the validation, build from a git clone, or
>> copy the schema directory manually...
>
> Since when is that the case? At least until LibreOffice 6.1.5.2 it worked.

apparently since

> commit 34dced99c33a97dab86c4538fa267ad4ad4fb41f
> Author:     Thorsten Behrens <[hidden email]>
> AuthorDate: Tue Aug 30 13:18:18 2016 +0200
>
>     Ignore schema files for src tarball generation
>  

which should be much older than 6.1?

> So, tarball users should not run `make check`?

just disable the validation, --without-export-validation

actually i guess it would be ideal if the configure script would just
check if the schemas are there or not, because it's a waste of time to
run into the problem via test failures, see
https://gerrit.libreoffice.org/#/c/77383/ for a patch to do that.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice