64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

classic Classic list List threaded Threaded
8 messages Options
slacka slacka
Reply | Threaded
Open this post in threaded view
|

64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

Both my own builds and the 64-bit Win tinderbox @42 are now failing with the following error:


[build CXX] sw/source/filter/ww8/ww8scan.cxx

C:/core/sw/source/filter/ww8/ww8scan.cxx(8445): error C2220: warning treated as error - no 'object' file generated

C:/core/sw/source/filter/ww8/ww8scan.cxx(8445): note: This diagnostic occurred in the compiler generated function 'WW8_FFN::WW8_FFN(const WW8_FFN &)'

C:/core/sw/source/filter/ww8/ww8scan.cxx(8445): warning C4315: 'WW8_FFN': 'this' pointer for member 'WW8_FFN::sFontname' may not be aligned 8 as expected by the constructor

C:/core/sw/source/filter/ww8/ww8scan.cxx(8445): note: This diagnostic occurred in the compiler generated function 'WW8_FFN::WW8_FFN(const WW8_FFN &)'

make[1]:

Makefile:286: recipe for target 'build' failed

make: *** [build] Error 2


Tinderbox 42: https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1532832601.8628

32-bit builds are successfully completing.

It looks like the error was caused by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8b8fb4ac654c8f847c35b93d701ba3475662ea69

convert pFontA to std::vector

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: 64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

I can confirm reverting:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8b8fb4ac

Fixes this issue, allowing the build to succeed.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|

Re: 64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

On Sun, 2018-07-29 at 22:23 +0000, Luke Benes wrote:
> I can confirm reverting:
>
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=8b8fb4ac
>
> Fixes this issue, allowing the build to succeed.

Maybe https://cgit.freedesktop.org/libreoffice/core/commit/?id=397c2e67
e6614f87e408432f63956f507a64023d will clear that warning/error
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: 64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

Caolán,
Sorry to report that:


Does not clear the warning. The build is failing with the same error.
From tinderbox Win-x86_64_42:


32-bit release builds are succeeding. 


-Luke


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|

Re: 64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

On Tue, 2018-07-31 at 03:48 +0000, Luke Benes wrote:
> Caolán,
> Sorry to report that:
>
>  https://cgit.freedesktop.org/libreoffice/core/commit/?id=397c2e67

I suppose
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4f13f8ddeebca1
de9fd30f0aae71e3f84383656a
made no difference either ?


> Does not clear the warning. The build is failing with the same error.
> From tinderbox Win-x86_64_42

don't seem to see any results listed for this since commit
108d4a6391eee22642fcb18ba429c2c9f4d8c818 2 days ago
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: 64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

Actually, it seems fixed now. I just did a clean 64-bit release build, and it succeeded without any errors. 

Was this a real issue or just a quirk in the compiler

Thank Caolán!


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|

Re: 64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

On Fri, 2018-08-03 at 04:02 +0000, Luke Benes wrote:
> Actually, it seems fixed now. I just did a clean 64-bit release
> build, and it succeeded without any errors.
>
> Was this a real issue or just a quirk in the compiler?

Seeing as no other compiler was complaining I assume so.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: 64-bit Windows build failure: 'this' pointer for member, may not be aligned 8 as expected by the constructor

I confirmed your 2nd attempt was the fix. After reverting:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4f13f8dd

the error came back.


The workaround code is ugly. If you're certain the logic is the same, you want to revert it and disable the warning TODO to enable them with future compiler? 

Here is an example:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=232622051966faa116e7093d5c0df26e44cddb43


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice