About simplifying sortElements in pdfiprocessor (sdext)
I noticed this part in PDFIProcessor::sortElements from
700 // HACK: the stable sort member on std::list that takes a
701 // strict weak ordering requires member templates - which we
702 // do not have on all compilers. so we need to use
703 // here - which does need random access iterators which the
704 // list iterators are not.
705 // so we need to copy the Element* to an array, stable sort
706 // copy them back.
707 std::vector<Element*> aChildren;
708 while( ! pEle->Children.empty() )
710 aChildren.push_back( pEle->Children.front() );
713 std::stable_sort( aChildren.begin(), aChildren.end(),
714 for (auto const& child : aChildren)
Re: About simplifying sortElements in pdfiprocessor (sdext)
Julien Nabet wrote:
> Is the comment still right for some compilers or may we use the sort
> method of std::list now ?
Pretty sure that's obsolete by now - repeat offender back in the day
was the Sun compiler, which we're obviously not supporting anymore.
[SOLVED] Re: About simplifying sortElements in pdfiprocessor (sdext)
On 02/02/2018 01:58, Thorsten Behrens wrote:
> ...Yeah looks like.
> Can you clean that up?
Thank your for your feedback, I submitted this patch on gerrit: