Build fail on Libgpg-error on Windows with gawk 5.0

classic Classic list List threaded Threaded
12 messages Options
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

Build fail on Libgpg-error on Windows with gawk 5.0

Hello,

On Win10, I updated Cygwin package and had the update gawk 5.0
The build failed because of the use of "namespace" as var name + wrong
substitution.

It's been fixed upstream (see
https://github.com/gpg/libgpg-error/commit/7865041c77f4f7005282f10f9b6666b19072fbdf)
but the last release hasn't included yet this fix.

I fixed Windows build locally by taking parts of the patch.
I haven't checked yet my gawk version on Linux (Debian testing).

Now I see 2 different actions possible:
- wait for next release of libgpg-error and include it on LO
- patch LO so it's ready for gawk 5.0 (but is it ok with gawk < 5.0)

I thought about checking if libgpg-error is still useful, it seems used by
gpgme which is used in xmlsecurity.
Now I'm not sure what to check.

Any thoughts?

Julien



--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Thorsten Behrens-6 Thorsten Behrens-6
Reply | Threaded
Open this post in threaded view
|

Re: Build fail on Libgpg-error on Windows with gawk 5.0

Hi Julien,

julien2412 wrote:
> It's been fixed upstream (see
> https://github.com/gpg/libgpg-error/commit/7865041c77f4f7005282f10f9b6666b19072fbdf)
> but the last release hasn't included yet this fix.
>
> I fixed Windows build locally by taking parts of the patch.
>
Thx a lot - then let's please carry that patch in LibreOffice until
upstream has included it in a release - we patch libgpg-error anyway,
see external/libgpg-error/UnpackedTarball_libgpg-error.mk - could you
add it there?

Cheers,

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (1K) Download Attachment
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

Re: Build fail on Libgpg-error on Windows with gawk 5.0

On 23/04/2019 18:01, Thorsten Behrens wrote:

> Hi Julien,
>
> julien2412 wrote:
>> It's been fixed upstream (see
>> https://github.com/gpg/libgpg-error/commit/7865041c77f4f7005282f10f9b6666b19072fbdf)
>> but the last release hasn't included yet this fix.
>>
>> I fixed Windows build locally by taking parts of the patch.
>>
> Thx a lot - then let's please carry that patch in LibreOffice until
> upstream has included it in a release - we patch libgpg-error anyway,
> see external/libgpg-error/UnpackedTarball_libgpg-error.mk - could you
> add it there?

Thank you Thorsten for your feedback, I've just submitted the patch on
gerrit, see https://gerrit.libreoffice.org/#/c/71144/

Julien

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

[ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

On 23/04/2019 21:27, Julien Nabet wrote:

> On 23/04/2019 18:01, Thorsten Behrens wrote:
>> Hi Julien,
>>
>> julien2412 wrote:
>>> It's been fixed upstream (see
>>> https://github.com/gpg/libgpg-error/commit/7865041c77f4f7005282f10f9b6666b19072fbdf)
>>>
>>> but the last release hasn't included yet this fix.
>>>
>>> I fixed Windows build locally by taking parts of the patch.
>>>
>> Thx a lot - then let's please carry that patch in LibreOffice until
>> upstream has included it in a release - we patch libgpg-error anyway,
>> see external/libgpg-error/UnpackedTarball_libgpg-error.mk - could you
>> add it there?
>
> Thank you Thorsten for your feedback, I've just submitted the patch on
> gerrit, see https://gerrit.libreoffice.org/#/c/71144/

Gerrit failed on it. I had the same on Linux but thought it was
something else. Since I got no idea of the pb and don't want to waste
some time on it, let's wait next release of libgpg-error.

Julien

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Thorsten Behrens-6 Thorsten Behrens-6
Reply | Threaded
Open this post in threaded view
|

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

Hi Julien,

Julien Nabet wrote:
> Gerrit failed on it. I had the same on Linux but thought it was something
> else. Since I got no idea of the pb and don't want to waste some time on it,
> let's wait next release of libgpg-error.
>
Ugh - so it seems that there are breaking changes in gawk 5.0 then?

Didn't find much else beyond this announcement on hacker news:

  https://news.ycombinator.com/item?id=19671983

, but at any rate there's apparently older gawk packages still
available for cygwin:

  https://cygwin.com/packages/x86_64/gawk/

Cheers,

-- Thorsten
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (1K) Download Attachment
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

We are still using libgpg-error v1.27 but the latest version on their
download page is 1.36. Can we update this tarball so that new LODE installs
can work again?

https://gnupg.org/download/index.html#libgpg-error




--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Thorsten Behrens-6 Thorsten Behrens-6
Reply | Threaded
Open this post in threaded view
|

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

Hi Luke,

slacka wrote:
> Can we update this tarball so that new LODE installs can work again?
>
I've uploaded the tarball to
https://dev-www.libreoffice.org/src/libgpg-error-1.36.tar.bz2 - want
to have a go at updating the reference in download.lst (and
potentially tweaking a few patches)?

Cheers,

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (1K) Download Attachment
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

https://dev-www.libreoffice.org/src/libgpg-error-1.36.tar.bz2

I'm getting:  403 Forbidden Error

https://dev-www.libreoffice.org/src/libgpg-error-1.27.tar.bz2

Correctly downloads the tarball

After the 403 issue with 1.36 is fixed, I'll be happy to create a patch to update download.lst and attempt to fix any resulting issues.

However, this is an urgent issue. LODE is a key component of LO's developer infrastructure. It's what new users are directed to use, and existing users like myself are forced to update it when component levels are bumped. (I was forced to update as gperf-3.0.4-2 is no longer sufficient to build master.) If we can't get LODE working soon, we should ask the ESC for assistance.

-Luke











From: Thorsten Behrens <[hidden email]>
Sent: Wednesday, May 22, 2019 12:42 AM
To: slacka
Cc: [hidden email]
Subject: Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0
 

Hi Luke,

slacka wrote:
> Can we update this tarball so that new LODE installs can work again?
>
I've uploaded the tarball to
https://dev-www.libreoffice.org/src/libgpg-error-1.36.tar.bz2 - want
to have a go at updating the reference in download.lst (and
potentially tweaking a few patches)?

Cheers,

-- Thorsten
   
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

On 22/05/2019 17:45, Luke Benes wrote:
> https://dev-www.libreoffice.org/src/libgpg-error-1.36.tar.bz2
>
> I'm getting:????403 Forbidden Error
> ...

No pb here to download it. Perhaps it was just a temporary pb, do you
still reproduce this?

Julien

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0


Thorsten fixed it. It's working now for me. Thanks!
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

In reply to this post by slacka
This long weekend, I attempted to update the patch for libgpg-error-1.36. This went well until I hit a new file in 1.36, sysutils.c, which makes use of  a UNIX header <unistd.h>.  Thorsten converted this to a win32's <io.h> in other files,[1] but following his example didn't work for me here.

We really need to get libgpg-error updated so that anyone upgrading LODE or doing a new install can have a working Windows build.  Unfortunately, I'm out of time for this week, so someone else is going to have to take over from here. I'd be glad to share my patch if you want to save a few min.

-Luke

[1] https://cgit.freedesktop.org/libreoffice/core/commit/?id=4be15fdd7974
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Sophia Schröder-3 Sophia Schröder-3
Reply | Threaded
Open this post in threaded view
|

Re: [ABANDONED] Re: Build fail on Libgpg-error on Windows with gawk 5.0

Downgrading gawk to 4.2.1 is the best way to let it work ootb.

Am 27.05.2019 um 17:58 schrieb Luke Benes:

> This long weekend, I attempted to update the patch for libgpg-error-1.36. This went well until I hit a new file in 1.36, sysutils.c, which makes use of  a UNIX header <unistd.h>.  Thorsten converted this to a win32's <io.h> in other files,[1] but following his example didn't work for me here.
>
> We really need to get libgpg-error updated so that anyone upgrading LODE or doing a new install can have a working Windows build.  Unfortunately, I'm out of time for this week, so someone else is going to have to take over from here. I'd be glad to share my patch if you want to save a few min.
>
> -Luke
>
> [1] https://cgit.freedesktop.org/libreoffice/core/commit/?id=4be15fdd7974
> _______________________________________________
> LibreOffice mailing list
> [hidden email]
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Kindly Regards / Mit freundlichen Grüßen

Sophia Schröder
www.libreoffice.org
German Language Team
Help Files Debugger
IRC@freenode: SophiaS



_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (235 bytes) Download Attachment