Calc recalculate bugs

classic Classic list List threaded Threaded
6 messages Options
Dennis Francis Dennis Francis
Reply | Threaded
Open this post in threaded view
|

Calc recalculate bugs

Hi Eike,

I see that you are working on tdf#123714 and also on the related bugs tdf#123736, tdf#120660 and tdf#120013 and you already have many fixes in. It seems there are many sub issues mentioned by the reporter at least in tdf#123714. I wonder if there are any sub issues there that you did/will not get a chance to work on etc. In that case I'd be happy to help and try fix some of the remaining ones if it is ok with you of course. Please do let me know :)

Thanks,
Dennis


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: Calc recalculate bugs

Hi Dennis,

On Thursday, 2019-03-21 16:40:51 +0530, Dennis Francis wrote:

> I see that you are working on tdf#123714 and also on the related bugs
> tdf#123736, tdf#120660 and tdf#120013 and you already have many fixes in.
> It seems there are many sub issues mentioned by the reporter at least in
> tdf#123714. I wonder if there are any sub issues there that you did/will
> not get a chance to work on etc. In that case I'd be happy to help and try
> fix some of the remaining ones if it is ok with you of course. Please do
> let me know :)

Yes please, feel free to work on any you come across. In particular
I did not tackle tdf#120660 yet. I also created
https://bugs.documentfoundation.org/show_bug.cgi?id=124266
for a repaint failure that makes a cell appear as if it was not
recalculated but in fact it is, just not repainted.

I added unit tests for the work I did so far and cherry-picked/squashed
the current fixes into https://gerrit.libreoffice.org/69554 for 6-2,
would be nice if you could review that it suits the needs and doesn't
break anything.. I decided to also cherry-pick the unit tests with
https://gerrit.libreoffice.org/69555 so we'll have those in 6-2 as well.
The actual bugs mentioned (plus some more I came across during
work) are fixed now.

  Eike

--
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Dennis Francis Dennis Francis
Reply | Threaded
Open this post in threaded view
|

Re: Calc recalculate bugs

Hi Eike,

On Fri, Mar 22, 2019 at 7:06 PM Eike Rathke <[hidden email]> wrote:
Hi Dennis, 
Yes please, feel free to work on any you come across. In particular
I did not tackle tdf#120660 yet. I also created
https://bugs.documentfoundation.org/show_bug.cgi?id=124266
for a repaint failure that makes a cell appear as if it was not
recalculated but in fact it is, just not repainted.

Thanks ! I'll try to fix tdf#120660 now and will look at the repaint issue later.
 
I added unit tests for the work I did so far and cherry-picked/squashed
the current fixes into https://gerrit.libreoffice.org/69554 for 6-2,
would be nice if you could review that it suits the needs and doesn't
break anything.. I decided to also cherry-pick the unit tests with
https://gerrit.libreoffice.org/69555 so we'll have those in 6-2 as well.
The actual bugs mentioned (plus some more I came across during
work) are fixed now.

Sure, I will go through both.

Thanks,
Dennis 

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Oliver Brinzing Oliver Brinzing
Reply | Threaded
Open this post in threaded view
|

Re: Calc recalculate bugs

Hi Eike, Hi Dennis,

thanks a lot for start fixing these bugs :-)

and there is at least another one:
https://bugs.documentfoundation.org/show_bug.cgi?id=120270

btw: are there any plans to backport these fixes to the 6.1 branch?

Regards
Oliver

Am 22.03.2019 um 17:36 schrieb Dennis Francis:

> Hi Eike,
>
> On Fri, Mar 22, 2019 at 7:06 PM Eike Rathke <[hidden email]> wrote:
>
>> Hi Dennis,
>
> Yes please, feel free to work on any you come across. In particular
>> I did not tackle tdf#120660 yet. I also created
>> https://bugs.documentfoundation.org/show_bug.cgi?id=124266
>> for a repaint failure that makes a cell appear as if it was not
>> recalculated but in fact it is, just not repainted.
>>
>
> Thanks ! I'll try to fix tdf#120660 now and will look at the repaint issue
> later.
>
>
>> I added unit tests for the work I did so far and cherry-picked/squashed
>> the current fixes into https://gerrit.libreoffice.org/69554 for 6-2,
>> would be nice if you could review that it suits the needs and doesn't
>> break anything.. I decided to also cherry-pick the unit tests with
>> https://gerrit.libreoffice.org/69555 so we'll have those in 6-2 as well.
>> The actual bugs mentioned (plus some more I came across during
>> work) are fixed now.
>>
>
> Sure, I will go through both.
>
> Thanks,
> Dennis
>
>
> _______________________________________________
> LibreOffice mailing list
> [hidden email]
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: Calc recalculate bugs

Hi Oliver,

On Friday, 2019-03-22 19:21:23 +0100, Oliver Brinzing wrote:

> btw: are there any plans to backport these fixes to the 6.1 branch?

I'd say that if https://gerrit.libreoffice.org/69554 is considered to be
*very* safe (by others than me) then yes, otherwise the upcoming 6.1.6
is the last 6.1.z release without any chance to fix anything thereafter.

On the other hand, IMHO it can't get worse with the fix than without the
fix, but add this to famous last words..

  Eike

--
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Xisco Fauli Xisco Fauli
Reply | Threaded
Open this post in threaded view
|

Re: Calc recalculate bugs

Hello,

Unless there's a good reason to do it, I would prefer not to backport them to 6.1 for two reasons:

- As Eike mentioned, 6.1.6 is the last release before hitting the EOL.

- The regressions fixed have been around for quite some time now ( introduced in Libo 4.4 and 5.3 )

My two cents

El 25/3/19 a les 17:29, Eike Rathke ha escrit:
Hi Oliver,

On Friday, 2019-03-22 19:21:23 +0100, Oliver Brinzing wrote:

btw: are there any plans to backport these fixes to the 6.1 branch?
I'd say that if https://gerrit.libreoffice.org/69554 is considered to be
*very* safe (by others than me) then yes, otherwise the upcoming 6.1.6
is the last 6.1.z release without any chance to fix anything thereafter.

On the other hand, IMHO it can't get worse with the fix than without the
fix, but add this to famous last words..

  Eike


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
-- 
Xisco Faulí
Libreoffice QA Team
IRC: x1sc0

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice