CppunitTest_chart2_xshape Failure with Display Scaling on Windows

classic Classic list List threaded Threaded
7 messages Options
slacka slacka
Reply | Threaded
Open this post in threaded view
|

CppunitTest_chart2_xshape Failure with Display Scaling on Windows

Mike,
The fix for Bug 121685, https://cgit.freedesktop.org/libreoffice/core/commit/?id=7263d223ddf4
Is causing the core Unit Test CppunitTest_chart2_xshape to fail when you set,  Settings->Display->Scale=125%​
Setting Scale=100% allows the build to pass with no errors. ​
Build log:​
https://pastebin.com/SpSiCm6u


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Kaganski Mike Kaganski Mike
Reply | Threaded
Open this post in threaded view
|

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

Hi Luke!

On 12/16/2018 10:57 PM, Luke Benes wrote:
> The fix for *Bug 121685*
> <https://bugs.documentfoundation.org/show_bug.cgi?id=121685>,
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=7263d223ddf4
> ​
> Is causing the core Unit Test CppunitTest_chart2_xshape to fail when you
> set,  Settings->Display->Scale=125%​

Unfortunately cannot repro locally. Possibly it's worth trying to only
add manifest to soffice.bin, not to all console applications. Will try
that tomorrow.

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan-Marek Glogowski Jan-Marek Glogowski
Reply | Threaded
Open this post in threaded view
|

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

In reply to this post by slacka
Am 16. Dezember 2018 20:57:51 MEZ schrieb Luke Benes <[hidden email]>:
>The fix for Bug
>121685<https://bugs.documentfoundation.org/show_bug.cgi?id=121685>,
>https://cgit.freedesktop.org/libreoffice/core/commit/?id=7263d223ddf4
>​
>Is causing the core Unit Test CppunitTest_chart2_xshape to fail when
>you set,  Settings->Display->Scale=125%​

I had similar problems when I implemented https://cgit.freedesktop.org/libreoffice/core/commit?id=ada20402efa81273e03e46cbedc21f25b9daeeac

I'll just call this headless+, as this involves setting SAL_USE_VCLPLUGIN=svp and will only render output to bitmaps. The UI tests run this way without --headless, so they also get headless dialogs.

I found that various test failed, because DPI is an integer and our code results in various rounding errors sometimes adding up to large amounts. The headless / svp plugin already uses 96 DPI and now the headless+ mode in the osx plugin does the same. For similar reason IOS also explicitly sets 96 DPI.

The win plugin should also get a headless+ patch like the osx plugin, which just uses fixed 96 DPI. That's sufficient as a general test environment.

Actually it would also be nice to move the platform-independent stuff from Svp classes either into the Sal base classes or move platform stuff for IOS and Android into their own classes. My osx patch already duplicates code from headless, but I wanted that out without refactoring and breaking VCL again.
I had my share of unveiled bugs and breaking VCL this year. Maybe I'm more brave next year again ;-)

Jan-Marek

P.S. and maybe someone has some better / self-explaining name for the *BitmapRendering() functions. People complained but nobody proposed a better name yet.

P.P.S. implementing a SetHeadlessDPI-API might be a useable addition later. DPI already works per SalFrame, so a LO server should be able to render stuff for different DPIs. Actually that should already work, if you work with multiple screens with different DPIs, but at least in the osx backend the comments in the DPI detection code read as it is currently very broken.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
sberg sberg
Reply | Threaded
Open this post in threaded view
|

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

In reply to this post by Kaganski Mike
On 16/12/2018 22:35, Kaganski Mike wrote:
> Unfortunately cannot repro locally. Possibly it's worth trying to only
> add manifest to soffice.bin, not to all console applications. Will try
> that tomorrow.

While that might fix CppunitTests, it likely would leave a similar
(potential) issue in other tests like JunitTests that internally spawn
an soffice.bin process.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Stahl-3 Michael Stahl-3
Reply | Threaded
Open this post in threaded view
|

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

On 17.12.18 09:25, Stephan Bergmann wrote:
> On 16/12/2018 22:35, Kaganski Mike wrote:
>> Unfortunately cannot repro locally. Possibly it's worth trying to only
>> add manifest to soffice.bin, not to all console applications. Will try
>> that tomorrow.
>
> While that might fix CppunitTests, it likely would leave a similar
> (potential) issue in other tests like JunitTests that internally spawn
> an soffice.bin process.

but that isn't a new problem, since soffice.bin had that manifest
applied to it before the recent changes?
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
sberg sberg
Reply | Threaded
Open this post in threaded view
|

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

On 17/12/2018 11:07, Michael Stahl wrote:

> On 17.12.18 09:25, Stephan Bergmann wrote:
>> On 16/12/2018 22:35, Kaganski Mike wrote:
>>> Unfortunately cannot repro locally. Possibly it's worth trying to only
>>> add manifest to soffice.bin, not to all console applications. Will try
>>> that tomorrow.
>>
>> While that might fix CppunitTests, it likely would leave a similar
>> (potential) issue in other tests like JunitTests that internally spawn
>> an soffice.bin process.
>
> but that isn't a new problem, since soffice.bin had that manifest
> applied to it before the recent changes?

Probably (and it is apparently a hypothetical problem as of now anyway).
  Just sounds like adapting cppunittester to solve that immediate issue
would be a workaround rather than a proper fix.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Kaganski Mike Kaganski Mike
Reply | Threaded
Open this post in threaded view
|

Re: CppunitTest_chart2_xshape Failure with Display Scaling on Windows

In reply to this post by slacka
Hi,

On 16.12.2018 22:57, Luke Benes wrote:

> Mike,
> The fix for *Bug 121685*
> <https://bugs.documentfoundation.org/show_bug.cgi?id=121685>,
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=7263d223ddf4
> ​
> Is causing the core Unit Test CppunitTest_chart2_xshape to fail when you
> set,  Settings->Display->Scale=125%​
> ​
> Setting Scale=100% allows the build to pass with no errors. ​
> ​
> Build log:​
> https://pastebin.com/SpSiCm6u

This is addressed in https://gerrit.libreoffice.org/65595. Note that the
change does not implement the approach suggested by jmux in [1] (because
I don't have enough knowledge), and only properly fixes one test to
consider system DPI. The other affected tests are disabled for now in
cases of non-default DPI values, which of course would need to be
reverted once a proper fix is implemented.

[1]
https://lists.freedesktop.org/archives/libreoffice/2018-December/081591.html

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice