GSOC 2012 , submitting a patch for easy hack

classic Classic list List threaded Threaded
15 messages Options
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

GSOC 2012 , submitting a patch for easy hack

Hi Everyone ,
I am GSOC 2012 Aspirant and a 2nd year undergraduate from NMIMS University, Mumbai.

I am interested in the android development concerning the Idea "Use your SmartPhone to remote-control slideshow" . I plan to use the WLAN and Bluetooth to achieve this. Also I plan to add a feature to this app , to change slides by using the accelerometer phone sensor , so that user can change the slide by simply giving a jerk in the required direction. Till now i have managed to get a reasonable stable connection between a laptop and phone which can find each other when connected to the same network.

Also , I am new to open-source and community based development , I managed to patch an Easy Hack

Easy Hack 47864 - UI: Add HELP button and content to Starmath Font size dialog

I have committed this to my local git repository and re-based to master branch , however i am having trouble making a patch file , I get this output by the command git show :


commit 3429351866f18e20693fb97b70d6d2c40b62f259
Author: Karan <karan@karan-VirtualBox.(none)>
Date:   Sat Mar 31 08:27:10 2012 +0530

    Added help button in Fontsize dialog of starmath

diff --git a/starmath/inc/dialog.hxx b/starmath/inc/dialog.hxx
index de3a02f..9415114 100644
--- a/starmath/inc/dialog.hxx
+++ b/starmath/inc/dialog.hxx
@@ -143,11 +143,13 @@ class SmFontSizeDialog : public ModalDialog
     FixedText       aFixedText8;
     MetricField     aBorderSize;
     FixedLine       aFixedLine1;
+    HelpButton      aHelpButton;
     OKButton        aOKButton1;
     CancelButton    aCancelButton1;
     PushButton      aDefaultButton;
 
     DECL_LINK(DefaultButtonClickHdl, Button *);
+    DECL_LINK(HelpButtonClickHdl, Button *);
 
 public:
     SmFontSizeDialog(Window *pParent, bool bFreeRes = true);
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index 4895514..1c961ee 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -43,6 +43,7 @@
 #include <vcl/waitobj.hxx>
 #include <vcl/settings.hxx>
 #include <vcl/wall.hxx>
+#include "vcl/help.hxx"
 #include <sfx2/dispatch.hxx>
 #include <sfx2/sfx.hrc>
 #include <tools/string.hxx>
@@ -439,6 +440,17 @@ IMPL_LINK( SmFontSizeDialog, DefaultButtonClickHdl, Button *, EMPTYARG /*pButton
     return 0;
 }
 
+IMPL_LINK( SmFontSizeDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )
+{
+    // start help system
+    Help* pHelp = Application::GetHelp();
+    if( pHelp )
+    {
+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTSIZEDIALOG" ) ), &aHelpButton );
+    }
+    return 0;
+}
+
:

How can I get a patch file for my commit , I tried the instructions on wiki page , but that did not generate any file :(
Olivier Hallot Olivier Hallot
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Karam

Em 31-03-2012 01:06, kud360 escreveu:
> How can I get a patch file for my commit , I tried the instructions on wiki
> page , but that did not generate any file :(


after comitting, if you used git format-patch, you will have a
"0001-<...>.patch" file in your git root folder.

Note that the Help text already exist as indicated in the bug entry. You
need to link the right help page to your patch

Regards
- --
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPdtmfAAoJEJp3R7nH3vLxjXQH/jIAG9E9LIE68fAnYyYkJ25w
WKQzpX752azFpJzblfH1CgyasOJ1MTxUTAigcgC1PoGz/8iapxSpsVd69Ok8dRB7
bf71Ei7cYzAH4Nn77uF/Pn7xuwh/px5q+JsextkG7ZH0DIcewVutijyxtGOAPvOY
W41JYVLERXOFoMdueTF8kbuJ0bJbliQIFc+A0PeierPhkAfJuw8HS0llsoj7Xmx2
DLe0UzyaRULkVEppaVbGN18imU4T4BzjuGfjtJySbCF0g8zPsWYCWhNd0GHhoRGX
2yJr6r5oPO8rL7sYF/3YFkhum+JUGrvxx/5ncKq9Ieejo1ebBD03ksgPQgfgpjU=
=iehz
-----END PGP SIGNATURE-----
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack



On Sat, Mar 31, 2012 at 3:48 PM, Olivier Hallot [via Document Foundation Mail Archive] <[hidden email]> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Karam

Em 31-03-2012 01:06, kud360 escreveu:
> How can I get a patch file for my commit , I tried the instructions on wiki
> page , but that did not generate any file :(


after comitting, if you used git format-patch, you will have a
"0001-<...>.patch" file in your git root folder.

I think I got this one right : 
I added help buttons to all the dialog boxes that did not have them , i used 
git format-patch master stdout > helpbuttons.patch

Here are the contents of the file :

===== main repo =====

From 85c5692ac3fd5b788eec95dcb3389e70c59db6b1 Mon Sep 17 00:00:00 2001

From: Karan <karan@karan-VirtualBox.(none)>

Date: Sat, 31 Mar 2012 11:57:15 +0530

Subject: [PATCH 1/2] Added Help Button to



SmFontDialog

SmFontSizeDialog

SmFontTypeDialog

SmDistanceDialog

SmAlignDialog

SmSymbolDialog

SmSymDefineDialog

---

 starmath/inc/dialog.hxx    |   14 +++++++

 starmath/source/dialog.cxx |   88 +++++++++++++++++++++++++++++++++++++++++++-

 starmath/source/smres.src  |   62 +++++++++++++++++++++++++++++-

 3 files changed, 160 insertions(+), 4 deletions(-)



diff --git a/starmath/inc/dialog.hxx b/starmath/inc/dialog.hxx

index de3a02f..23f1297 100644

--- a/starmath/inc/dialog.hxx

+++ b/starmath/inc/dialog.hxx

@@ -105,6 +105,7 @@ class SmFontDialog : public ModalDialog

     CheckBox        aBoldCheckBox;

     CheckBox        aItalicCheckBox;

     OKButton        aOKButton1;

+    HelpButton      aHelpButton1;

     CancelButton    aCancelButton1;

     SmShowFont      aShowFont;

     FixedText       aFixedText2;

@@ -114,6 +115,7 @@ class SmFontDialog : public ModalDialog

     DECL_LINK(FontSelectHdl, ComboBox *);

     DECL_LINK(FontModifyHdl, ComboBox *);

     DECL_LINK(AttrChangeHdl, CheckBox *);

+    DECL_LINK(HelpButtonClickHdl, Button *);

 

     void            InitColor_Impl();

 

@@ -144,10 +146,12 @@ class SmFontSizeDialog : public ModalDialog

     MetricField     aBorderSize;

     FixedLine       aFixedLine1;

     OKButton        aOKButton1;

+    HelpButton      aHelpButton1;

     CancelButton    aCancelButton1;

     PushButton      aDefaultButton;

 

     DECL_LINK(DefaultButtonClickHdl, Button *);

+    DECL_LINK(HelpButtonClickHdl, Button *);

 

 public:

     SmFontSizeDialog(Window *pParent, bool bFreeRes = true);

@@ -177,6 +181,7 @@ class SmFontTypeDialog : public ModalDialog

     FixedLine           aFixedLine1;

     FixedLine           aFixedLine2;

     OKButton            aOKButton1;

+    HelpButton          aHelpButton1;

     CancelButton        aCancelButton1;

     MenuButton          aMenuButton;

     PushButton          aDefaultButton;

@@ -185,6 +190,7 @@ class SmFontTypeDialog : public ModalDialog

 

     DECL_LINK(MenuSelectHdl, Menu *);

     DECL_LINK(DefaultButtonClickHdl, Button *);

+    DECL_LINK(HelpButtonClickHdl, Button *);

 

 public:

     SmFontTypeDialog(Window *pParent, OutputDevice *pFntListDevice, bool bFreeRes = true);

@@ -236,6 +242,7 @@ class SmDistanceDialog : public ModalDialog

     FixedText       aFixedText4;

     MetricField     aMetricField4;

     OKButton        aOKButton1;

+    HelpButton      aHelpButton1;

     CancelButton    aCancelButton1;

     MenuButton      aMenuButton;

     PushButton      aDefaultButton;

@@ -249,6 +256,7 @@ class SmDistanceDialog : public ModalDialog

     DECL_LINK(GetFocusHdl, Control *);

     DECL_LINK(MenuSelectHdl, Menu *);

     DECL_LINK(DefaultButtonClickHdl, Button *);

+    DECL_LINK(HelpButtonClickHdl, Button *);

     DECL_LINK(CheckBoxClickHdl, CheckBox *);

 

     using   Window::SetHelpId;

@@ -277,10 +285,12 @@ class SmAlignDialog : public ModalDialog

     RadioButton  aRight;

     FixedLine    aFixedLine1;

     OKButton     aOKButton1;

+    HelpButton   aHelpButton1;

     CancelButton aCancelButton1;

     PushButton   aDefaultButton;

 

     DECL_LINK(DefaultButtonClickHdl, Button *);

+    DECL_LINK(HelpButtonClickHdl, Button *);

 

 public:

     SmAlignDialog(Window *pParent, bool bFreeRes = true);

@@ -348,6 +358,7 @@ class SmSymbolDialog : public ModalDialog

     SmShowSymbolSet aSymbolSetDisplay;

     FixedText       aSymbolName;

     SmShowSymbol    aSymbolDisplay;

+    HelpButton      aHelpBtn;

     PushButton      aGetBtn;

     PushButton      aCloseBtn;

     PushButton      aEditBtn;

@@ -366,6 +377,7 @@ class SmSymbolDialog : public ModalDialog

     DECL_LINK(CloseClickHdl, Button *);

     DECL_LINK(EditClickHdl, Button *);

     DECL_LINK(GetClickHdl, Button *);

+    DECL_LINK(HelpButtonClickHdl, Button *);

 

     void            FillSymbolSets(bool bDeleteText = true);

     void            SetSymbolSetManager(SmSymbolManager &rMgr);

@@ -426,6 +438,7 @@ class SmSymDefineDialog : public ModalDialog

     SmShowChar      aSymbolDisplay;

     FixedText       aSymbolSetName;

     OKButton        aOkBtn;

+    HelpButton      aHelpBtn;

     CancelButton    aCancelBtn;

     PushButton      aAddBtn;

     PushButton      aChangeBtn;

@@ -450,6 +463,7 @@ class SmSymDefineDialog : public ModalDialog

     DECL_LINK(AddClickHdl, Button *);

     DECL_LINK(ChangeClickHdl, Button *);

     DECL_LINK(DeleteClickHdl, Button *);

+    DECL_LINK(HelpButtonClickHdl, Button *);

 

     void    FillSymbols(ComboBox &rComboBox, bool bDeleteText = true);

     void    FillSymbolSets(ComboBox &rComboBox, bool bDeleteText = true);

diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx

index 4895514..8c9f72e 100644

--- a/starmath/source/dialog.cxx

+++ b/starmath/source/dialog.cxx

@@ -327,6 +327,16 @@ void SmFontDialog::SetFont(const Font &rFont)

     aShowFont.SetFont(Face);

 }

 

+IMPL_LINK( SmFontDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

+{

+    // start help system

+    Help* pHelp = Application::GetHelp();

+    if( pHelp )

+    {

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTDIALOG" ) ), &aHelpButton );

+    }

+    return 0;

+}

 

 SmFontDialog::SmFontDialog(Window * pParent,

         OutputDevice *pFntListDevice, bool bHideCheckboxes, bool bFreeRes)

@@ -336,12 +346,14 @@ SmFontDialog::SmFontDialog(Window * pParent,

     aBoldCheckBox   (this, SmResId(1)),

     aItalicCheckBox (this, SmResId(2)),

     aOKButton1      (this, SmResId(1)),

+    aHelpButton1    (this, SmResId(1))

     aCancelButton1  (this, SmResId(1)),

     aShowFont       (this, SmResId(1)),

     aFixedText2     (this, SmResId(2))

 {

     if (bFreeRes)

         FreeResource();

+    aHelpButton1.SetClickHdl(LINK(this, SmFontSDialog, HelpButtonClickHdl));

 

     {

         WaitObject( this );

@@ -410,7 +422,6 @@ void SmFontDialog::InitColor_Impl()

     aShowFont.SetTextColor( aTxtColor );

 }

 

-

 void SmFontDialog::DataChanged( const DataChangedEvent& rDCEvt )

 {

     if ( rDCEvt.GetType() == DATACHANGED_SETTINGS  &&

@@ -439,6 +450,16 @@ IMPL_LINK( SmFontSizeDialog, DefaultButtonClickHdl, Button *, EMPTYARG /*pButton

     return 0;

 }

 

+IMPL_LINK( SmFontSizeDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

+{

+    // start help system

+    Help* pHelp = Application::GetHelp();

+    if( pHelp )

+    {

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTSIZEDIALOG" ) ), &aHelpButton );

+    }

+    return 0;

+}

 

 SmFontSizeDialog::SmFontSizeDialog(Window * pParent, bool bFreeRes)

     : ModalDialog(pParent, SmResId(RID_FONTSIZEDIALOG)),

@@ -455,6 +476,7 @@ SmFontSizeDialog::SmFontSizeDialog(Window * pParent, bool bFreeRes)

     aFixedText8(this, SmResId(8)),

     aBorderSize(this, SmResId(8)),

     aFixedLine1(this, SmResId(1)),

+    aHelpButton1(this, SmResId(1)),

     aOKButton1(this, SmResId(1)),

     aCancelButton1(this, SmResId(1)),

     aDefaultButton(this, SmResId(1))

@@ -463,6 +485,7 @@ SmFontSizeDialog::SmFontSizeDialog(Window * pParent, bool bFreeRes)

         FreeResource();

 

     aDefaultButton.SetClickHdl(LINK(this, SmFontSizeDialog, DefaultButtonClickHdl));

+    aHelpButton1.SetClickHdl(LINK(this, SmFontSizeDialog, HelpButtonClickHdl));

 }

 

 

@@ -547,6 +570,16 @@ IMPL_LINK_INLINE_START( SmFontTypeDialog, DefaultButtonClickHdl, Button *, EMPTY

 }

 IMPL_LINK_INLINE_END( SmFontTypeDialog, DefaultButtonClickHdl, Button *, pButton )

 

+IMPL_LINK( SmFontTypeDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

+{

+    // start help system

+    Help* pHelp = Application::GetHelp();

+    if( pHelp )

+    {

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTTYPEDIALOG" ) ), &aHelpButton );

+    }

+    return 0;

+}

 

 SmFontTypeDialog::SmFontTypeDialog(Window * pParent, OutputDevice *pFntListDevice, bool bFreeRes)

     : ModalDialog(pParent, SmResId(RID_FONTTYPEDIALOG)),

@@ -567,6 +600,7 @@ SmFontTypeDialog::SmFontTypeDialog(Window * pParent, OutputDevice *pFntListDevic

     aFixedLine1    (this, SmResId(1)),

     aFixedLine2    (this, SmResId(2)),

     aOKButton1     (this, SmResId(1)),

+    aHelpButton1   (this, SmResId(1)),

     aCancelButton1 (this, SmResId(1)),

     aMenuButton    (this, SmResId(1)),

     aDefaultButton (this, SmResId(2)),

@@ -576,6 +610,7 @@ SmFontTypeDialog::SmFontTypeDialog(Window * pParent, OutputDevice *pFntListDevic

         FreeResource();

 

     aDefaultButton.SetClickHdl(LINK(this, SmFontTypeDialog, DefaultButtonClickHdl));

+    aHelpButton1.SetClickHdl(LINK(this, SmFontTypeDialog, HelpButtonClickHdl));

 

     aMenuButton.GetPopupMenu()->SetSelectHdl(LINK(this, SmFontTypeDialog, MenuSelectHdl));

 }

@@ -748,6 +783,17 @@ IMPL_LINK( SmDistanceDialog, DefaultButtonClickHdl, Button *, EMPTYARG /*pButton

     return 0;

 }

 

+IMPL_LINK( SmDistanceDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

+{

+    // start help system

+    Help* pHelp = Application::GetHelp();

+    if( pHelp )

+    {

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_DISTANCEDIALOG" ) ), &aHelpButton );

+    }

+    return 0;

+}

+

 

 IMPL_LINK( SmDistanceDialog, CheckBoxClickHdl, CheckBox *, pCheckBox )

 {

@@ -927,6 +973,7 @@ SmDistanceDialog::SmDistanceDialog(Window *pParent, bool bFreeRes)

     aOKButton1     (this, SmResId(1)),

     aCancelButton1 (this, SmResId(1)),

     aMenuButton    (this, SmResId(1)),

+    aHelpButton1   (this, SmResId(1)),

     aDefaultButton (this, SmResId(1)),

     aBitmap        (this, SmResId(1)),

     aFixedLine     (this, SmResId(1))

@@ -951,6 +998,7 @@ SmDistanceDialog::SmDistanceDialog(Window *pParent, bool bFreeRes)

     aMenuButton.GetPopupMenu()->SetSelectHdl(LINK(this, SmDistanceDialog, MenuSelectHdl));

 

     aDefaultButton.SetClickHdl(LINK(this, SmDistanceDialog, DefaultButtonClickHdl));

+    aHelpButton1.SetClickHdl(LINK(this, SmDistanceDialog, HelpButtonClickHdl));

 }

 

 

@@ -1058,6 +1106,17 @@ IMPL_LINK( SmAlignDialog, DefaultButtonClickHdl, Button *, EMPTYARG /*pButton*/

 }

 

 

+IMPL_LINK( SmAlignDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

+{

+    // start help system

+    Help* pHelp = Application::GetHelp();

+    if( pHelp )

+    {

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_ALIGNDIALOG" ) ), &aHelpButton );

+    }

+    return 0;

+}

+

 SmAlignDialog::SmAlignDialog(Window * pParent, bool bFreeRes)

     : ModalDialog(pParent, SmResId(RID_ALIGNDIALOG)),

     aLeft          (this, SmResId(1)),

@@ -1065,6 +1124,7 @@ SmAlignDialog::SmAlignDialog(Window * pParent, bool bFreeRes)

     aRight         (this, SmResId(3)),

     aFixedLine1    (this, SmResId(1)),

     aOKButton1     (this, SmResId(1)),

+    aHelpButton1   (this, SmResId(1)),

     aCancelButton1 (this, SmResId(1)),

     aDefaultButton (this, SmResId(1))

 {

@@ -1072,6 +1132,7 @@ SmAlignDialog::SmAlignDialog(Window * pParent, bool bFreeRes)

         FreeResource();

 

     aDefaultButton.SetClickHdl(LINK(this, SmAlignDialog, DefaultButtonClickHdl));

+    aHelpButton1.SetClickHdl(LINK(this, SmAlignDialog, HelpButtonClickHdl));

 }

 

 

@@ -1491,6 +1552,16 @@ IMPL_LINK_INLINE_START( SmSymbolDialog, CloseClickHdl, Button *, EMPTYARG pButto

 }

 IMPL_LINK_INLINE_END( SmSymbolDialog, CloseClickHdl, Button *, pButton )

 

+IMPL_LINK( SmSymbolDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

+{

+    // start help system

+    Help* pHelp = Application::GetHelp();

+    if( pHelp )

+    {

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_SYMBOLDIALOG" ) ), &aHelpButton );

+    }

+    return 0;

+}

 

 SmSymbolDialog::SmSymbolDialog(Window *pParent, OutputDevice *pFntListDevice,

         SmSymbolManager &rMgr, SmViewShell &rViewShell, bool bFreeRes) :

@@ -1501,6 +1572,7 @@ SmSymbolDialog::SmSymbolDialog(Window *pParent, OutputDevice *pFntListDevice,

     aSymbolName         (this, SmResId(2)),

     aSymbolDisplay      (this, SmResId(2)),

     aGetBtn             (this, SmResId(2)),

+    aHelpBtn            (this, SmResId(1)),

     aCloseBtn           (this, SmResId(3)),

     aEditBtn            (this, SmResId(1)),

     rViewSh             (rViewShell),

@@ -1510,6 +1582,7 @@ SmSymbolDialog::SmSymbolDialog(Window *pParent, OutputDevice *pFntListDevice,

     if (bFreeRes)

         FreeResource();

 

+    aHelpBtn.SetClickHdl(LINK(this, SmSymbolDialog, HelpButtonClickHdl));

     aSymbolSetName = rtl::OUString();

     aSymbolSet.clear();

     FillSymbolSets();

@@ -2016,6 +2089,16 @@ void SmSymDefineDialog::UpdateButtons()

     aDeleteBtn.Enable(bDelete);

 }

 

+IMPL_LINK( SmSymDefineDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

+{

+    // start help system

+    Help* pHelp = Application::GetHelp();

+    if( pHelp )

+    {

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_SYMDEFINEDIALOG" ) ), &aHelpButton );

+    }

+    return 0;

+}

 

 SmSymDefineDialog::SmSymDefineDialog(Window * pParent,

         OutputDevice *pFntListDevice, SmSymbolManager &rMgr, bool bFreeRes) :

@@ -2042,6 +2125,7 @@ SmSymDefineDialog::SmSymDefineDialog(Window * pParent,

     aSymbolDisplay      (this, SmResId(2)),

     aSymbolSetName      (this, SmResId(6)),

     aOkBtn              (this, SmResId(1)),

+    aHelpBtn            (this, SmResId(1)),

     aCancelBtn          (this, SmResId(1)),

     aAddBtn             (this, SmResId(1)),

     aChangeBtn          (this, SmResId(2)),

@@ -2055,6 +2139,8 @@ SmSymDefineDialog::SmSymDefineDialog(Window * pParent,

     if (bFreeRes)

         FreeResource();

 

+    aHelpBtn.SetClickHdl(LINK(this, SmSymDefineDialog, HelpButtonClickHdl));

+

     pFontList = new FontList( pFntListDevice );

 

     pOrigSymbol = 0;

diff --git a/starmath/source/smres.src b/starmath/source/smres.src

index e565bfa..a434306 100644

--- a/starmath/source/smres.src

+++ b/starmath/source/smres.src

@@ -79,6 +79,14 @@ ModalDialog RID_FONTDIALOG

         Size = MAP_APPFONT ( 33 , 10 ) ;

         Text [ en-US ] = "~Italic" ;

     };

+    HelpButton 1

+    {

+        Pos = MAP_APPFONT ( 126 , 42 ) ;

+        Size = MAP_APPFONT ( 50 , 14 ) ;

+        TabStop = TRUE ;

+ HelpID = "starmath:HelpButton:RID_FONTDIALOG:1";

+ Text [ en-US ] = "~Help" ;

+    };

     OKButton 1

     {

         Pos = MAP_APPFONT ( 126 , 6 ) ;

@@ -265,11 +273,19 @@ ModalDialog RID_FONTSIZEDIALOG

         Size = MAP_APPFONT ( 50 , 14 ) ;

         TabStop = TRUE ;

     };

+    HelpButton 1

+    {

+        Pos = MAP_APPFONT ( 114 , 46 ) ;

+        Size = MAP_APPFONT ( 50 , 14 ) ;

+        TabStop = TRUE ;

+ HelpID = "starmath:PushButton:RID_FONTSIZEDIALOG:1";

+ Text [ en-US ] = "~Help" ;

+    };

     PushButton 1

     {

         HelpID = "starmath:PushButton:RID_FONTSIZEDIALOG:1";

         TabStop = TRUE ;

-        Pos = MAP_APPFONT ( 114 , 45 ) ;

+        Pos = MAP_APPFONT ( 114 , 64 ) ;

         Size = MAP_APPFONT ( 50 , 14 ) ;

         Text [ en-US ] = "~Default" ;

     };

@@ -429,11 +445,19 @@ ModalDialog RID_FONTTYPEDIALOG

         Size = MAP_APPFONT ( 50 , 14 ) ;

         Text [ en-US ] = "~Modify" ;

     };

+    HelpButton 1

+    {

+        Pos = MAP_APPFONT ( 225 , 66 ) ;

+        Size = MAP_APPFONT ( 50 , 14 ) ;

+        TabStop = TRUE ;

+ HelpID = "starmath:HelpButton:RID_FONTYPEDIALOG:1";

+ Text [ en-US ] = "~Help" ;

+    };

     PushButton 2

     {

         HelpID = "starmath:PushButton:RID_FONTTYPEDIALOG:2";

         TabStop = TRUE ;

-        Pos = MAP_APPFONT ( 225 , 66 ) ;

+        Pos = MAP_APPFONT ( 225 , 84 ) ;

         Size = MAP_APPFONT ( 50 , 14 ) ;

         Text [ en-US ] = "~Default" ;

     };

@@ -550,6 +574,14 @@ ModalDialog RID_DISTANCEDIALOG

         Size = MAP_APPFONT ( 50 , 14 ) ;

         TabStop = TRUE ;

     };

+    HelpButton 1

+    {

+        Pos = MAP_APPFONT ( 184 , 87 ) ;

+        Size = MAP_APPFONT ( 50 , 14 ) ;

+        TabStop = TRUE ;

+ HelpID = "starmath:HelpButton:RID_DISTANCEDIALOG:1";

+ Text [ en-US ] = "~Help" ;

+    };

     PushButton 1

     {

         HelpID = "starmath:PushButton:RID_DISTANCEDIALOG:1";

@@ -895,11 +927,19 @@ ModalDialog RID_ALIGNDIALOG

         Size = MAP_APPFONT ( 50 , 14 ) ;

         TabStop = TRUE ;

     };

+    HelpButton 1

+    {

+        Pos = MAP_APPFONT ( 83 , 46 ) ;

+        Size = MAP_APPFONT ( 50 , 14 ) ;

+        TabStop = TRUE ;

+ HelpID = "starmath:HelpButton:RID_ALIGNDIALOG:1";

+ Text [ en-US ] = "~Help" ;

+    };

     PushButton 1

     {

         HelpID = "starmath:PushButton:RID_ALIGNDIALOG:1";

         TabStop = TRUE ;

-        Pos = MAP_APPFONT ( 83 , 46 ) ;

+        Pos = MAP_APPFONT ( 83 , 69 ) ;

         Size = MAP_APPFONT ( 50 , 14 ) ;

         Text [ en-US ] = "~Default" ;

     };

@@ -1083,6 +1123,14 @@ ModalDialog RID_SYMBOLDIALOG

         Size = MAP_APPFONT ( 56 , 14 ) ;

         Text [ en-US ] = "~Edit..." ;

     };

+    HelpButton 1

+    {

+        Pos = MAP_APPFONT ( 117 , 60 ) ;

+        Size = MAP_APPFONT ( 50 , 14 ) ;

+        TabStop = TRUE ;

+ HelpID = "starmath:HelpButton:RID_SYMBOLDIALOG:1";

+ Text [ en-US ] = "~Help" ;

+    };

 };

 

 ModalDialog RID_SYMDEFINEDIALOG

@@ -1293,6 +1341,14 @@ ModalDialog RID_SYMDEFINEDIALOG

         Size = MAP_APPFONT ( 50 , 14 ) ;

         Text [ en-US ] = "~Delete" ;

     };

+    HelpButton 1

+    {

+        Pos = MAP_APPFONT ( 310 , 42 ) ;

+        Size = MAP_APPFONT ( 50 , 14 ) ;

+        TabStop = TRUE ;

+ HelpID = "starmath:HelpButton:RID_SYMDEFINEDIALOG:1";

+ Text [ en-US ] = "~Help" ;

+    };

     OKButton 1

     {

         Pos = MAP_APPFONT ( 310 , 6 ) ;

-- 

1.7.5.4





From 9a459f909c82e6eace164dfbe03cd9301a2aaa10 Mon Sep 17 00:00:00 2001

From: Karan Desai <[hidden email]>

Date: Sat, 31 Mar 2012 16:52:44 +0530

Subject: [PATCH 2/2] Whitespace adjusted



---

 starmath/source/dialog.cxx |   25 +++++++++++++------------

 1 files changed, 13 insertions(+), 12 deletions(-)



diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx

index 8c9f72e..6679ae7 100644

--- a/starmath/source/dialog.cxx

+++ b/starmath/source/dialog.cxx

@@ -39,6 +39,7 @@

 #include <svtools/ctrltool.hxx>

 #include <sfx2/printer.hxx>

 #include <vcl/sound.hxx>

+#include <vcl/help.hxx>

 #include <vcl/sndstyle.hxx>

 #include <vcl/waitobj.hxx>

 #include <vcl/settings.hxx>

@@ -333,7 +334,7 @@ IMPL_LINK( SmFontDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

     Help* pHelp = Application::GetHelp();

     if( pHelp )

     {

-        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTDIALOG" ) ), &aHelpButton );

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTDIALOG" ) ), &aHelpButton1 );

     }

     return 0;

 }

@@ -346,14 +347,14 @@ SmFontDialog::SmFontDialog(Window * pParent,

     aBoldCheckBox   (this, SmResId(1)),

     aItalicCheckBox (this, SmResId(2)),

     aOKButton1      (this, SmResId(1)),

-    aHelpButton1    (this, SmResId(1))

+    aHelpButton1    (this, SmResId(1)),

     aCancelButton1  (this, SmResId(1)),

     aShowFont       (this, SmResId(1)),

     aFixedText2     (this, SmResId(2))

 {

     if (bFreeRes)

         FreeResource();

-    aHelpButton1.SetClickHdl(LINK(this, SmFontSDialog, HelpButtonClickHdl));

+    aHelpButton1.SetClickHdl(LINK(this, SmFontDialog, HelpButtonClickHdl));

 

     {

         WaitObject( this );

@@ -456,7 +457,7 @@ IMPL_LINK( SmFontSizeDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/

     Help* pHelp = Application::GetHelp();

     if( pHelp )

     {

-        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTSIZEDIALOG" ) ), &aHelpButton );

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTSIZEDIALOG" ) ), &aHelpButton1 );

     }

     return 0;

 }

@@ -476,8 +477,8 @@ SmFontSizeDialog::SmFontSizeDialog(Window * pParent, bool bFreeRes)

     aFixedText8(this, SmResId(8)),

     aBorderSize(this, SmResId(8)),

     aFixedLine1(this, SmResId(1)),

-    aHelpButton1(this, SmResId(1)),

     aOKButton1(this, SmResId(1)),

+    aHelpButton1(this, SmResId(1)),

     aCancelButton1(this, SmResId(1)),

     aDefaultButton(this, SmResId(1))

 {

@@ -576,7 +577,7 @@ IMPL_LINK( SmFontTypeDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/

     Help* pHelp = Application::GetHelp();

     if( pHelp )

     {

-        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTTYPEDIALOG" ) ), &aHelpButton );

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_FONTTYPEDIALOG" ) ), &aHelpButton1 );

     }

     return 0;

 }

@@ -789,7 +790,7 @@ IMPL_LINK( SmDistanceDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/

     Help* pHelp = Application::GetHelp();

     if( pHelp )

     {

-        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_DISTANCEDIALOG" ) ), &aHelpButton );

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_DISTANCEDIALOG" ) ), &aHelpButton1 );

     }

     return 0;

 }

@@ -971,9 +972,9 @@ SmDistanceDialog::SmDistanceDialog(Window *pParent, bool bFreeRes)

     aFixedText4    (this, SmResId(4)),

     aMetricField4  (this, SmResId(4)),

     aOKButton1     (this, SmResId(1)),

+    aHelpButton1   (this, SmResId(1)),

     aCancelButton1 (this, SmResId(1)),

     aMenuButton    (this, SmResId(1)),

-    aHelpButton1   (this, SmResId(1)),

     aDefaultButton (this, SmResId(1)),

     aBitmap        (this, SmResId(1)),

     aFixedLine     (this, SmResId(1))

@@ -1112,7 +1113,7 @@ IMPL_LINK( SmAlignDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

     Help* pHelp = Application::GetHelp();

     if( pHelp )

     {

-        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_ALIGNDIALOG" ) ), &aHelpButton );

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_ALIGNDIALOG" ) ), &aHelpButton1 );

     }

     return 0;

 }

@@ -1558,7 +1559,7 @@ IMPL_LINK( SmSymbolDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/ )

     Help* pHelp = Application::GetHelp();

     if( pHelp )

     {

-        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_SYMBOLDIALOG" ) ), &aHelpButton );

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_SYMBOLDIALOG" ) ), &aHelpBtn );

     }

     return 0;

 }

@@ -1571,8 +1572,8 @@ SmSymbolDialog::SmSymbolDialog(Window *pParent, OutputDevice *pFntListDevice,

     aSymbolSetDisplay   (this, SmResId(1)),

     aSymbolName         (this, SmResId(2)),

     aSymbolDisplay      (this, SmResId(2)),

-    aGetBtn             (this, SmResId(2)),

     aHelpBtn            (this, SmResId(1)),

+    aGetBtn             (this, SmResId(2)),

     aCloseBtn           (this, SmResId(3)),

     aEditBtn            (this, SmResId(1)),

     rViewSh             (rViewShell),

@@ -2095,7 +2096,7 @@ IMPL_LINK( SmSymDefineDialog, HelpButtonClickHdl, Button *, EMPTYARG /*pButton*/

     Help* pHelp = Application::GetHelp();

     if( pHelp )

     {

-        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_SYMDEFINEDIALOG" ) ), &aHelpButton );

+        pHelp->Start( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "HID_SMA_SYMDEFINEDIALOG" ) ), &aHelpBtn );

     }

     return 0;

 }

-- 

1.7.5.4



===== dictionaries =====

===== help =====

Note that the Help text already exist as indicated in the bug entry. You
need to link the right help page to your patch

Regards
- --
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPdtmfAAoJEJp3R7nH3vLxjXQH/jIAG9E9LIE68fAnYyYkJ25w
WKQzpX752azFpJzblfH1CgyasOJ1MTxUTAigcgC1PoGz/8iapxSpsVd69Ok8dRB7
bf71Ei7cYzAH4Nn77uF/Pn7xuwh/px5q+JsextkG7ZH0DIcewVutijyxtGOAPvOY
W41JYVLERXOFoMdueTF8kbuJ0bJbliQIFc+A0PeierPhkAfJuw8HS0llsoj7Xmx2
DLe0UzyaRULkVEppaVbGN18imU4T4BzjuGfjtJySbCF0g8zPsWYCWhNd0GHhoRGX
2yJr6r5oPO8rL7sYF/3YFkhum+JUGrvxx/5ncKq9Ieejo1ebBD03ksgPQgfgpjU=
=iehz
-----END PGP SIGNATURE-----
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice



If you reply to this email, your message will be added to the discussion below:
http://nabble.documentfoundation.org/GSOC-2012-submitting-a-patch-for-easy-hack-tp3872816p3873143.html
To unsubscribe from GSOC 2012 , submitting a patch for easy hack, click here.
NAML


helpbuttons.patch (32K) Download Attachment
Korrawit Pruegsanusak Korrawit Pruegsanusak
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

Hello there,

On Sat, Mar 31, 2012 at 18:36, kud360 <[hidden email]> wrote:
> I think I got this one right :
> I added help buttons to all the dialog boxes that did not have them , i used
> git format-patch master stdout > helpbuttons.patch
>
> Here are the contents of the file :

I think you've done ./g format-patch, which isn't necessary, because
you've made the changes in core repository only.
And I'm not sure whether we really need 'stdout' in the command.

What I usually use is:
    git format-patch HEAD~1
if you have done only one commit, a file name 0001-xxxx.patch will be
produced the working directory.

Also, you are recommended to do:
    git config --global user.name "your-firstname lastname"
    git config --global user.email "[hidden email]"
to properly have an author information in the commit message.

Next, for submitting a patch, it's better to start an email subject
with [PATCH] to catch an attention. :-)
And if you're fixing a concrete bug, it would be good to mention a bug
number in the commit message subject, in this case fdo#47864.

Lastly, could you please send a blanket email confirming that this and
your future contributions are licensed under MPL / LGPLv3+ ?

Sorry for the long email, I hope you don't get bored yet :-)
And, welcome to LibreOffice! :-)

Best Regards,
--
Korrawit Pruegsanusak
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

In reply to this post by Olivier Hallot
Finally got the patch file :) :) thank you very much everyone :) :)
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

Hi , Mr. Pruegsanusak
I am sorry to bother you but could you please explain me what a blanket email is ? AFAIK its an email to multiple people , but then what should it exactly contain ? As in the License text ? or just me saying its available under the said licenses ?
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

And Mr. Hallot , I have done that. I found the HELP documents refernces , studied some code in the vcl module , and did some changes accordingly in the files , and it was working like a charm. Also , it takes really long time to build on my machine ( like 20 - 30 mins ) on every make dev-install. All modules except the last 2 or 3 are skipped during the build process because there were no changes in them , but the last 2-3 modes seem to take a lot of time .. I have a core i7 processor and run the make with 2 jobs per cpu , using 5 cpus , ( using all 8 , crashes my virtualbox )
Olivier Hallot Olivier Hallot
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello

Em 31-03-2012 12:44, kud360 escreveu:
> And Mr. Hallot , I have done that. I found the HELP documents refernces ,
> studied some code in the vcl module , and did some changes accordingly in
> the files , and it was working like a charm.

That is exactly what it was to be done. Great you made it. I am building
master ATM to test your patch.

Also , it takes really long
> time to build on my machine ( like 20 - 30 mins ) on every make dev-install.

you should only run a full build and then

make starmath

to test your changes in starmath module. That should not take more than
30s to get it built.


> All modules except the last 2 or 3 are skipped during the build process
> because there were no changes in them , but the last 2-3 modes seem to take
> a lot of time .. I have a core i7 processor and run the make with 2 jobs per
> cpu , using 5 cpus , ( using all 8 , crashes my virtualbox )

A muscled machine that should do it way faster with the proper commands.

About the blanket mail, here is what you must do:

send a mail to *this* list with

subject: License statement
Body:

"All my contributions, past and future, to LibreOffice are licensed
under the terms of the MPL / LGPLv3+. "

your name and e-mail

Once we get this mail, then we can apply your patch to the master branch.


Congratulations and welcome do LibreOffice development.
- --
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPdymUAAoJEJp3R7nH3vLxFTUH/1yqZOZVWt3ovJ62ut2NGKXo
d3dEOKNrNkMeoxFmSsU8cRyXExfikWaY5wzgek9g7lM1x8t3Zp0LP3sNqRj6BVLu
McnLfdrxinFek+TzRQh/QVbCFrNcKMky5o9tMyp6pAXZfvdwP4lOEAgNrPKr12a6
VFtcVyWMObb1RZSK+F2LW9SgBQT4frLg6njbr+KvNatA45nzWc63A4+6Zxp2/Hlg
mQImh7/Yy+/fuAbAi+LgAXfy0QVmHxv4XxaD4GmU0XjbGb87Nu8pWJr9mA8QskfG
Y1FfXzdCrXX2Y2ZtuBOfIG9hpHMg17EhPn0yfBU9HYV4mXMnt6cG5rCwG3Ru8M4=
=uZYt
-----END PGP SIGNATURE-----
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jonathan Aquilina Jonathan Aquilina
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

In reply to this post by kud360
On 31/03/2012 17:37, kud360 wrote:
> Hi , Mr. Pruegsanusak
> I am sorry to bother you but could you please explain me what a blanket
> email is ? AFAIK its an email to multiple people , but then what should it
> exactly contain ? As in the License text ? or just me saying its available
> under the said licenses ?
>
It just has to be an email to this list saying that all past present and
future contributions are licensed in accordance with the licenses used
by this project.

> --
> View this message in context: http://nabble.documentfoundation.org/GSOC-2012-submitting-a-patch-for-easy-hack-tp3872816p3873622.html
> Sent from the Dev mailing list archive at Nabble.com.
> _______________________________________________
> LibreOffice mailing list
> [hidden email]
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

License statement

In reply to this post by kud360
"All my contributions, past and future, to LibreOffice are licensed
under the terms of the MPL / LGPLv3+. "

Karan Desai,
kud360@gmail. com
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

In reply to this post by Olivier Hallot
Done .. also I had made a new topic in the Dev section marked with [PATCH] as suggested
Olivier Hallot Olivier Hallot
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Karam

Em 31-03-2012 13:29, kud360 escreveu:
> Done .. also I had made a new topic in the Dev section marked with [PATCH] as
> suggested
>

Please correct the font spacing dialog as shown in this image, where the
help button does not fit inside the dialog box. You must increase the
dialog height, and possibly balance the leftmost text to avoid a large
blank space below it.

And resubmit your patch in this list (not in nabble).

Thank you

- --
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPd5WEAAoJEJp3R7nH3vLxrT4H/2Np2UUvCgB/U10bnf8wFBSl
qqa9VD8QEhn7DeC4M6ffQy9Q9Rw74OkqeNCgZvdSkB1q8FkqF14bE1lbQIcse8r/
gJ30Tw5H/i0B637uKqamJ70E2Cz19oeLLJAGTR0fo8ST8Uakb4vZx2qfs0WOd44a
FfmeJCMQXeow1d7looy0331A9A+Rih87+HyQUxMM6O715BUjqynFFAY3MPfNCtiX
SFPpyuUi7O9wwgNVCTReRbKemaTA4A4GVjMNJilzHPXqtIUKV8vZrEmRUupKVcum
PsJTmkfEIKfM9jLlR0FTFc98qLo2EVibcVwOSPribQIrB5KPZHZAVCV36Vbewgg=
=Vc+H
-----END PGP SIGNATURE-----

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

imagem19.png (22K) Download Attachment
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack



On Sun, Apr 1, 2012 at 5:09 AM, Olivier Hallot [via Document Foundation Mail Archive] <[hidden email]> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Karam

Em 31-03-2012 13:29, kud360 escreveu:
> Done .. also I had made a new topic in the Dev section marked with [PATCH] as
> suggested
>

Please correct the font spacing dialog as shown in this image, where the
help button does not fit inside the dialog box. You must increase the
dialog height, and possibly balance the leftmost text to avoid a large
blank space below it.

And resubmit your patch in this list (not in nabble).

Thank you

- --
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPd5WEAAoJEJp3R7nH3vLxrT4H/2Np2UUvCgB/U10bnf8wFBSl
qqa9VD8QEhn7DeC4M6ffQy9Q9Rw74OkqeNCgZvdSkB1q8FkqF14bE1lbQIcse8r/
gJ30Tw5H/i0B637uKqamJ70E2Cz19oeLLJAGTR0fo8ST8Uakb4vZx2qfs0WOd44a
FfmeJCMQXeow1d7looy0331A9A+Rih87+HyQUxMM6O715BUjqynFFAY3MPfNCtiX
SFPpyuUi7O9wwgNVCTReRbKemaTA4A4GVjMNJilzHPXqtIUKV8vZrEmRUupKVcum
PsJTmkfEIKfM9jLlR0FTFc98qLo2EVibcVwOSPribQIrB5KPZHZAVCV36Vbewgg=
=Vc+H
-----END PGP SIGNATURE-----

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

imagem19.png (22K) Download Attachment



If you reply to this email, your message will be added to the discussion below:
http://nabble.documentfoundation.org/GSOC-2012-submitting-a-patch-for-easy-hack-tp3872816p3874382.html
To unsubscribe from GSOC 2012 , submitting a patch for easy hack, click here.
NAML


0001-Added-Help-Buttons-to-dialog-buttons-in-starmath.patch (24K) Download Attachment
Olivier Hallot Olivier Hallot
Reply | Threaded
Open this post in threaded view
|

[PUSHED] Re: GSOC 2012 , submitting a patch for easy hack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

comitted .

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2786b3878c391d8b7f4b53b40f30453dbbffbd9

Regards

Em 01-04-2012 03:25, kud360 escreveu:

>
>
> On Sun, Apr 1, 2012 at 5:09 AM, Olivier Hallot [via Document Foundation
> Mail Archive] <[hidden email]
> </user/SendEmail.jtp?type=node&node=3874803&i=0>> wrote:
>
> Hi Karam
>
> Em 31-03-2012 13:29, kud360 escreveu:
>> Done .. also I had made a new topic in the Dev section marked with
> [PATCH] as
>> suggested
>
>
> Please correct the font spacing dialog as shown in this image, where
> the
> help button does not fit inside the dialog box. You must increase the
> dialog height, and possibly balance the leftmost text to avoid a large
> blank space below it.
>
> And resubmit your patch in this list (not in nabble).
>
> Thank you
>
>
>     _______________________________________________
>     LibreOffice mailing list
>     [hidden email] <http://user/SendEmail.jtp?type=node&node=3874382&i=0>
>     http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>     *imagem19.png* (22K) Download Attachment
>     <http://attachment/3874382/0/imagem19.png>
>
>
>     ------------------------------------------------------------------------
>     If you reply to this email, your message will be added to the
>     discussion below:
>     http://nabble.documentfoundation.org/GSOC-2012-submitting-a-patch-for-easy-hack-tp3872816p3874382.html
>
>     To unsubscribe from GSOC 2012 , submitting a patch for easy hack,
>     click here.
>     NAML
>     <http://nabble.documentfoundation.org/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
>
>
>
> *0001-Added-Help-Buttons-to-dialog-buttons-in-starmath.patch* (24K)
> Download Attachment
> </attachment/3874803/0/0001-Added-Help-Buttons-to-dialog-buttons-in-starmath.patch>
>
> ------------------------------------------------------------------------
> View this message in context: Re: GSOC 2012 , submitting a patch for
> easy hack
> <http://nabble.documentfoundation.org/GSOC-2012-submitting-a-patch-for-easy-hack-tp3872816p3874803.html>
> Sent from the Dev mailing list archive
> <http://nabble.documentfoundation.org/Dev-f1639786.html> at Nabble.com.
>
>
> _______________________________________________
> LibreOffice mailing list
> [hidden email]
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

- --
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPeY4mAAoJEJp3R7nH3vLxGCIIALh9ZV2eYm38upYobWvOdr0q
2HjGtAr1ThK9scaAXUR8LLB7Cr6aCYmkhwiOubihzdr4qPJVo0xuGEVLksd/KPTy
RbcXl2oCs1YEqZ9ObRiCs375p9RNRPM9VwCcESCoZJMgGpI258yqlwX654tqwSEW
1td2dZnoSbpicr7OTjh7tM7wNN/YKnerfSc0pIciI4J1NYgKy6WhT+M+sas3AFte
n1DY85SMXxu5Oh4Qf1o5Y4zGa/zrQEGXXJLaeId5MKzN237dzWMLT1FhwcqGpK7C
luV7LfFq8quv16yRM1chGEvdL8y84paAG7aiI39iIbGqXN2G8a1Qav01fmgGmRw=
=koPr
-----END PGP SIGNATURE-----
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
kud360 kud360
Reply | Threaded
Open this post in threaded view
|

Re: GSOC 2012 , submitting a patch for easy hack

In reply to this post by kud360
Thanks a lot :) :) .... My first contribution :) Yeay ! ...

I would now like to know about my project specification ..... I had written a mail about this to Mr. Thorsten Behrens about this , but I received no reply .. can someone please tell me a way to contact him ... I have some ideas with me that i am presently working on...

A slide changing app is ready with me that I made in java by emulating keystrokes and hence using the generated arrow keystrokes ... I wanted to know if libreoffice listens in on any-port .. if not I was wondering of how hard would it be to start a daemon as a part of libreoffice to listen in on network ports.