Image Compression Patch

classic Classic list List threaded Threaded
19 messages Options
Pat Hawks Pat Hawks
Reply | Threaded
Open this post in threaded view
|

Image Compression Patch

I've applied some lossless compression to the PNGs in the package to reduce the size of the files a bit, some by as much as 50%

In the grand scheme of things I know it's not life or death, but every little bit helps, right?

This is contributed under the LGPLv3+

~Patrick Hawks

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

image.patch (23K) Download Attachment
Michael Meeks Michael Meeks
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

Hi Pat,

On Mon, 2010-10-11 at 10:20 -0500, Pat Hawks wrote:
> I've applied some lossless compression to the PNGs in the package to
> reduce the size of the files a bit, some by as much as 50%

        Worth doing :-)

> In the grand scheme of things I know it's not life or death, but every
> little bit helps, right?

        Certainly ! where the images are concerned, the biggest space win we
can get is to get rid of all the high-contrast icons (into their own
theme). This is an 'easy hack'[1] - should be a fairly simple
re-factoring job: ripping out all that cruft that was cluelessly added
to cope with only a single disability (and ignoring eg. low-contrast
users).

        So - currently, we have bogus duplicates of ~all icons in the
theme .zip files ;-)

> This is contributed under the LGPLv3+

        The diff didn't contain the data ;-) [ which is prolly quite large ].
It is perhaps better to share the script you're using, and a list of
high-win files we can use - would that make sense ?

        Anyhow - thanks for getting involved - and look forward to your
script :-)

        HTH,

                Michael.


[1] - http://www.freedesktop.org/wiki/Software/LibreOffice/EasyHacks?action=show&redirect=Software%2Flibreoffice%2FEasyHacks#un-screw-upaccessibleiconcode-paths.26shrinkthemefiles
--
 [hidden email]  <><, Pseudo Engineer, itinerant idiot


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Rene Engelhard Rene Engelhard
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

In reply to this post by Pat Hawks
Hi,

On Mon, Oct 11, 2010 at 10:20:31AM -0500, Pat Hawks wrote:
>    I've applied some lossless compression to the PNGs in the package to
>    reduce the size of the files a bit, some by as much as 50%

What is the command line?

>    This�is contributed under the LGPLv3+

Patch doesn't work for binary files, it just says they differ, nothing more :-)

Grüße/Regards,

René

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan Holesovsky Jan Holesovsky
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

In reply to this post by Pat Hawks
Hi Pat,

On 2010-10-11 at 10:20 -0500, Pat Hawks wrote:

> I've applied some lossless compression to the PNGs in the package to
> reduce the size of the files a bit, some by as much as 50%
>
> In the grand scheme of things I know it's not life or death, but every
> little bit helps, right?
>
> This is contributed under the LGPLv3+

When you send your script you used for the better compression of the
icons, please CC: Andrew too - he has previously done lots of good work
on recompressing the images, and has just recently got in touch with us
again.  Would be great if you both can share experience :-)

Thank you a lot,
Kendy


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrew C. E. Dent Andrew C. E. Dent
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

Hi Pat

I'd really like to collaborate with you on optimizing the icon /artwork.
I'm the author of 'pngslim', and have a few custom scripts for icons...

Perhaps we could have a chat on IRC, to see how best to work together?

Beyond lossless optimization of the icons, there are bigger tasks I want to tackle. These include:
- Agreeing standard icon theme naming and reducing duplicate icons (see an old audit I started: http://people.bath.ac.uk/ea2aced/OOo/OOoIconCat.odt )
- Looking at whole packaging concept, so we only ship one core theme and other themes are available as extensions.
- Usage profiling for quicker startup times.
- Hacking the code to treat HC as a  separate theme (big wins to be had there!).
- List of other tasks here: https://spreadsheets.google.com/ccc?key=0AktmVHYOt-kzcmpnbFE0Rmx2c1lLVTVwaUtDR2t3S0E&hl=en_GB

Look forward to working with you and hope we can chat soon.

Cheers,
Andrew




> Subject: Re: [Libreoffice] Image Compression Patch
> From: [hidden email]
> To: [hidden email]; [hidden email]
> CC: [hidden email]
> Date: Tue, 12 Oct 2010 14:30:38 +0200
>
> Hi Pat,
>
> On 2010-10-11 at 10:20 -0500, Pat Hawks wrote:
>
> > I've applied some lossless compression to the PNGs in the package to
> > reduce the size of the files a bit, some by as much as 50%
> >
> > In the grand scheme of things I know it's not life or death, but every
> > little bit helps, right?
> >
> > This is contributed under the LGPLv3+
>
> When you send your script you used for the better compression of the
> icons, please CC: Andrew too - he has previously done lots of good work
> on recompressing the images, and has just recently got in touch with us
> again. Would be great if you both can share experience :-)
>
> Thank you a lot,
> Kendy
>
>

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrew C. E. Dent Andrew C. E. Dent
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

In reply to this post by Jan Holesovsky
Hi Kendy

I've finished the process of lossless optimization for the default_images pack.
The archive is available here:
http://people.bath.ac.uk/ea2aced/OOo/default_images.zip

I also raised a corresponding issue over at OOo to give them a chance to get this upstream if they wish...

I'd be most grateful if you could get this checked in to the repository. Cheers.
I haven't yet compress the new 'brand' image folder- but I know these are a work in progress any way.

Many thanks,
Andrew



> Subject: Re: [Libreoffice] Image Compression Patch
> From: [hidden email]
> To: [hidden email]; [hidden email]
> CC: [hidden email]
> Date: Tue, 12 Oct 2010 14:30:38 +0200
>
> Hi Pat,
>
> On 2010-10-11 at 10:20 -0500, Pat Hawks wrote:
>
> > I've applied some lossless compression to the PNGs in the package to
> > reduce the size of the files a bit, some by as much as 50%
> >
> > In the grand scheme of things I know it's not life or death, but every
> > little bit helps, right?
> >
> > This is contributed under the LGPLv3+
>
> When you send your script you used for the better compression of the
> icons, please CC: Andrew too - he has previously done lots of good work
> on recompressing the images, and has just recently got in touch with us
> again. Would be great if you both can share experience :-)
>
> Thank you a lot,
> Kendy
>
>

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

On Fri, 2010-10-22 at 11:47 +0100, Andrew C. E. Dent wrote:
> Hi Kendy
>
>
> I've finished the process of lossless optimization for the
> default_images pack.

What is the process btw, are you using some command line tools to do it
which could be scripted. Or opening them up manually in a graphics app.

C.


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan Holesovsky Jan Holesovsky
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

In reply to this post by Andrew C. E. Dent
Hi Andrew,

On 2010-10-22 at 11:47 +0100, Andrew C. E. Dent wrote:

> I've finished the process of lossless optimization for the
> default_images pack.
> The archive is available here:
> http://people.bath.ac.uk/ea2aced/OOo/default_images.zip

$ du -hs --apparent-size default_images.save/
6,3M default_images.save/
$ du -hs --apparent-size default_images
4,8M default_images

Nice! :-)  Thank you a lot!

To check that everything is still the same, I created a script that
checks 2 directories (original icons, and the optimized ones), converts
the png's to xpm's and checks them for differences:

http://cgit.freedesktop.org/libreoffice/build/tree/bin/check-artwork.sh

Unfortunately, some of the icons differed - please see the attached
list; I did not commit/push those, only the ones that were the same.

Can you please check what was wrong?  I eg. see that
svx/res/lightfromleft_22.png has originally a transparent background,
but the optimized version has gray background.

> I'd be most grateful if you could get this checked in to the
> repository.

Done :-) - with the exception of the attached list.

Thank you a lot,
Kendy


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

not-matching-icons.txt.bz2 (3K) Download Attachment
Andrew C. E. Dent Andrew C. E. Dent
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

Thanks Kendy.

Where pixels are fully transparent, sometimes the colour data is stripped to improve compression.
Although technically lossy, this is never seen by the end-user. It may have confused your comparison script?
Some icons are genuinely altered- placeholders (green X on blue background) are swapped for blank images, etc.

I will manually check the icons listed over the next couple of days.

I would like to look at the 'Oxygen' icon pack next... 

Many thanks,
Andrew.


 

> Subject: RE: [Libreoffice] Image Compression Patch
> From: [hidden email]
> To: [hidden email]
> CC: [hidden email]; [hidden email]
> Date: Sun, 24 Oct 2010 22:07:32 +0200
>
> Hi Andrew,
>
> On 2010-10-22 at 11:47 +0100, Andrew C. E. Dent wrote:
>
> > I've finished the process of lossless optimization for the
> > default_images pack.
> > The archive is available here:
> > http://people.bath.ac.uk/ea2aced/OOo/default_images.zip
>
> $ du -hs --apparent-size default_images.save/
> 6,3M default_images.save/
> $ du -hs --apparent-size default_images
> 4,8M default_images
>
> Nice! :-) Thank you a lot!
>
> To check that everything is still the same, I created a script that
> checks 2 directories (original icons, and the optimized ones), converts
> the png's to xpm's and checks them for differences:
>
> http://cgit.freedesktop.org/libreoffice/build/tree/bin/check-artwork.sh
>
> Unfortunately, some of the icons differed - please see the attached
> list; I did not commit/push those, only the ones that were the same.
>
> Can you please check what was wrong? I eg. see that
> svx/res/lightfromleft_22.png has originally a transparent background,
> but the optimized version has gray background.
>
> > I'd be most grateful if you could get this checked in to the
> > repository.
>
> Done :-) - with the exception of the attached list.
>
> Thank you a lot,
> Kendy
>

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrew C. E. Dent Andrew C. E. Dent
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

In reply to this post by Jan Holesovsky

Hi Kendy.

Thanks again for checking into this. I've done more testing and I think the problem is with your image decoder (ImageMagick). The problem icons are encoded as RGB + Simple 1 'colour' transparency. It may be a bit unusual, but is supported by the PNG spec and works with LibO's png decoder fine. It seems one of the 'Fathers' of the png format- Glenn Randers-Pehrson - contributes to ImageMagick. If it hasn't been patched already, I'm sure they'd value a bug report.

I have checked the optimized icons several ways and as much as possible, but ultimately it is only through use we can catch any small oddities. I suggest we push the new icons upstream and await user feedback.

Many thanks,
Andrew



> Subject: RE: [Libreoffice] Image Compression Patch
> From: [hidden email]
> To: [hidden email]
> CC: [hidden email]; [hidden email]
> Date: Sun, 24 Oct 2010 22:07:32 +0200
>
> Hi Andrew,
>
> On 2010-10-22 at 11:47 +0100, Andrew C. E. Dent wrote:
>
> > I've finished the process of lossless optimization for the
> > default_images pack.
> > The archive is available here:
> > http://people.bath.ac.uk/ea2aced/OOo/default_images.zip
>
> $ du -hs --apparent-size default_images.save/
> 6,3M default_images.save/
> $ du -hs --apparent-size default_images
> 4,8M default_images
>
> Nice! :-) Thank you a lot!
>
> To check that everything is still the same, I created a script that
> checks 2 directories (original icons, and the optimized ones), converts
> the png's to xpm's and checks them for differences:
>
> http://cgit.freedesktop.org/libreoffice/build/tree/bin/check-artwork.sh
>
> Unfortunately, some of the icons differed - please see the attached
> list; I did not commit/push those, only the ones that were the same.
>
> Can you please check what was wrong? I eg. see that
> svx/res/lightfromleft_22.png has originally a transparent background,
> but the optimized version has gray background.
>
> > I'd be most grateful if you could get this checked in to the
> > repository.
>
> Done :-) - with the exception of the attached list.
>
> Thank you a lot,
> Kendy
>

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan Holesovsky Jan Holesovsky
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

Hi Andrew,

On 2010-10-26 at 06:40 +0100, Andrew C. E. Dent wrote:

> I have checked the optimized icons several ways and as much as
> possible, but ultimately it is only through use we can catch any small
> oddities. I suggest we push the new icons upstream and await user
> feedback.

I have pushed more of the icons (I've checked that they render fine in
Firefox), but still there are few left.  Can you please check all the
icons of size '67' - they seem to be broken, just one pixel there.  To
be concrete:

default_images/fpicker/res/list.png
default_images/res/basgocl.png
default_images/res/lxh03124.png
default_images/res/lxh03134.png
default_images/res/lxh03142.png
default_images/res/lxh03145.png
default_images/res/lxh03159.png
default_images/res/lxh03168.png
default_images/res/lxh03187.png
default_images/res/lxh03190.png
default_images/res/lxh03193.png
default_images/res/lxh03198.png
default_images/res/lxh03201.png
default_images/res/lxh03202.png
default_images/res/lxh03203.png
default_images/res/lxh03204.png
default_images/res/lxh03205.png
default_images/res/lxh03206.png
default_images/res/lxh03236.png
default_images/res/lxh03237.png
default_images/res/lx03124.png
default_images/res/lx03134.png
default_images/res/lx03142.png
default_images/res/lx03159.png
default_images/res/lx03168.png
default_images/res/lx03187.png
default_images/res/lx03190.png
default_images/res/lx03193.png
default_images/res/lx03198.png
default_images/res/lx03201.png
default_images/res/lx03202.png
default_images/res/lx03203.png
default_images/res/lx03204.png
default_images/res/lx03205.png
default_images/res/lx03206.png
default_images/res/lx03236.png
default_images/res/lx03237.png
default_images/res/sxh03124.png
default_images/res/sxh03134.png
default_images/res/sxh03142.png
default_images/res/sxh03145.png
default_images/res/sxh03159.png
default_images/res/sxh03168.png
default_images/dbaccess/res/sxh03187.png
default_images/res/sxh03187.png
default_images/res/sxh03198.png
default_images/res/sxh03203.png
default_images/res/sxh03204.png
default_images/res/sxh03205.png
default_images/res/sxh03206.png
default_images/res/sxh03236.png
default_images/res/sxh03237.png
default_images/res/sxh10602.png
default_images/res/sx03124.png
default_images/res/sx03134.png
default_images/res/sx03142.png
default_images/res/sx03159.png
default_images/res/sx03168.png
default_images/res/sx03198.png
default_images/res/sx03203.png
default_images/res/sx03204.png
default_images/res/sx03205.png
default_images/res/sx03206.png
default_images/res/sx03236.png
default_images/res/sx03237.png
default_images/res/sx10602.png
default_images/res/commandimagelist/lc_addbookmark.png
default_images/res/commandimagelist/lc_beamer.png
default_images/res/commandimagelist/lc_countall.png
default_images/res/commandimagelist/lc_editframeset.png
default_images/res/commandimagelist/lc_filedocument.png
default_images/res/commandimagelist/lc_getactivetask.png
default_images/res/commandimagelist/lc_helpdownload.png
default_images/res/commandimagelist/lc_internetonline.png
default_images/res/commandimagelist/lc_macrorecordingfloat.png
default_images/res/commandimagelist/lc_mailwindow.png
default_images/res/commandimagelist/lc_playmacro.png
default_images/res/commandimagelist/lc_preview.png
default_images/res/commandimagelist/lc_splithorizontal.png
default_images/res/commandimagelist/lc_splitparenthorizontal.png
default_images/res/commandimagelist/lc_splitparentvertical.png
default_images/res/commandimagelist/lc_splitvertical.png
default_images/res/commandimagelist/lc_styleupdatebyexample.png
default_images/res/commandimagelist/lc_toolsmacroedit.png
default_images/res/commandimagelist/lc_toolsoptions.png
default_images/res/commandimagelist/lc_urlbutton.png
default_images/res/commandimagelist/lch_addbookmark.png
default_images/res/commandimagelist/lch_beamer.png
default_images/res/commandimagelist/lch_countall.png
default_images/res/commandimagelist/lch_editframeset.png
default_images/res/commandimagelist/lch_filedocument.png
default_images/res/commandimagelist/lch_getactivetask.png
default_images/res/commandimagelist/lch_helpdownload.png
default_images/res/commandimagelist/lch_internetonline.png
default_images/res/commandimagelist/lch_macrorecordingfloat.png
default_images/res/commandimagelist/lch_mailwindow.png
default_images/res/commandimagelist/lch_playmacro.png
default_images/res/commandimagelist/lch_splithorizontal.png
default_images/res/commandimagelist/lch_splitparenthorizontal.png
default_images/res/commandimagelist/lch_splitparentvertical.png
default_images/res/commandimagelist/lch_splitvertical.png
default_images/res/commandimagelist/lch_styleupdatebyexample.png
default_images/res/commandimagelist/lch_toolsmacroedit.png
default_images/res/commandimagelist/lch_toolsoptions.png
default_images/res/commandimagelist/lch_urlbutton.png
default_images/res/commandimagelist/sc_addbookmark.png
default_images/res/commandimagelist/sc_beamer.png
default_images/res/commandimagelist/sc_countall.png
default_images/res/commandimagelist/sc_editframeset.png
default_images/res/commandimagelist/sc_filedocument.png
default_images/res/commandimagelist/sc_getactivetask.png
default_images/res/commandimagelist/sc_helpdownload.png
default_images/res/commandimagelist/sc_internetonline.png
default_images/res/commandimagelist/sc_macrorecordingfloat.png
default_images/res/commandimagelist/sc_mailwindow.png
default_images/res/commandimagelist/sc_playmacro.png
default_images/res/commandimagelist/sc_preview.png
default_images/res/commandimagelist/sc_splithorizontal.png
default_images/res/commandimagelist/sc_splitparenthorizontal.png
default_images/res/commandimagelist/sc_splitparentvertical.png
default_images/res/commandimagelist/sc_splitvertical.png
default_images/res/commandimagelist/sc_toolsmacroedit.png
default_images/res/commandimagelist/sc_toolsoptions.png
default_images/res/commandimagelist/sc_urlbutton.png
default_images/res/commandimagelist/sch_addbookmark.png
default_images/res/commandimagelist/sch_beamer.png
default_images/res/commandimagelist/sch_countall.png
default_images/res/commandimagelist/sch_editframeset.png
default_images/res/commandimagelist/sch_filedocument.png
default_images/res/commandimagelist/sch_getactivetask.png
default_images/res/commandimagelist/sch_helpdownload.png
default_images/res/commandimagelist/sch_internetonline.png
default_images/res/commandimagelist/sch_macrorecordingfloat.png
default_images/res/commandimagelist/sch_mailwindow.png
default_images/res/commandimagelist/sch_playmacro.png
default_images/res/commandimagelist/sch_splitparentvertical.png
default_images/res/commandimagelist/sch_splitvertical.png
default_images/res/commandimagelist/sch_toolsmacroedit.png
default_images/res/commandimagelist/sch_toolsoptions.png
default_images/res/commandimagelist/sch_urlbutton.png
default_images/sw/res/anchor.png
default_images/sw/res/danchor.png
default_images/sw/res/x.png

Or are they totally unused, and in fact should be removed from the
repos?

Thank you,
Kendy


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrew C. E. Dent Andrew C. E. Dent
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

Hi Kendy

Thanks again for checking so deeply.
Sorry, I should have been clearer on these images...
These are the green (/red) crosses that have long existed as icon placeholders.
For some time in the 'Classic' theme I have used a minimal png file (67bytes - 1pixel) to replace them.
They probably are redundant, but I haven't looked at the code to test this- so it may be best to go with this hack for a quick fix...

I have checked each file listed, and found the following bugs (sorry!) - 
default_images/dbaccess/res/sxh03187.png - should *not* be blank, but I don't think it's used anyway.
default_images/res/sc06356.png - This should have been made blank, but I missed it.

I have made a patch with just these two icons updated here:
http://people.bath.ac.uk/ea2aced/OOo/images-PATCH1.zip


Many thanks,
Andrew




> Subject: RE: [Libreoffice] Image Compression Patch
> From: [hidden email]
> To: [hidden email]
> CC: [hidden email]
> Date: Tue, 26 Oct 2010 18:35:45 +0200
>
> Hi Andrew,
>
> On 2010-10-26 at 06:40 +0100, Andrew C. E. Dent wrote:
>
> > I have checked the optimized icons several ways and as much as
> > possible, but ultimately it is only through use we can catch any small
> > oddities. I suggest we push the new icons upstream and await user
> > feedback.
>
> I have pushed more of the icons (I've checked that they render fine in
> Firefox), but still there are few left. Can you please check all the
> icons of size '67' - they seem to be broken, just one pixel there. To
> be concrete:
>
> default_images/fpicker/res/list.png
...
>
> Or are they totally unused, and in fact should be removed from the
> repos?
>
> Thank you,
> Kendy
>
>

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks Michael Meeks
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

Hi Andrew,

On Tue, 2010-10-26 at 22:49 +0100, Andrew C. E. Dent wrote:
> Thanks again for checking so deeply.
> Sorry, I should have been clearer on these images...
> These are the green (/red) crosses that have long existed as icon
> placeholders.

        Ah ! ;-) out of interest, how many of these do we have still ?

        IMHO it is a nonsense to distribute them. I would prefer to have a
single "missing icon" icon, and a fallback path in the image loader
(vcl/source/gdi/impimage*) that would load those icons when the target
is missing (and preferably log to the console ;-).

        If there are still a significant number of non-icon icons ;-) then it
would be great to add that as an easy-hack in the wiki (if you could?).

> They probably are redundant, but I haven't looked at the code to test
> this- so it may be best to go with this hack for a quick fix...

        I think the idea was to have something visually easily identifyable to
see the missing icons. But of course, the idea of zipping dozens of the
same non-image indefinitely is really silly ;-)

        Thanks,

                Michael.

--
 [hidden email]  <><, Pseudo Engineer, itinerant idiot


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrew C. E. Dent Andrew C. E. Dent
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch


Hi Michael

> Ah ! ;-) out of interest, how many of these do we have still ?

From a quick count, only ~150 or so... (!)

> IMHO it is a nonsense to distribute them. I would prefer to have a
> single "missing icon" icon, and a fallback path in the image loader
> (vcl/source/gdi/impimage*) that would load those icons when the target
> is missing (and preferably log to the console ;-).

Sounds like an excellent plan. A few years back I started the task of stripping out HC icons, but this
sometimes caused crashes as the fall back mechanism (currently just leaves a blank), doesn't always work... 

This is a code task that I don't currently have time for, but would make a good Easy Hack wiki addition.

Cheers,
Andrew

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks Michael Meeks
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

Hi Andrew,

On Wed, 2010-10-27 at 12:08 +0100, Andrew C. E. Dent wrote:
> > Ah ! ;-) out of interest, how many of these do we have still ?
>
> From a quick count, only ~150 or so... (!)

        Nice - only 150 duplicated icons. I've added an easy hack for this, we
should fix in the code first [ it should be easy ].

http://wiki.documentfoundation.org/Development/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_icons

> Sounds like an excellent plan. A few years back I started the task of
> stripping out HC icons, but this sometimes caused crashes as the fall
> back mechanism (currently just leaves a blank), doesn't always
> work...

        Right - if we can provide some more details to motivate people in that
task into the other icon task after that; "un-screw-up accessible
icon..." that might motivate people to look at that.

        It badly needs doing, and we can save a chunk of memory, download
bandwidth etc. etc. doing that - we currently duplicate the HC icons in
every theme (I think) ;-)

> This is a code task that I don't currently have time for, but would
> make a good Easy Hack wiki addition.

        Be great to get some numbers into there - eg. the difference in
images.zip file size with and without the hc icons.

        Thanks !

                Michael.


--
 [hidden email]  <><, Pseudo Engineer, itinerant idiot


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrew C. E. Dent Andrew C. E. Dent
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

In reply to this post by Michael Meeks

Hi Michael and Kendy,

Thanks for adding the Easy Hack to the wiki. In conclusion, I think it's still worth committing the minimal png files, as it reduces their overhead immediately and makes it easy to find them (only 67byte icon), when someone does come to hack the code.

Cheers,
Andrew

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrew C. E. Dent Andrew C. E. Dent
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

In reply to this post by Michael Meeks

Cheers Michael.

Sounds like a good plan of attack. I've added some stats to the wiki based on an analysis I did a while ago.
There's some other possible hacks in the analysis here:

https://spreadsheets.google.com/ccc?key=0AktmVHYOt-kzcmpnbFE0Rmx2c1lLVTVwaUtDR2t3S0E&hl=en_GB

Many thanks,
Andrew 

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks Michael Meeks
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch


On Wed, 2010-10-27 at 20:15 +0100, Andrew C. E. Dent wrote:
> Sounds like a good plan of attack. I've added some stats to the wiki
> based on an analysis I did a while ago.

        Nice.

> There's some other possible hacks in the analysis here:
> https://spreadsheets.google.com/ccc?key=0AktmVHYOt-kzcmpnbFE0Rmx2c1lLVTVwaUtDR2t3S0E&hl=en_GB

        Great; I added a link to that to the easy hacks wiki under the icon
tasks item as well.

        Thanks !

                Michael.

--
 [hidden email]  <><, Pseudo Engineer, itinerant idiot


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Thorsten Behrens Thorsten Behrens
Reply | Threaded
Open this post in threaded view
|

Re: Image Compression Patch

In reply to this post by Andrew C. E. Dent
Hi Andrew,

sorry, a few of those nasty odf-branded icons slipped past me, had
to revert a bunch of your optimized icons in default_images - do we
have a script / documentation somewhere, so this can be
re-optimized?

Cheers,

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment