LATE FEATURE: Personas in LibreOffice

classic Classic list List threaded Threaded
28 messages Options
Next » 12
Jan Holesovsky Jan Holesovsky
Reply | Threaded
Open this post in threaded view
|

LATE FEATURE: Personas in LibreOffice

Hi Astron, Caolán, Olivier, all,

I'd like to ask you [or any additional reviewers :-)] for review of a
late 4.0 feature - the Firefox Personas for LibreOffice.  It is supposed
to work like this:

- the user chooses Tools -> Options -> Personalization -> Select Persona
- then navigates to http://www.getpersonas.com, and chooses Persona she
  likes
- copies the URL of that Persona to clipboard, pastes that to the
  dialog, [OK]
- closes the Options with [OK]

And the the Persona is used in LibreOffice, like this:

http://artax.karlin.mff.cuni.cz/~kendy/blog/pics/libreoffice-personas-1.png

or

http://artax.karlin.mff.cuni.cz/~kendy/blog/pics/libreoffice-personas-2.png

Depends on the taste - there are 35k Personas to choose from :-)  Of
course, switching the Personas off again is trivial in Tools -> Options
-> Personalization too.

The patches that do that are quite small, in fact just this:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a2500801cf2d337f176b074f9159df4925420af4
http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ae27252a6a07f4b67a43be6c9289983f43b2e95
http://cgit.freedesktop.org/libreoffice/core/commit/?id=46505e82ad0f2bd9586e6c853e6e68635dc54007
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fc8c364cc58429bd840f47a80a9258de21ed131

But - there is one catch.  There was no way to load .jpg directly in vcl
(but logically, the functionality belongs there), so I moved
GraphicFilter from svtools to vcl.  The move will also allow
simplification of some code in desktop/ I believe.

Also there were some bugs in vcl that were triggered by the feature; and
I fixed them.  Consequently, the full list of patches to cherry-pick to
libreoffice-4-0 is:

git log 255c03d6ad4ed13c456ee621e0af765684a475d2~..4a4627eba410df933d004170d9f5638526acaed2
git log 540f090a68ae4375a36d0ee6dfbb4a82f28ac704~..540f090a68ae4375a36d0ee6dfbb4a82f28ac704
git log c223e5ff859171adab1597025b30ec2501fc5771~..3f3d0c52ae29b6ab6b2c10a5557714361aa76a26

Please let me know if this is acceptable, and if you need any help with the review.

Thank you a lot,
Kendy

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Cor Nouws Cor Nouws
Reply | Threaded
Open this post in threaded view
|

Re: LATE FEATURE: Personas in LibreOffice

Hi Kendy

Jan Holesovsky wrote (07-01-13 11:32)
> Please let me know if this is acceptable, and if you need any help with the review.

Idea looks great to me and is an invitement for futher enhancements in
the future :-)

I gues the code in a daily from 2012-12-28 (1) is not yet complet?
I see the option page, but choosing an own background image does not
work (file picker handling is broken) and a choosen persona is not shown...

Cheers
Cor
1) Version 4.0.0.0.beta2+ (Build ID:
1d7287f8d7984eae98a577f60a8bc0a740fc5e9)


--
  - Cor
  - http://nl.libreoffice.org
  - www.librelex.org

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan Holesovsky Jan Holesovsky
Reply | Threaded
Open this post in threaded view
|

Re: LATE FEATURE: Personas in LibreOffice

Hi Cor,

Cor Nouws píše v Po 07. 01. 2013 v 22:56 +0100:

> Idea looks great to me and is an invitement for futher enhancements in
> the future :-)
>
> I gues the code in a daily from 2012-12-28 (1) is not yet complet?
> I see the option page, but choosing an own background image does not
> work (file picker handling is broken) and a choosen persona is not shown...

That's too old, you need a build post 2012-01-04.  The 'own background'
is not working even there, and will be removed from 4.0 if the Persona
part is approved (otherwise both will go).

Regards,
Kendy

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Olivier Hallot Olivier Hallot
Reply | Threaded
Open this post in threaded view
|

Re: LATE FEATURE: Personas in LibreOffice

In reply to this post by Jan Holesovsky
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Kendy

I got it working on master. Really nice work and some room or
improvement as well:I wonder if the persona also has a footer to
decorate the LO status bar.

I got a crash on changing a persona to another, but I'll get a traceback
as soon as I can.

Some LibreOffice related personas
http://www.getpersonas.com/en-US/gallery/All/search?p=libreoffice&search.x=0&search.y=0

Regards

Olivier

Em 07-01-2013 08:32, Jan Holesovsky escreveu:

> Hi Astron, Caolán, Olivier, all,
>
> I'd like to ask you [or any additional reviewers :-)] for review of a
> late 4.0 feature - the Firefox Personas for LibreOffice.  It is supposed
> to work like this:
>
> - the user chooses Tools -> Options -> Personalization -> Select Persona
> - then navigates to http://www.getpersonas.com, and chooses Persona she
>   likes
> - copies the URL of that Persona to clipboard, pastes that to the
>   dialog, [OK]
> - closes the Options with [OK]
>
> And the the Persona is used in LibreOffice, like this:
>
> http://artax.karlin.mff.cuni.cz/~kendy/blog/pics/libreoffice-personas-1.png
>
> or
>
> http://artax.karlin.mff.cuni.cz/~kendy/blog/pics/libreoffice-personas-2.png
>
> Depends on the taste - there are 35k Personas to choose from :-)  Of
> course, switching the Personas off again is trivial in Tools -> Options
> -> Personalization too.
>
> The patches that do that are quite small, in fact just this:
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a2500801cf2d337f176b074f9159df4925420af4
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ae27252a6a07f4b67a43be6c9289983f43b2e95
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=46505e82ad0f2bd9586e6c853e6e68635dc54007
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fc8c364cc58429bd840f47a80a9258de21ed131
>
> But - there is one catch.  There was no way to load .jpg directly in vcl
> (but logically, the functionality belongs there), so I moved
> GraphicFilter from svtools to vcl.  The move will also allow
> simplification of some code in desktop/ I believe.
>
> Also there were some bugs in vcl that were triggered by the feature; and
> I fixed them.  Consequently, the full list of patches to cherry-pick to
> libreoffice-4-0 is:
>
> git log 255c03d6ad4ed13c456ee621e0af765684a475d2~..4a4627eba410df933d004170d9f5638526acaed2
> git log 540f090a68ae4375a36d0ee6dfbb4a82f28ac704~..540f090a68ae4375a36d0ee6dfbb4a82f28ac704
> git log c223e5ff859171adab1597025b30ec2501fc5771~..3f3d0c52ae29b6ab6b2c10a5557714361aa76a26
>
> Please let me know if this is acceptable, and if you need any help with the review.
>
> Thank you a lot,
> Kendy
>

- --
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Fundação responsável civilmente, de acordo com o direito civil
Detalhes Legais: http://www.documentfoundation.org/imprint
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJQ6/DpAAoJEJp3R7nH3vLxUOIIAI3tzLd4Q8+eGtgJIyEzDg1g
3l8AN8oc7Bz28cqZYEODcPSzbYubAyjqXZPu1D3k65L6fyVNK9y+gFHnHyJgVSQr
YzFtTXTjEHyNBy8OdVlPI6gbEnsNMQ1rkFT1/uJ1tGiKa9QPG/lyzcTP+2qnSdXp
D/47RGkLXehuoBTuzqVSLlzEhECRXBI80VsLCmnfNJL+ypioJJhJdkL4QqgIn72+
WgxMkeNd44rD0Dm9XAkN+sXizj5+o796gXr+/cSK/uhZ3zp9xnhNd1w2QQgbofmK
KPwROms02W7HnoCUwSn6EoOB7sAKsVq051ojTaOF072AfBXvJjEHeJt06ySt4GI=
=HK7C
-----END PGP SIGNATURE-----
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Adolfo Jayme Barrientos Adolfo Jayme Barrientos
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] LATE FEATURE: Personas in LibreOffice

In reply to this post by Jan Holesovsky
On Mon, Jan 7, 2013 at 4:32 AM, Jan Holesovsky <[hidden email]> wrote:
> Please let me know if this is acceptable, and if you need any help with the review.

It would be really nice to get this landed in 4.0. Many users ask for
greater UI customization, and this is a great start. Putting technical
issues aside, I don’t see UX problems in this.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks-2 Michael Meeks-2
Reply | Threaded
Open this post in threaded view
|

[REVIEW] LATE FEATURE: Personas in LibreOffice

In reply to this post by Jan Holesovsky
Hi there,

        I had a quick read; it -looks- rather low-touch - and the graphic
effect is really pleasant; so I'd be well up for merging this.

( git --no-pager log --numstat -u 255c03d6ad4ed13c456ee621e0af765684a475d2~..4a4627eba410df933d004170d9f5638526acaed2 ;
git --no-pager log --numstat -u 540f090a68ae4375a36d0ee6dfbb4a82f28ac704~..540f090a68ae4375a36d0ee6dfbb4a82f28ac704 ;
git --no-pager log --numstat -u c223e5ff859171adab1597025b30ec2501fc5771~..3f3d0c52ae29b6ab6b2c10a5557714361aa76a26 ) | less

        IIRC we had this feature already for 4.0 for Windows, and this extends
it to Linux+Mac. Having seen some oddness around transparency for Mac in
the past, it would be worth testing there.

        But +1 from me for the -4-0 branch - assuming we can get another couple
of reviews. As a quibble, I'd prefer to see BitmapEx's instead of
BitmapEx*'s being used in the settings - which would simplify the code
and make it less error prone I suspect; BitmapEx::IsEmpty is your
friend :-)

        Otherwise, really nice work !

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Pedro Pedro
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] LATE FEATURE: Personas in LibreOffice

In reply to this post by Adolfo Jayme Barrientos
Hi Kendy, all

Adolfo Jayme Barrientos wrote
On Mon, Jan 7, 2013 at 4:32 AM, Jan Holesovsky <[hidden email]> wrote:
> Please let me know if this is acceptable, and if you need any help with the review.

It would be really nice to get this landed in 4.0. Many users ask for
greater UI customization, and this is a great start. Putting technical
issues aside, I don’t see UX problems in this.
This is a quite nice feature although from my brief tests is only usable with Solid themes (artistic designs make buttons unreadable...)

I tested under Windows XP with
Version 4.1.0.0.alpha0+ (Build ID: ff927ba4272aa8f115472577ec9393df19016f2)
TinderBox: Win-x86@6, Branch:master, Time: 2013-01-08_01:14:22

Background images (there is a typo in the Select Background Image button) are not loaded, neither jpg nor png

Cheers,
Pedro
Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

In reply to this post by Michael Meeks-2
Michael Meeks píše v Út 08. 01. 2013 v 14:21 +0000:

> Hi there,
>
> I had a quick read; it -looks- rather low-touch - and the graphic
> effect is really pleasant; so I'd be well up for merging this.
>
> ( git --no-pager log --numstat -u 255c03d6ad4ed13c456ee621e0af765684a475d2~..4a4627eba410df933d004170d9f5638526acaed2 ;
> git --no-pager log --numstat -u 540f090a68ae4375a36d0ee6dfbb4a82f28ac704~..540f090a68ae4375a36d0ee6dfbb4a82f28ac704 ;
> git --no-pager log --numstat -u c223e5ff859171adab1597025b30ec2501fc5771~..3f3d0c52ae29b6ab6b2c10a5557714361aa76a26 ) | less
>
> IIRC we had this feature already for 4.0 for Windows, and this extends
> it to Linux+Mac. Having seen some oddness around transparency for Mac in
> the past, it would be worth testing there.
>
> But +1 from me for the -4-0 branch - assuming we can get another couple
> of reviews. As a quibble, I'd prefer to see BitmapEx's instead of
> BitmapEx*'s being used in the settings - which would simplify the code
> and make it less error prone I suspect; BitmapEx::IsEmpty is your
> friend :-)

I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into
4-0 branch for 4.0.0.1 build.

Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Leif Lodahl Leif Lodahl
Reply | Threaded
Open this post in threaded view
|

Re: LATE FEATURE: Personas in LibreOffice

In reply to this post by Jan Holesovsky
Hi,
I tried with the daily from
http://dev-builds.libreoffice.org/daily/libreoffice-4-0/Linux-x86_10-Release-Configuration/2013-01-07_14.50.57/

It doesn't work for me on Ubuntu 12.04 with parallel installation. The
settings isn't stored at all.

Cheers,
Leif


Den 08-01-2013 11:33, [hidden email] skrev:

> From: Olivier Hallot<[hidden email]>
> To: Jan Holesovsky<[hidden email]>
> Cc: Caol?n McNamara<[hidden email]>, libo-ux-advise
> <[hidden email]>, "Stefan Knorr
> \(Astron\)"<[hidden email]>, LibreOffice Developer List
> <[hidden email]>
> Subject: Re: LATE FEATURE: Personas in LibreOffice
> Message-ID:<[hidden email]>
> Content-Type: text/plain; charset=UTF-8
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Kendy
>
> I got it working on master. Really nice work and some room or
> improvement as well:I wonder if the persona also has a footer to
> decorate the LO status bar.
>
> I got a crash on changing a persona to another, but I'll get a traceback
> as soon as I can.
>
> Some LibreOffice related personas
> http://www.getpersonas.com/en-US/gallery/All/search?p=libreoffice&search.x=0&search.y=0
>
> Regards
>
> Olivier

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Pedro Pedro
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

In reply to this post by Petr Mladek
Petr Mladek wrote
I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into
4-0 branch for 4.0.0.1 build.
That means it should be available in the 4.0 daily builds tomorrow?

BTW if anyone is curious I played around with the Persona feature and created this
http://www.getpersonas.com/en-US/persona/491370
You can use it in your FF browser as well :)

Enjoy :)
Jean-Baptiste Faure Jean-Baptiste Faure
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

Le 09/01/2013 02:16, Pedro a écrit :
> Petr Mladek wrote
>> I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into
>> 4-0 branch for 4.0.0.1 build.
>
> That means it should be available in the 4.0 daily builds tomorrow?
>
> BTW if anyone is curious I played around with the Persona feature and
> created this
> http://www.getpersonas.com/en-US/persona/491370

I saw, but it does not work for me after a make dev-install on Ubuntu
12.04 x86-64. Nothing changes when I choose an persona's url and LO does
not remember of this url if I reopen options panel.
Note: url depends on your locale, for me it's
http://www.getpersonas.com/fr/persona/491370

> You can use it in your FF browser as well :)

A little too flashy for me ;-)

Best regards.
JBF

--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

In reply to this post by Pedro
Pedro píše v Út 08. 01. 2013 v 17:16 -0800:
> Petr Mladek wrote
> > I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into
> > 4-0 branch for 4.0.0.1 build.
>
> That means it should be available in the 4.0 daily builds tomorrow?

Yup, it should be there.

> BTW if anyone is curious I played around with the Persona feature and
> created this
> http://www.getpersonas.com/en-US/persona/491370
> You can use it in your FF browser as well :)

Nice to see first persona created for LibreOffice :-)

Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|

Re: LATE FEATURE: Personas in LibreOffice

In reply to this post by Leif Lodahl
leif píše v Út 08. 01. 2013 v 20:14 +0100:
> Hi,
> I tried with the daily from
> http://dev-builds.libreoffice.org/daily/libreoffice-4-0/Linux-x86_10-Release-Configuration/2013-01-07_14.50.57/

This is too old. Many fixes were added yesterday evening. You would need
to test a daily build from today if there is any.

> It doesn't work for me on Ubuntu 12.04 with parallel installation. The
> settings isn't stored at all.

It works for me with the last build.

Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

In reply to this post by Jean-Baptiste Faure
Jean-Baptiste Faure píše v St 09. 01. 2013 v 06:22 +0100:

> Le 09/01/2013 02:16, Pedro a écrit :
> > Petr Mladek wrote
> >> I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into
> >> 4-0 branch for 4.0.0.1 build.
> >
> > That means it should be available in the 4.0 daily builds tomorrow?
> >
> > BTW if anyone is curious I played around with the Persona feature and
> > created this
> > http://www.getpersonas.com/en-US/persona/491370
>
> I saw, but it does not work for me after a make dev-install on Ubuntu
> 12.04 x86-64. Nothing changes when I choose an persona's url

It works for me with the last build from 4-0 branch.

>  and LO does
> not remember of this url if I reopen options panel.

Hmm, it does not show the saved url in the options dialog. Instead, it
shows URL template (http://www.getpersonas.com). I wonder if it is a
feature. Kendy?

Anyway, the setting is saved. I see the chosen persona even after
restarting LO.

Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Stefan Knorr Stefan Knorr
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

Hi all,

so, some of you know, I have soem reservations about this feature...
be that as it may, I have a small number of comments still:

* there are some spelling/grammar errors:
** the button for selecting the background image has the word "Backround" on it
** the window for Select a persona has the sentence "Find persona you
like" on it – lacks an "a" before "persona"
** also in that window: "Then copy the URL of page [...]" – lacking a
"the" before "page"

* I fear that enough people don't know what "URL" means, may I propose
"web address" as a more accessible replacement?

* What is the difference between "default persona" and "no persona"
(currently, at least)? I would remove this option until we decide we
want to ship a persona by default.

* Downloading personas appears to be synchronous, leading to visible
UI lag and Windows adding "(doesn't respond)" to the titlebar of the
LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection
speed – it would be much better to make this ascynchronous.

On 9 January 2013 09:54, Petr Mladek <[hidden email]> wrote:
> Hmm, it does not show the saved url in the options dialog. Instead, it
> shows URL template (http://www.getpersonas.com). I wonder if it is a
> feature.

I agree that it would be nice to see the name and URL of the current
persona somewhere, though not necessarily in the Persona Selection
dialogue itself. I guess the name could be on the preferences page,
e.g. directly after the "use own persona" option. Not sure about where
to put the URL...


Astron.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan Holesovsky-3 Jan Holesovsky-3
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

Hi Astron,

Stefan Knorr (Astron) píše v St 09. 01. 2013 v 12:52 +0100:

> so, some of you know, I have soem reservations about this feature...

:-)

> be that as it may, I have a small number of comments still:

Thanks for that, very good points!

> * there are some spelling/grammar errors:
> ** the button for selecting the background image has the word "Backround" on it

Fixed now:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0&id=b020075fd33e0ad20571980d6e72bd86a05bcd2e

> ** the window for Select a persona has the sentence "Find persona you
> like" on it – lacks an "a" before "persona"
> ** also in that window: "Then copy the URL of page [...]" – lacking a
> "the" before "page"
>
> * I fear that enough people don't know what "URL" means, may I propose
> "web address" as a more accessible replacement?

Reworded, I hope better now:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0&id=c821a8ab11ff615737d98858a27ebf24803d7f61

> * What is the difference between "default persona" and "no persona"
> (currently, at least)? I would remove this option until we decide we
> want to ship a persona by default.

Reworded too:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0&id=9b9d4a9472228a647d61edc428d542fd20bcb034

The aim is to be able to install a Persona using an extension even if we
do not ship with a Persona by default; and while at that, provide the
user with the possibility to switch that off (originally 'no persona').
Is it better now?

> * Downloading personas appears to be synchronous, leading to visible
> UI lag and Windows adding "(doesn't respond)" to the titlebar of the
> LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection
> speed – it would be much better to make this ascynchronous.

Actually - I am not sure why it is that slow; it shouldn't be.  Either
way, I'll try to do something about that & make it async.

I'd be able to do a progress bar too, though probably only with 3 steps
(nothing, having loaded the page, having loaded the header, having
loaded the footer).  Is that worth that?

> On 9 January 2013 09:54, Petr Mladek <[hidden email]> wrote:
> > Hmm, it does not show the saved url in the options dialog. Instead, it
> > shows URL template (http://www.getpersonas.com). I wonder if it is a
> > feature.
>
> I agree that it would be nice to see the name and URL of the current
> persona somewhere, though not necessarily in the Persona Selection
> dialogue itself. I guess the name could be on the preferences page,
> e.g. directly after the "use own persona" option. Not sure about where
> to put the URL...

Yes - I plan to do a preview in the lower part of the Personalization
dialog where you'd see (part of) the Persona bitmap.

Not sure if I manage to do the async loading + preview for 4.0,
though :-(  But showing the URL at least should be doable - is that
enough?

Thank you,
Kendy

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Stefan Knorr Stefan Knorr
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

Hi again,

minor correction to my own post only....
>> LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection

Make that "1 MBit/s"...

Astron.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
khagaroth khagaroth
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

It's useless without support for font color settings. Black text on black persona isn't exactly great UX experience. Though to be fair, even with support for this, some of the personas have rather weird color combinations when checked in Firefox.


On Wed, Jan 9, 2013 at 2:38 PM, Stefan Knorr (Astron) <[hidden email]> wrote:
Hi again,

minor correction to my own post only....
>> LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection

Make that "1 MBit/s"...

Astron.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michel RENON Michel RENON
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] LATE FEATURE: Personas in LibreOffice

In reply to this post by Jan Holesovsky
Hi all,

Le 08/01/2013 11:07, Jan Holesovsky a écrit :

> Hi Cor,
>
> Cor Nouws píše v Po 07. 01. 2013 v 22:56 +0100:
>
>> Idea looks great to me and is an invitement for futher enhancements in
>> the future :-)
>>
>> I gues the code in a daily from 2012-12-28 (1) is not yet complet?
>> I see the option page, but choosing an own background image does not
>> work (file picker handling is broken) and a choosen persona is not shown...
>
> That's too old, you need a build post 2012-01-04.  The 'own background'
> is not working even there, and will be removed from 4.0 if the Persona
> part is approved (otherwise both will go).

I tested on build 2013-01-08 on Ubuntu 12.04 and nothing works :-(

Btw, it's a nice feature !
As it's a user's choice, we have not to worry about readability of toobars.


May i make some suggestions on the pref panel ?
- why not keep the "own image" to select an image in local hd ?
- if i understand ok (images and personas are exclusive), we can have
the choices :
      *Toolbar background*
        O Default
        O Image                  <Select Image...>
        O Firefox Persona        <Select Persona...>

        (I renamed "own image" to "Image")

- would it be possible to add a preview of image/persona ?
and a status text if there is an error (error loading image, error
loading persona, timeout...).
 From a user pov, it's an expected feed-back before validating.

- to be complete, LO should keep the path of image/url of persona, and
show it below the preview ; and the url should be entered automatically
in the persona dialog.



So my complete suggestion in ascii :

      *Toolbar background*
        O Default
        O Image                  <Select Image...>
        O Firefox Persona        <Select Persona...>

          [Status text, only if error]
        +---------------------------+
        |                           |
        |         preview           |
        |                           |
        |                           |
        +---------------------------+
        path/url : xxxxxxxxxxxxxxxxxxxxxx





Thanks,
Michel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jean-Baptiste Faure Jean-Baptiste Faure
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

In reply to this post by Jan Holesovsky-3
Hi Kendy,

Le 09/01/2013 14:21, Jan Holesovsky a écrit :
> [...]
> Not sure if I manage to do the async loading + preview for 4.0,
> though :-(  But showing the URL at least should be doable - is that
> enough?

For me it is enough, because we have a preview in Firefox. It is not
exactly the same, but it give a good idea.

Some additional remarks or suggestions for a further version:
1/ if you do several tests with differents personas, each is stored in
the gallery but never removed.
2/ you cannot change your persona when you are offline, even if the
persona you want is already in your gallery.
3/ Perhaps the textfield for the url could be a dropdown list showing
the last used personas, allowing to switch between stored personas.

Best regards.
JBF
--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Next » 12