[Libreoffice-ux-advise] [Bug 101977] New: TRACK CHANGES: More uno commands for accepting/ rejecting changes

classic Classic list List threaded Threaded
16 messages Options
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] New: TRACK CHANGES: More uno commands for accepting/ rejecting changes

https://bugs.documentfoundation.org/show_bug.cgi?id=101977

            Bug ID: 101977
           Summary: TRACK CHANGES: More uno commands for
                    accepting/rejecting changes
           Product: LibreOffice
           Version: 5.3.0.0.alpha0+ Master
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: medium
         Component: Writer
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email],
                    [hidden email]
            Blocks: 83946, 86899

As we reverted the change of bug 83953 in bug 90597, we need uno commands for
'Accept Change and Next' and 'Reject Change and Next'. We also need uno
commands for 'Accept All Changes' and 'Reject All Changes' as these commands
are available in the track changes dialog but dont have uno commands.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Bugs for tracking changes
https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/ rejecting changes

https://bugs.documentfoundation.org/show_bug.cgi?id=101977

Yousuf Philips (jay) <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|libreoffice-ux-advise@lists |
                   |.freedesktop.org            |
     Ever confirmed|0                           |1

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

Gabor Kelemen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email] |[hidden email]
                   |desktop.org                 |
                 CC|                            |libreoffice-ux-advise@lists
                   |                            |.freedesktop.org
           Keywords|                            |needsUXEval
             Status|NEW                         |ASSIGNED

--- Comment #11 from Gabor Kelemen <[hidden email]> ---
Patch in gerrit: https://gerrit.libreoffice.org/#/c/76719/

There are also two more commands in Word that we don't offer:
Accept/Reject all and stop tracking changes

Do we want to have such from UX POV?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

--- Comment #12 from Heiko Tietze <[hidden email]> ---
(In reply to Gabor Kelemen from comment #11)
> There are also two more commands in Word that we don't offer:
> Accept/Reject all and stop tracking changes

We have Accept/Reject All and I don't see a reason for Stop. Or rather we have
it with Record and Show.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

--- Comment #13 from Gabor Kelemen <[hidden email]> ---
(In reply to Heiko Tietze from comment #12)
> (In reply to Gabor Kelemen from comment #11)
> > There are also two more commands in Word that we don't offer:
> > Accept/Reject all and stop tracking changes
>
> We have Accept/Reject All and I don't see a reason for Stop. Or rather we
> have it with Record and Show.

I'm not sure you understood my wording, sorry. Let me try again.

Word has "Accept all changes and stop tracking" and "Reject all changes and
stop tracking". I guess they provide it as one-stop "finish this change
tracking nonsense quickly" commands.
Now that we have "Accept all changes" and "Reject all changes" it would be
simple to combine them with turning off "Record changes" - to get equivalent
commands to what Word has.

Is it okay to have such? Our users have not yet explicitly requested it (only
accept / reject & move to next), but I'd wager they would start noticing the
lack of "what they are used to".

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

--- Comment #14 from Heiko Tietze <[hidden email]> ---
(In reply to Gabor Kelemen from comment #13)
> Is it okay to have such?

Sounds like an overkill to me. MS bloats the UI just to avoid clicking two
buttons. Wouldn't do that.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

--- Comment #15 from Heiko Tietze <[hidden email]> ---
Shouldn't we better always jump to the next item? Why would anyone want to stay
at the same item?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

--- Comment #16 from Gabor Kelemen <[hidden email]> ---
(In reply to Heiko Tietze from comment #15)
> Shouldn't we better always jump to the next item? Why would anyone want to
> stay at the same item?

I must agree; this is also the default behavior of Word.

So: how about changing the toolbar to hide the Accept/Reject buttons and show
Accept and jump / Reject and jump (once my patch + some new icons is merged)
instead?
Targeting power users of 30 page & 200 change documents.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

Gabor Kelemen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=12
                   |                            |6735

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

Commit Notification <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|target:6.0.0                |target:6.0.0 target:6.4.0

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

--- Comment #18 from Commit Notification <[hidden email]> ---
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/1496a1831d1be0a2d24be9fe3ecf627b2664e938%5E%21

tdf#101977 change tracking: add 'Accept/Reject and jump to next' commands

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

László Németh <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #19 from László Németh <[hidden email]> ---
Note: we need new icons for the extended Track Changes toolbar.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

--- Comment #20 from Rizal Muttaqin <[hidden email]> ---
Created attachment 153998
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153998&action=edit
Accept This Change and Accept and Move to Next use Similar Icon

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

Rizal Muttaqin <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #21 from Rizal Muttaqin <[hidden email]> ---
@Andreas Kainz, this might be added to the menubar (Edit > Track Changes ) as
well as in Tabbed interface (Review)

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

Dieter Praas <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=12
                   |                            |7415

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

--- Comment #22 from Gabor Kelemen <[hidden email]> ---
(In reply to Rizal Muttaqin from comment #21)
> @Andreas Kainz, this might be added to the menubar (Edit > Track Changes )

That makes no sense. See the first comment from Heiko in
https://gerrit.libreoffice.org/#/c/76719/ 

These commands are for working quickly, and digging two levels into the main
menu is not a good start for that.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise