[Libreoffice-ux-advise] [Bug 129720] Populate the Description box of the Customize dialog with multiline tooltip from bug 108458

classic Classic list List threaded Threaded
1 message Options
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 129720] Populate the Description box of the Customize dialog with multiline tooltip from bug 108458

https://bugs.documentfoundation.org/show_bug.cgi?id=129720

Muhammet Kara <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needsUXEval                 |difficultyBeginner,
                   |                            |skillCpp, skillUI

--- Comment #3 from Muhammet Kara <[hidden email]> ---
(In reply to Heiko Tietze from comment #2)
> While I agree that description is not needed anymore, the control nicely
> aligns the two trees. So how about showing the new multiline info from the
> tooltip in this box?

Sounds okay to me. In fact, this can also be an easyHack.

Around line m_xDescriptionField in cfg.cxx, you will see a block for this
check: "if ( !SfxHelp::IsHelpInstalled() )".

Just make necessary changes in that block to make the description field to show
the tooltip for the command instead of the "local help is not installed"
message, which is coming from the ui file, and set & used as sDescTooltip.

As we will no longer show an empty description on absense of local help, the
tooltip for the m_xDescriptionField which comes from the "desc" item in the
"menuassignpage.ui" is also no longer needed, so better to also remove that,
along with the sDescTooltip const.

In fact, I would just remove the whole if-else ladder starting with "if (
!SfxHelp::IsHelpInstalled() )", and check for empty string returning from the
m_xFunctions->GetHelpText(false) call, and set the multiline tooltip as the new
text if it is empty.

The tooltip commit:
https://gerrit.libreoffice.org/plugins/gitiles/core/+diff/444f0d256957544d26b9af9a0898364e829df1b5%5E%21

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise