[Libreoffice-ux-advise] [Bug 90883] New: WRITER: Selecting rows/columns doesnt change the behaviour of insert buttons

classic Classic list List threaded Threaded
8 messages Options
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 90883] New: WRITER: Selecting rows/columns doesnt change the behaviour of insert buttons

https://bugs.documentfoundation.org/show_bug.cgi?id=90883

            Bug ID: 90883
           Summary: WRITER: Selecting rows/columns doesnt change the
                    behaviour of insert buttons
           Product: LibreOffice
           Version: Inherited From OOo
          Hardware: Other
                OS: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: medium
         Component: ux-advise
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email]

In calc, if you select multiple rows or columns of a sheet and insert
rows/columns, it inserts an equal amount of rows/columns as to what has been
selected. But this behaviour isnt available in writer's insert commands
(.uno:InsertRows, .uno:InsertColumns) in the table toolbar.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 90883] WRITER: Selecting rows/columns doesnt change the behaviour of insert buttons

https://bugs.documentfoundation.org/show_bug.cgi?id=90883

V Stuart Foote <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from V Stuart Foote <[hidden email]> ---
@Jay, hate to state the obvious, but Calc's cells/columns/rows have no data
structure in common with Table's cells/columns/rows.

Yes it is worth looking at for consistency of UI. I'm not sure of all details
of the exposed attributes for Writer Tables, but the enhancement may simply not
be possible.

In general, there is no reason to expect .uno commands affecting Calc sheets to
function the same when the .uno command is affecting Tables in Writer (or other
modules that implement tables).

For Writer Tables the insertRow, insertColumn UNO commands insert  rows and
columns one at a time, it does not replicate the multiple row, or multiple
column selected "counts" as implemented for the actions in Calc.

Likewise, selection of rows/columns in Calc is not the same as its counterpart
in Writer Tables.  These selections also happens to use the same UNO
commands--but also have different actions appropriate to the Object type.

For example, notice that with a Table, you can select multiple rows/columns
with <Shift> selects, but you cannot then deselect a row or a column (with
<Ctrl> select). There are different structures and exposed attributes for UNO
actions to affect.

These misconceptions of a shared data structure and function lead to issues
like bug 37223.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 90883] WRITER: Selecting rows/columns doesnt change the behaviour of insert buttons

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=90883

V Stuart Foote <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from V Stuart Foote <[hidden email]> ---


*** This bug has been marked as a duplicate of bug 90821 ***

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 90883] WRITER: Selecting rows/columns doesnt change the behaviour of insert buttons

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=90883

Jay Philips <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |NEW
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=90
                   |                            |882
         Resolution|DUPLICATE                   |---
     Ever confirmed|0                           |1
         Whiteboard|                            |needsDevEval topicUI

--- Comment #3 from Jay Philips <[hidden email]> ---
Reopening as bug 90821 doesnt cover what this enhancement intends to fix.

(In reply to V Stuart Foote from comment #1)
> @Jay, hate to state the obvious, but Calc's cells/columns/rows have no data
> structure in common with Table's cells/columns/rows.

I'm quite aware that they dont. ;D

> Yes it is worth looking at for consistency of UI. I'm not sure of all
> details of the exposed attributes for Writer Tables, but the enhancement may
> simply not be possible.

I believe it will be possible. We can detect when an entire row is selected, as
you can see it in the statusbar, so using the same information, we should be
able to change the behaviour of the uno commands to insert accordingly.

> In general, there is no reason to expect .uno commands affecting Calc sheets
> to function the same when the .uno command is affecting Tables in Writer (or
> other modules that implement tables).

Not saying that it should, but i'm suggesting that unifying the behaviour means
that its easier for users to have a consistent experience between the apps.

> Likewise, selection of rows/columns in Calc is not the same as its
> counterpart in Writer Tables.  These selections also happens to use the same
> UNO commands--but also have different actions appropriate to the Object type.

I'm aware of this, which is why i have asked that alternative insert uno
commands be created for writer which have the similar insertion direction
behavior (bug 90882).

Another problem is that these same named uno commands have the single icons to
them when they have different behaviours, which also causes more problems.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 90883] WRITER: Selecting multiple rows/columns doesnt change the behaviour of insert buttons

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=90883

Cor Nouws <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|WRITER: Selecting           |WRITER: Selecting multiple
                   |rows/columns doesnt change  |rows/columns doesnt change
                   |the behaviour of insert     |the behaviour of insert
                   |buttons                     |buttons

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 90883] WRITER: Selecting multiple rows/columns doesnt change the behaviour of insert buttons

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=90883

Philippe Jung <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[hidden email] |[hidden email]
                   |desktop.org                 |

--- Comment #4 from Philippe Jung <[hidden email]> ---
Commit in approach

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 90883] WRITER: Selecting multiple rows/columns doesnt change the behaviour of insert buttons

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=90883

--- Comment #5 from Philippe Jung <[hidden email]> ---
https://gerrit.libreoffice.org/15741

The behaviour is now coherent with the button extended text:

When several rows / columns are selected, an equivalent number of rows /
columns are inserted.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
bugzilla-daemon-2 bugzilla-daemon-2
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] [Bug 90883] WRITER: Selecting multiple rows/columns doesnt change the behaviour of insert buttons

In reply to this post by bugzilla-daemon-2
https://bugs.documentfoundation.org/show_bug.cgi?id=90883

Yousuf (Jay) Philips <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|libreoffice-ux-advise@lists |
                   |.freedesktop.org            |
          Component|ux-advise                   |Writer

--- Comment #6 from Yousuf (Jay) Philips <[hidden email]> ---
Thanks Philippe for taking this one on. Removing ux-advise.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise