[Libreoffice-ux-advise] UI changes for LO-5.0 - review needed

classic Classic list List threaded Threaded
6 messages Options
Tamás Zolnai Tamás Zolnai
Reply | Threaded
Open this post in threaded view
|

[Libreoffice-ux-advise] UI changes for LO-5.0 - review needed

Hi guys,

I submit two patches to gerrit related to text highlighting:
First one renames all instances of character "Background" to "Highlighting":
https://gerrit.libreoffice.org/#/c/16322/
Second one adds a Highlighting Tab to paragraph styles dialog, because
in the LO-4.4 release we lost the functionality of setting character
background for paragraph styles:
https://gerrit.libreoffice.org/#/c/16324/

I would need review from the UX side. I hope it can get into the 5.0
branch before the UI freeze.

Thanks,
Tamás
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Fitoschido Fitoschido
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] UI changes for LO-5.0 - review needed

> I would need review from the UX side.

+1 from UX :-)

Adolfo
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Jean-Baptiste Faure-3 Jean-Baptiste Faure-3
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] UI changes for LO-5.0 - review needed

In reply to this post by Tamás Zolnai
Hi,

Le 17/06/2015 00:17, Zolnai Tamás a écrit :

> Hi guys,
>
> I submit two patches to gerrit related to text highlighting:
> First one renames all instances of character "Background" to "Highlighting":
> https://gerrit.libreoffice.org/#/c/16322/
> Second one adds a Highlighting Tab to paragraph styles dialog, because
> in the LO-4.4 release we lost the functionality of setting character
> background for paragraph styles:
> https://gerrit.libreoffice.org/#/c/16324/
>

I do not understand how Highlighting is supposed to work when in
conjunction with area filling. I tried it but if I define an area
filling then the color highlighting is not visible. Even if I set
transparency. So, at the moment, it is one or the other but not both.

That said I still not understand why background has been renamed in
area. It sound weird when translated in French (zone).

Best regards
JBF


--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Tamás Zolnai Tamás Zolnai
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] UI changes for LO-5.0 - review needed

2015-06-17 9:16 GMT+02:00 Jean-Baptiste Faure <[hidden email]>:

> Hi,
>
> Le 17/06/2015 00:17, Zolnai Tamás a écrit :
>> Hi guys,
>>
>> I submit two patches to gerrit related to text highlighting:
>> First one renames all instances of character "Background" to "Highlighting":
>> https://gerrit.libreoffice.org/#/c/16322/
>> Second one adds a Highlighting Tab to paragraph styles dialog, because
>> in the LO-4.4 release we lost the functionality of setting character
>> background for paragraph styles:
>> https://gerrit.libreoffice.org/#/c/16324/
>>
>
> I do not understand how Highlighting is supposed to work when in
> conjunction with area filling. I tried it but if I define an area
> filling then the color highlighting is not visible. Even if I set
> transparency. So, at the moment, it is one or the other but not both.

Highlighting should be placed above the area fill. It's a bug, I
missed to cherry-pick all needed changes from master,
now it works on libreoffice-5.0 branch too.

Thanks,
Tamás
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Jean-Baptiste Faure-3 Jean-Baptiste Faure-3
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] UI changes for LO-5.0 - review needed

Le 17/06/2015 10:10, Zolnai Tamás a écrit :
> [...]
> Highlighting should be placed above the area fill. It's a bug, I
> missed to cherry-pick all needed changes from master,
> now it works on libreoffice-5.0 branch too.

Ha, ok. Works now.

Another thing: highlighting is only in the paragraph style dialog, not
in the paragraph formatting dialog nor in the property tab of the
sidebar. Is that delibarate?

Best regards.
JBF

--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Tamás Zolnai Tamás Zolnai
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] UI changes for LO-5.0 - review needed

2015-06-17 11:04 GMT+02:00 Jean-Baptiste Faure <[hidden email]>:

> Le 17/06/2015 10:10, Zolnai Tamás a écrit :
>> [...]
>> Highlighting should be placed above the area fill. It's a bug, I
>> missed to cherry-pick all needed changes from master,
>> now it works on libreoffice-5.0 branch too.
>
> Ha, ok. Works now.
>
> Another thing: highlighting is only in the paragraph style dialog, not
> in the paragraph formatting dialog nor in the property tab of the
> sidebar. Is that delibarate?

Yes, it works like that. A paragraph style is special, it can contain
both paragraph and character attributes, but the direct formatting of
paragraphs means only paragraph level attributes.

Best Regards,
Tamás
_______________________________________________
Libreoffice-ux-advise mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise