Modifying an Impress Template

classic Classic list List threaded Threaded
5 messages Options
Samuel Mehrbrodt-2 Samuel Mehrbrodt-2
Reply | Threaded
Open this post in threaded view
|

Modifying an Impress Template

Hi,

I need to modify an default Impress template to fix [1].

I guess, when I edit it in Impress, information like Author, last
changed etc. will be saved there.
I could unzip it, edit the xml and zip it again, but in both cases there
will be no meaningful diff, since it's a ZIP file.

What is the best way to do this?

Samuel

[1] https://bugs.freedesktop.org/show_bug.cgi?id=59396
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Alexander Wilms Alexander Wilms
Reply | Threaded
Open this post in threaded view
|

Re: Modifying an Impress Template

Hi Samuel,

Wouldn't the commit message suffice to explain the changes?

One thing one needs to do before committing is stripping language settings within the file with this script: solenv/bin/striplanguagetags.sh

Are you fixing that for the 4.0 branch? I made some improvements to several impress templates and wonder whether I'd need reviews in order to commit them to 4.0

Alex
Samuel Mehrbrodt-2 Samuel Mehrbrodt-2
Reply | Threaded
Open this post in threaded view
|

Re: Modifying an Impress Template

Hi Alexander,

Am 16.01.2013 13:54, schrieb Alexander Wilms:
> Hi Samuel,
>
> Wouldn't the commit message suffice to explain the changes?
>
> One thing one needs to do before committing is stripping language settings
> within the file with this script: solenv/bin/striplanguagetags.sh
I just tried to run that script on the updated template, and here's what
I got: http://pastie.org/5697585
>
> Are you fixing that for the 4.0 branch? I made some improvements to several
> impress templates and wonder whether I'd need reviews in order to commit
> them to 4.0

I'm fixing in Master, but it might be good to have it in 4.0 also. I'm
going to push it to Gerrit and let the others decide.

Samuel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Samuel Mehrbrodt-2 Samuel Mehrbrodt-2
Reply | Threaded
Open this post in threaded view
|

Re: Modifying an Impress Template

Well, I just edited it manually and submitted the patch to Gerrit:
https://gerrit.libreoffice.org/1725

Am 16.01.2013 18:22, schrieb Samuel Mehrbrodt:
> I just tried to run that script on the updated template, and here's
> what I got: http://pastie.org/5697585

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: Modifying an Impress Template

In reply to this post by Samuel Mehrbrodt-2
Hi Samuel,

On Wednesday, 2013-01-16 18:22:03 +0100, Samuel Mehrbrodt wrote:

> >One thing one needs to do before committing is stripping language settings
> >within the file with this script: solenv/bin/striplanguagetags.sh
> I just tried to run that script on the updated template, and here's
> what I got: http://pastie.org/5697585

That script uses $CALLXSLTPROC to invoke an XSTL processor defined by
$XSLTPROC with some options and is/was only defined in the build system.
I just added a check to bail out if the variable is undefined instead of
attempting a wild try to execute the remaining command option..

I'm not sure though when it actually would be executed, it seems
CALLXSLTPROC was only set when one of the ZIP*STRIPLANGUAGETAGS targets
was defined in the old dmake system, but I don't find any place where
that would be the case now. It may have been forgotten when converting
to gbuild.

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
New GnuPG key 0x65632D3A : 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Old GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (853 bytes) Download Attachment