OSL_ASSERT: items_.empty() because of Setup/L10N

classic Classic list List threaded Threaded
5 messages Options
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

OSL_ASSERT: items_.empty() because of Setup/L10N

Hello,

On pc Debian x86-64 with master sources updated today, I noticed this on console:
warn:legacy.osl:22303:1:unotools/source/config/configmgr.cxx:173: OSL_ASSERT: items_.empty()

I think it's quite old but I would like to tackle this.
I made some debug and found that it was "Setup/L10N"
It's created there:
http://opengrok.libreoffice.org/xref/core/unotools/source/config/syslocaleoptions.cxx#513
and it seems there's a refcount pb when adding some logs in ctr and destr of SvtSysLocaleOptions

http://opengrok.libreoffice.org/search?q=holdConfigItem&project=core&defs=&refs=&path=unotools%2F&hist=
shows that some initializing elements use refcount, some use std::unique_ptr, some std::shared_ptr
Also, the way to deal with multithreads/mutex is also different depending on cases

Any idea what right rules to follow?

Julien
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: OSL_ASSERT: items_.empty() because of Setup/L10N

Hi julien2412,

On Saturday, 2016-11-05 12:57:47 -0700, julien2412 wrote:

> On pc Debian x86-64 with master sources updated today, I noticed this on
> console:
> warn:legacy.osl:22303:1:unotools/source/config/configmgr.cxx:173:
> OSL_ASSERT: items_.empty()

I don't see that, has it been addressed meanwhile?

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (836 bytes) Download Attachment
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

Re: OSL_ASSERT: items_.empty() because of Setup/L10N

On 10/11/2016 14:36, Eike Rathke wrote:
> Hi julien2412,
>
> On Saturday, 2016-11-05 12:57:47 -0700, julien2412 wrote:
>
>> On pc Debian x86-64 with master sources updated today, I noticed this on
>> console:
>> warn:legacy.osl:22303:1:unotools/source/config/configmgr.cxx:173:
>> OSL_ASSERT: items_.empty()
> I don't see that, has it been addressed meanwhile?
Hi Eike,

No I just replaced the legacy log with this:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ea62fe8a1194bca3bee5048832456c3559dcb8e

With a brand new user profile, I get this at opening of Calc:
warn:opencl:6877:1:desktop/source/app/opencl.cxx:137: Failed to
initialize OpenCL for test
warn:sfx.view:6877:1:sfx2/source/view/viewfrm.cxx:2956: SID_SIDEBAR
state requested, but no task pane child window exists for this ID!
warn:sfx.control:6877:1:sfx2/source/control/dispatch.cxx:1422:
Childwindow slot missing: 25807
warn:sfx.control:6877:1:sfx2/source/control/dispatch.cxx:1422:
Childwindow slot missing: 25807

and when closing Calc:
warn:legacy.osl:6728:1:svl/source/items/itempool.cxx:414: old secondary
pool must be empty
warn:legacy.osl:6728:1:svl/source/items/itempool.cxx:414: old secondary
pool must be empty
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:legacy.tools:6728:1:basic/source/sbx/sbxobj.cxx:94: Object element
with dangling parent
warn:unotools.config:6728:1:unotools/source/config/configmgr.cxx:167:
ConfigManager not empty

Julien
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: OSL_ASSERT: items_.empty() because of Setup/L10N

Hi Julien,

On Friday, 2016-11-11 06:30:05 +0100, Julien Nabet wrote:

> and when closing Calc:
> warn:unotools.config:6728:1:unotools/source/config/configmgr.cxx:167:
> ConfigManager not empty

Ah, when you *exit* the entire *application* ... yes, I see that too.

That one instance of SvtSysLocaleOptions_Impl likely is due to the
static SvtSysLocaleOptions_Impl* SvtSysLocaleOptions::pOptions in
unotools/source/config/syslocaleoptions.cxx

It probably helps to change that to an rtl::Static, or maybe more
appropriate use a std::weak_ptr like it is done for SvtSysLocale_Impl in
unotools/source/misc/syslocale.cxx and use tdf#89329 to commit.

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (836 bytes) Download Attachment
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

Re: OSL_ASSERT: items_.empty() because of Setup/L10N

On 11/11/2016 22:08, Eike Rathke wrote:

> Hi Julien,
>
> On Friday, 2016-11-11 06:30:05 +0100, Julien Nabet wrote:
>
>> and when closing Calc:
>> warn:unotools.config:6728:1:unotools/source/config/configmgr.cxx:167:
>> ConfigManager not empty
> Ah, when you *exit* the entire *application* ... yes, I see that too.
>
> That one instance of SvtSysLocaleOptions_Impl likely is due to the
> static SvtSysLocaleOptions_Impl* SvtSysLocaleOptions::pOptions in
> unotools/source/config/syslocaleoptions.cxx
>
> It probably helps to change that to an rtl::Static, or maybe more
> appropriate use a std::weak_ptr like it is done for SvtSysLocale_Impl in
> unotools/source/misc/syslocale.cxx and use tdf#89329 to commit.
Sorry you're right, I should have said "exit the entire application"
instead of closing Calc.

Anyway, thank you Eike for the guidance!
I submitted a patch here: https://gerrit.libreoffice.org/#/c/30787/

Julien
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice