[PATCH 3.5 and master] Avoid UI bugs in translations

classic Classic list List threaded Threaded
15 messages Options
William Gathoye William Gathoye
Reply | Threaded
Open this post in threaded view
|

[PATCH 3.5 and master] Avoid UI bugs in translations

Hello guys,

I've corrected some problems (truncated strings) in the UI that was affecting the French LibO translation.

1. When saving in other formats than ODF:

Problem: http://libreoffice.gathoye.be/Libreoffice_bug_report_3.5_not_enough_place_save_fr.png

Solution: http://libreoffice.gathoye.be/Libreoffice_bug_report_3.5_not_enough_place_save_en_patch.png

I've so removed the "Use" verb in the string button, but added a new question to sound more user friendly.
And I tried to add [ en-US ] in the text Save that wasn't transtated in the dialog title.

Sorry in the compilation I made, my dialog style is still transparent, I don't know why...
The revisions I made on US translation template aren't automatically pushed to .po file in the translation folder. An idea ?

2. In Writer, the name given to the new word count feature is quite strange : Word Count. It doesn't only count the words but the chars and spaces too. I think the old name remains still the best : "Statistics".

Other problem with this new improved feature : the close button isn't translated. So I checked if this latter had [ en-US ].

My patch: http://pastebin.com/X7FG1kW8
Korrawit Pruegsanusak Korrawit Pruegsanusak
Reply | Threaded
Open this post in threaded view
|

[PATCH 3.5 and master] Avoid UI bugs in translations

Hello all,

Forward this to libreoffice-ux-advise. Would be good to have it before
string freeze, which is due next Monday :)

Thanks!

On Sat, Jan 7, 2012 at 05:21, willubuntu <[hidden email]> wrote:

> Hello guys,
>
> I've corrected some problems (truncated strings) in the UI that was
> affecting the French LibO translation.
>
> 1. When saving in other formats than ODF:
>
> Problem:
> http://libreoffice.gathoye.be/Libreoffice_bug_report_3.5_not_enough_place_save_fr.png
>
> Solution:
> http://libreoffice.gathoye.be/Libreoffice_bug_report_3.5_not_enough_place_save_en_patch.png
>
> I've so removed the "Use" verb in the string button, but added a new
> question to sound more user friendly.
> And I tried to add [ en-US ] in the text Save that wasn't transtated in the
> dialog title.
>
> Sorry in the compilation I made, my dialog style is still transparent, I
> don't know why...
> The revisions I made on US translation template aren't automatically pushed
> to .po file in the translation folder. An idea ?
>
> 2. In Writer, the name given to the new word count feature is quite strange
> : Word Count. It doesn't only count the words but the chars and spaces too.
> I think the old name remains still the best : "Statistics".
>
> Other problem with this new improved feature : the close button isn't
> translated. So I checked if this latter had [ en-US ].
>
> My patch:  http://pastebin.com/X7FG1kW8
>


--
Korrawit Pruegsanusak
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Cor Nouws Cor Nouws
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

Korrawit Pruegsanusak wrote (07-01-12 06:48)

> Forward this to libreoffice-ux-advise. Would be good to have it before
> string freeze, which is due next Monday :)

Sounds reasonable to me ...

However, I remember there has been quite extensive discussion / testing
(in which I wasn't involved, so I don't remember details - which I
wouldn't anyway) to get is as it is now.

Maybe it's good to look at this lists archives for those.

--
  - Cor
  - http://nl.libreoffice.org

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Stefan Knorr (Astron) Stefan Knorr (Astron)
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

Hi all,

So...
1. The change of the title (Text to Text [en-US]) seems extremely
sensible to me and should get in as early as possible, so other
translators see the new string too.

2. The question you added seems sensible to me, even though it makes
the text even longer [1], so should probably get in. Also, it would be
great, if you could remove or at least comment out the "en-US-old"
thing, that seems mighty confusing.

3. It is a bit of a problem to use button labels without a verb (or
alternatively OK) and also probably goes against most HIGs, so not a
good idea IMO. William, is it a possibility to use just "Utiliser ODF"
just for French (that this is a file format is made clear before,
anyway)?

4. I have a few reservations against using "Statistics" instead of
"Word Count." While, technically, you're right, the word count is just
part of what you get, "Word Count" seems much more digestible to me
and is also the main use of the feature. Also, it used to be called
"Word Count" in all older English version, too.


> However, I remember there has been quite extensive discussion / testing (in
> which I wasn't involved, so I don't remember details - which I wouldn't
> anyway) to get is as it is now.


Right, there was a bit of discussion about the dialog, see this
(pretty long) thread:
http://lists.freedesktop.org/archives/libreoffice-ux-advise/2011-August/000201.html

We didn't reach any consensus, there, though

Regards,

Astron.


[1] http://www.joelonsoftware.com/uibook/chapters/fog0000000062.html
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Christoph Noack Christoph Noack
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

Hi all!

Adding Josh, since he provided the initial patch to improve the dialog.

Furthermore, there is a recent bug reporting this issue (also) for the
German translation. So, whoever has the power of the source *g*, please
subscribe (assign) to it:
https://bugs.freedesktop.org/show_bug.cgi?id=44155

Am Samstag, den 07.01.2012, 11:54 +0100 schrieb Stefan Knorr (Astron):
> Hi all,
>
> So...
> 1. The change of the title (Text to Text [en-US]) seems extremely
> sensible to me and should get in as early as possible, so other
> translators see the new string too.

Good catch! Especially, since I missed that we now use a different
string than "$PRODUCTNAME".

However, the currently used "Save" is a bit misleading to me, since (at
least in Gnome) it is also used in the preceding Save As dialog. Our
recent dialog is about asking the user whether he is sure about the
chosen file format.

If we decide to use the title bar text, could we please use something
like: "Confirm file format" / "Use of file format".

Astron, your thoughts?

For the record, Gnome suggests to avoid title text for alert windows:
http://developer.gnome.org/hig-book/3.0/windows-alert.html


> 2. The question you added seems sensible to me, even though it makes
> the text even longer [1], so should probably get in. Also, it would be
> great, if you could remove or at least comment out the "en-US-old"
> thing, that seems mighty confusing.
>
> 3. It is a bit of a problem to use button labels without a verb (or
> alternatively OK) and also probably goes against most HIGs, so not a
> good idea IMO. William, is it a possibility to use just "Utiliser ODF"
> just for French (that this is a file format is made clear before,
> anyway)?

Mmh, although I understand the rationale, I fear that the recent changes
make the dialog more complicated that it was before Josh initially
touched it. The body text is now longer (having the real question at the
end), whilst the buttons don't reveal to less advanced users what they
are for. People usually scan the button text first, before they start
reading the alert text.

So my suggestion is to keep the current behavior. William, does Astron's
proposal sound reasonable? That would be great ...

Astron mentioned the missing consensus - maybe we can further improve
for the next release? I still think that something like
        [Confirm WhatEver Format] [Switch to ODF]
or
        [Use WhatEver Format] [Use ODF Format]
would be more helpful. The rationale can be found here:
http://lists.freedesktop.org/archives/libreoffice-ux-advise/2011-August/000209.html


> 4. I have a few reservations against using "Statistics" instead of
> "Word Count." While, technically, you're right, the word count is just
> part of what you get, "Word Count" seems much more digestible to me
> and is also the main use of the feature. Also, it used to be called
> "Word Count" in all older English version, too.

+1 to use "Word Count" for the same reasons. However, thanks for fixing
the "en-US" tag.

For the record: some "statistics" (German equivalent: document
statistics) are already available in File - Properties - Statistics.

[...]

Cheers,
Christoph

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Stefan Knorr (Astron) Stefan Knorr (Astron)
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

Hi Christoph, William, everyone reading,

I've made a new patch that does only the following things:
* Correct the [en-US] thing
* Use Christoph's proposal "Confirm File Format" as the window title
* Remove the [en-US-old] text as that would have only been confusing
* (Probably most controversial:) shortened the body text, but added a
question in again, so now this is:
"This document may contain content that cannot be saved in the
currently selected file format "FORMATNAME". Do you really want to use
"FORMATNAME"?

To be sure the document is saved correctly, use the ODF format."

If there is no uproar, I will push this and ask for a cherry-pick (my
git skills are still a bit rudimentary and I don't want to mess up the
release).

Regards,

Astron.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0001-Make-the-title-of-foreign-file-format-warning-transl.patch (2K) Download Attachment
Korrawit Pruegsanusak Korrawit Pruegsanusak
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

In reply to this post by Christoph Noack
Hello Christoph, all,

On Sun, Jan 8, 2012 at 03:14, Christoph Noack <[hidden email]> wrote:
> Furthermore, there is a recent bug reporting this issue (also) for the
> German translation. So, whoever has the power of the source *g*, please
> subscribe (assign) to it:
> https://bugs.freedesktop.org/show_bug.cgi?id=44155

For the choice buttons that are too small, IMHO this could be fixed by
resizing them to be larger, if don't want to change the texts. :-)

Best Regards,
--
Korrawit Pruegsanusak
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Stefan Knorr (Astron) Stefan Knorr (Astron)
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

Hi Korrawit,

> For the choice buttons that are too small, IMHO this could be fixed by
> resizing them to be larger, if don't want to change the texts. :-)

Hm, probably. Could you have a look, though, please, as these labels
are already supposed to get wider automatically and don't use
hard-coded numbers unlike most of our UI code.

Astron.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andras Timar Andras Timar
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

2012/1/9 Stefan Knorr (Astron) <[hidden email]>:
> Hi Korrawit,
>
>> For the choice buttons that are too small, IMHO this could be fixed by
>> resizing them to be larger, if don't want to change the texts. :-)
>
> Hm, probably. Could you have a look, though, please, as these labels
> are already supposed to get wider automatically and don't use
> hard-coded numbers unlike most of our UI code.

No, the second button was not resized automatically. Now it is fixed.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2e0ec77cd6bbfe599d63f3a67218c1cf09bb19a6
In 3-5, too.

Best regards,
Andras
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andras Timar Andras Timar
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

In reply to this post by Stefan Knorr (Astron)
Hi Stefan,

2012/1/8 Stefan Knorr (Astron) <[hidden email]>:

> Hi Christoph, William, everyone reading,
>
> I've made a new patch that does only the following things:
> * Correct the [en-US] thing
> * Use Christoph's proposal "Confirm File Format" as the window title
> * Remove the [en-US-old] text as that would have only been confusing
> * (Probably most controversial:) shortened the body text, but added a
> question in again, so now this is:
> "This document may contain content that cannot be saved in the
> currently selected file format "FORMATNAME". Do you really want to use
> "FORMATNAME"?
>
> To be sure the document is saved correctly, use the ODF format."
>
> If there is no uproar, I will push this and ask for a cherry-pick (my
> git skills are still a bit rudimentary and I don't want to mess up the
> release).
>

Thanks for taking care of this issue. Pushed to libreoffice-3-5 with
changes. I did not see the point in shortening the body text. My goal
was to keep the amount of textual changes as little as possible at
this late stage of 3-5 development.

Best regards,
Andras
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks-2 Michael Meeks-2
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations


On Mon, 2012-01-09 at 21:30 +0100, Andras Timar wrote:
> > "This document may contain content that cannot be saved in the
> > currently selected file format "FORMATNAME". Do you really want to use
> > "FORMATNAME"?
> >
> > To be sure the document is saved correctly, use the ODF format."
...
> Thanks for taking care of this issue. Pushed to libreoffice-3-5 with
> changes. I did not see the point in shortening the body text.

        Personally, I -love- this feature :-) it finally makes that dialog
clear. Any chance whomever did this work (or some other kind volunteer)
can add a screenshot and credit to:

        http://wiki.documentfoundation.org/ReleaseNotes/3.5

        Thanks ! :-)

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Stefan Knorr (Astron) Stefan Knorr (Astron)
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

Hi Michael, Andras,

>> Thanks for taking care of this issue. Pushed to libreoffice-3-5 with
>> changes. I did not see the point in shortening the body text.

Thanks for cherry-picking.
To put it with Joel Spolsky: "Users can't read" (linked to the
corresponding article further up in the thread). So it does make sense
to keep text as short as possible. Anyway, I do understand your
reasoning for not pushing the change in 3.5 (in 3.6, it would be good
to see the change, though).


>        Personally, I -love- this feature :-) it finally makes that dialog
> clear. Any chance whomever did this work (or some other kind volunteer)
> can add a screenshot and credit to:
>
>        http://wiki.documentfoundation.org/ReleaseNotes/3.5

Hm, right, we (that'd be Josh, Christoph, William and me, possibly
others, too) changed that dialogue twice in the 3.5 cycle. I am
unsure, though, if the number of people who discussed this really
merits a mention in 3.6 release notes (as it's not in 3.5, as Andras
said).

Astron.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks-2 Michael Meeks-2
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations


On Tue, 2012-01-10 at 16:24 +0100, Stefan Knorr (Astron) wrote:

> >        Personally, I -love- this feature :-) it finally makes that dialog
> > clear. Any chance whomever did this work (or some other kind volunteer)
> > can add a screenshot and credit to:
> >
> >        http://wiki.documentfoundation.org/ReleaseNotes/3.5
>
> Hm, right, we (that'd be Josh, Christoph, William and me, possibly
> others, too) changed that dialogue twice in the 3.5 cycle. I am
> unsure, though, if the number of people who discussed this really
> merits a mention in 3.6 release notes (as it's not in 3.5, as Andras
> said).

        It's not ? I do a 'File' Save->As in 3.5.0b2 and instead of this
hideous "Keep Current Format" nonsense that I (and my spouse) visibly
struggle with each time; I get a comprehensible choice :-)

        In my book that is a dialog that ~every one of our users stumbles over,
and having a screenshot of the improvement in the release notes is
pretty useful :-) It'd be great if we could add it ...

        ATB,

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
William Gathoye William Gathoye
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

1. Astron,  I've just finished compiling latest LibO 3.5 branch. I confirm the patch has been pushed in master and 3.5 branches. I've no more problem with French translation. Thanks for having put my name in git log.

By my technical prerequisites, I could have done the required modification all by myself. But I still need some time to be more familiar with LibO code organization. For example, what does this hard-coded macro IMPL_EXTRA_BUTTON_WIDTH?
And how to get an instant view of code modification I did? I've to run make -rs, which a bit slow. I can't stand waiting. (ccache is installed and work fine).

2. Michael : As you was insisting : I've updated the LibO 3.5 Release Notes with a great screenshot. :P

3. Concerning the "Statistics" strings. I think it's really important for the end-user to get a consistent look and fell in the whole LibO interface. Indeed, the feature found at File - Properties - Statistics and Tools -> Statistics are both the same. Both features (and name) are definitely linked together. If we update the first, this latter have to be renamed too.

My pool goes to "Statistics" because:
- in LibO 3.4 it was called like this;
- we have the same feature called like this in MSO : it could be confusing for the LibO newbie (Typical student reaction: I have to count the number of words I used for my homework e.g. writing exercises / redactions. I don't find the statistics feature like in Word. Pff LibO is crappy... I'm getting back to MSO.) --> It's the request for help, I'm sure we will have for the forthcoming version if we rename this small (but essential!) feature.
- French and other translators are continuing to call this feature "Statistics".

How do you view this?


Regards.

Ps: I'm on exam for now. I won't be back until I haven't finished these. Tomorrow C# .NET :-(
Stefan Knorr (Astron) Stefan Knorr (Astron)
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

Hi William,

> By my technical prerequisites, I could have done the required modification
> all by myself. But I still need some time to be more familiar with LibO code
> organization. For example, what does this hard-coded macro
> IMPL_EXTRA_BUTTON_WIDTH?

Sorry, if I was too impatient for you, but 3.5 hard UI freeze was
nearing, as you might know.

> And how to get an instant view of code modification I did? I've to run make
> -rs, which a bit slow. I can't stand waiting. (ccache is installed and work
> fine).

If you mean to ask whether we have some sort of graphical UI
preview/UI editor, then, as far as I know, that's not available. Would
be a great feature, though.


> 2. Michael : As you was insisting : I've updated the LibO 3.5 Release Notes
> with a great screenshot. :P

Neatest screenshot on the page :). Nice.


> 3. Concerning the "Statistics" strings. I think it's really important for
> the end-user to get a consistent look and fell in the whole LibO interface.
> Indeed, the feature found at File - Properties - Statistics and Tools ->
> Statistics are both the same. Both features (and name) are definitely linked
> together. If we update the first, this latter have to be renamed too.

Hm... No. That would be confusing, I think. What sounds like a better
plan would be to move File/Properties/Statistics into the word count
dialogue (or vice versa) and then using the term "Statistics". (I
believe we don't really need to have that functionality twice, I hope
you'll agree.)


> My pool goes to "Statistics" because:
> - in LibO 3.4 it was called like this;

Not in the English version, for the French version: yes, that at least
was the case (but I haven't checked in 3.5). Both Ooo/LibO and MSO
have been using the same terminology for years for this window, i. e.
in both there is a window called:
* English: "Word Count" [1]
* French: "Statistiques"

If that has changed now in the French version, please try to lobby the
French localiser(s).

Additionally, in MSO, there are both a "Word Count" and a "Readability
Statistics" window, the latter adds a bunch of things (that, at a
superficial glance, sound like a good idea to me, by the way).
Screenshots: [2].


> Ps: I'm on exam for now. I won't be back until I haven't finished these.
> Tomorrow C# .NET :-(

Best of luck to you.


Astron.


[1] See also Matt Pratt's original commit to make the word count
modeless which doesn't change the string "Word Count" at all:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=12402e2cfdacf9a77af390e51ce12a4a6025f286

[2] Word Count, Word 2007:
http://1.bp.blogspot.com/_JmsBa1ONht8/TOFUFo9w69I/AAAAAAAAAYI/-dWpmWaHGlk/s1600/WordCount_MSOffice2010.png
Readability Statistics, Word 2007:
http://images.brighthub.com/D4/5/D458EA6670C3D2F86A98EFAB66AE82E5CE630AE6_large.jpg
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice