[PATCH] FDO #40505 - UI: HYPHENATION Right/Left arrow key reversed (keyboard)

classic Classic list List threaded Threaded
4 messages Options
Niklas Johansson Niklas Johansson
Reply | Threaded
Open this post in threaded view
|

[PATCH] FDO #40505 - UI: HYPHENATION Right/Left arrow key reversed (keyboard)

Hi,

I did a small patch to fix
https://bugs.freedesktop.org/show_bug.cgi?id=40505

The patch fixes the issue with the reversed Right/Left arrow keys
without affecting
the Right/Left buttons in the dialog. It's a small fix were only to
lines of code is changed.

It's my first contribution to the source of LO so I hope I've done
everything correctly.
Please let me know otherwise.

Thanks,
Niklas Johansson

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0001-Fixed-for-bug-40505-UI-HYPHENATION-Right-Left-arrow-.patch (1K) Download Attachment
Noel Power-3 Noel Power-3
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] FDO #40505 - UI: HYPHENATION Right/Left arrow key reversed (keyboard)

On 17/11/11 12:09, Niklas Johansson wrote:

> Hi,
>
> I did a small patch to fix
> https://bugs.freedesktop.org/show_bug.cgi?id=40505
>
> The patch fixes the issue with the reversed Right/Left arrow keys
> without affecting
> the Right/Left buttons in the dialog. It's a small fix were only to
> lines of code is changed.
>
> It's my first contribution to the source of LO so I hope I've done
> everything correctly.
> Please let me know otherwise.
everything perfect, nice patch, commit is here
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c69c088a117857521efc6aaaa19bb53baee087ca 
and I also marked the bug as fixed.

thanks again,

Noel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan Holesovsky Jan Holesovsky
Reply | Threaded
Open this post in threaded view
|

[PUSHED] Re: [PATCH] FDO #40505 - UI: HYPHENATION Right/Left arrow key reversed (keyboard)

Hi Niklas,

On 2011-11-18 at 10:10 +0000, Noel Power wrote:

> > It's my first contribution to the source of LO so I hope I've done
> > everything correctly.
> > Please let me know otherwise.
>
> everything perfect, nice patch, commit is here
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=c69c088a117857521efc6aaaa19bb53baee087ca 
> and I also marked the bug as fixed.

Thank you very much for the patch, great! :-)  Please can you confirm
that it is under our preferred license combo, LGPLv3+ / MPL?  Ideally in
the form "This and all my further patches to LibreOffice are under
LGPLv3+ / MPL, unless I state otherwise." - or similar.

Thank you a lot,
Kendy

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Noel Power-3 Noel Power-3
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED] Re: [PATCH] FDO #40505 - UI: HYPHENATION Right/Left arrow key reversed (keyboard)

Hi
On 19/11/11 00:39, Jan Holesovsky wrote:
> Hi Niklas,
[...]
>
> Thank you very much for the patch, great! :-)  Please can you confirm
> that it is under our preferred license combo, LGPLv3+ / MPL?
it is :-), see https://bugs.freedesktop.org/show_bug.cgi?id=40505#c5
>   Ideally in
> the form "This and all my further patches to LibreOffice are under
> LGPLv3+ / MPL, unless I state otherwise." - or similar.
But of course such a 'going forward' statement that Kendy mentions is
even more convenient and helpful, would you provide such a statement
Niklas? If you intend posting more patches ( which we very much hope you
will do ) then filling out an entry in the table
http://wiki.documentfoundation.org/Development/Developers would be a
good idea too

thanks again,

Noel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice