[PATCH] fdo#50141: Word Count Characters (with spaces) incorrect with Numbering on

classic Classic list List threaded Threaded
2 messages Options
Muhammad Haggag Muhammad Haggag
Reply | Threaded
Open this post in threaded view
|

[PATCH] fdo#50141: Word Count Characters (with spaces) incorrect with Numbering on

= Bug =
https://bugs.freedesktop.org/show_bug.cgi?id=50141

= Patch =
https://bugs.freedesktop.org/attachment.cgi?id=62850

= Patch Review =
https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=50141&attachment=62850

= Changes =
There was a typo in the character counting code of text nodes. When a
numbered list is detected, the code attempts to add the character count
of the "item number" to the total count, but ends up overwriting it
instead (uses '=' instead of '+='). This resulted in the item number
strings to be the only ones counted in a numbered list.

Regards,
--Muhammad
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Stahl-2 Michael Stahl-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fdo#50141: Word Count Characters (with spaces) incorrect with Numbering on

On 09/06/12 23:57, Muhammad Haggag wrote:

> = Bug =
> https://bugs.freedesktop.org/show_bug.cgi?id=50141
>
> = Patch =
> https://bugs.freedesktop.org/attachment.cgi?id=62850
>
> = Patch Review =
> https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=50141&attachment=62850
>
> = Changes =
> There was a typo in the character counting code of text nodes. When a
> numbered list is detected, the code attempts to add the character count
> of the "item number" to the total count, but ends up overwriting it
> instead (uses '=' instead of '+='). This resulted in the item number
> strings to be the only ones counted in a numbered list.

interesting, that looks like a regression from
12db5315fca413ae66e88c4cd8212ee3b01667b7
"Follow UAX-29 and present user-perceived character counts".

thanks for the patch, pushed to master, libreoffice-3-6, libreoffice-3-5

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice