[PATCH]fdo#53002:Turkish Default Currency to be changed YTL to TL

classic Classic list List threaded Threaded
6 messages Options
Efe Gürkan YALAMAN Efe Gürkan YALAMAN
Reply | Threaded
Open this post in threaded view
|

[PATCH]fdo#53002:Turkish Default Currency to be changed YTL to TL

Hi,

The currency for Turkish was TRL TL since 2005. After that the currency was TRY YTL since 2009. Current currency is TRY TL.
I changed default currency to TRY TL for Turkish. There is two patches because I could not decide whether to delete TRY YTL.

There is also a new currency sign for Turkish Lira. The sign can be implemented later.

Should i do any other change and which patch is more appropriate?

For more details:
http://en.wikipedia.org/wiki/Currency_code
http://en.wikipedia.org/wiki/Turkish_lira

Sorry for my grammar mistakes.
Regards.

--
Efe Gürkan YALAMAN
http://about.me/efegurkan


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0001-Fix-for-default-currency-settings-TRY-YTL-exists.patch (1K) Download Attachment
0001-Fix-for-default-currency-TRY-YTL-is-gone.patch (1K) Download Attachment
Efe Gürkan YALAMAN Efe Gürkan YALAMAN
Reply | Threaded
Open this post in threaded view
|

[PATCH]fdo#53002:Turkish Default Currency to be changed YTL to TL

Did my email filtered or mail list doesn't send mail back to it's owner?

Regards.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED]fdo#53002:Turkish Default Currency to be changed YTL to TL

In reply to this post by Efe Gürkan YALAMAN
Hi Efe,

On Thursday, 2012-08-02 00:05:29 +0300, Efe Gürkan YALAMAN wrote:

> The currency for Turkish was TRL TL since 2005. After that the currency was
> TRY YTL since 2009. Current currency is TRY TL.
> I changed default currency to TRY TL for Turkish. There is two patches
> because I could not decide whether to delete TRY YTL.

Thanks for the patches.

The first where you added another currency entry goes into the right
direction, but there's an error

Error: CurrencySymbol "YTL" flagged as usedInCompatibleFormatCodes doesn't match "TL" determined from format codes.
Error: Currency: more than one currency flagged as usedInCompatibleFormatCodes.

The entry used in the format codes usually stays the same, the number
formatter exchanges symbols in the format codes, but since the older
symbol is now reused it would duplicate the list of formats. I fixed
that, and since the ISO 4217 code TRY actually stays the same and only
the currency symbol changes another attribute legacyOnly="true" is
needed to correctly load documents using the old currency symbol and not
offer it in the dialog otherwise. Using legacyOnly="true" on the old TL
entry and makeing the new one default prevents duplication of the
currency formats.

Much of weird stuff happens if some organizations decide to reuse
symbols ;-)

> There is also a new currency sign for Turkish Lira. The sign can be
> implemented later.

I would had preferred if we could had added it now, as we're on it
anyway and for changing the symbol again later we would have to
introduce yet another entry and declare the current as legacy, but the
new Unicode code point U+20BA assigned to the symbol isn't in yet and
won't be displayed properly by systems (it is some generic "₺" currency
symbol now) so we'll have to do that later, see also
https://en.wikipedia.org/wiki/Turkish_lira_sign

I commited your patch as d09b4e30d7e87f181fa3913e81c6d38c04a8f5f8

and my follow-up changes cb7c34f3bcd4df7a67f1a9d31b3bf849af4f79e4

(sorry, the fdo machine where cgit runs on is currently down, otherwise
I'd give you browsable URLs)


Btw, please configure your git to use a correct email address, in the
patch I changed <efe@efe-HP-Ubuntu.(none)> to <[hidden email]>

git config --global user.email [hidden email]

As a convention, if a patch fixes a bug we also mention fdo#... in the
commit summary to have a patch assigned to a bug, in this case
fdo#53002, I added that in the commit.

Last but not least, apparently we don't have your license statement on
file, https://wiki.documentfoundation.org/Development/Developers

Could you please send a mail to the mailing list with a blanket
statement that you contribute this and further patches under LGPLv3+ and
MPL 1.1 licenses?

Thanks
  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH]fdo#53002:Turkish Default Currency to be changed YTL to TL

In reply to this post by Efe Gürkan YALAMAN
Hi Efe,

On Thursday, 2012-08-02 13:35:54 +0300, Efe Gürkan YALAMAN wrote:

> Did my email filtered

Either that and maybe had to be moderated through ...

> or mail list doesn't send mail back to it's owner?

... also that is possible, depends on how you setup your mailing list
subscription in mailman where you can specify whether you want your own
mails been sent back to you or not.

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment
Efe Gürkan YALAMAN Efe Gürkan YALAMAN
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED]fdo#53002:Turkish Default Currency to be changed YTL to TL

In reply to this post by Eike Rathke-2
2012/8/2 Eike Rathke <[hidden email]>
Hi Efe,

On Thursday, 2012-08-02 00:05:29 +0300, Efe Gürkan YALAMAN wrote:

Thanks for the patches.

The first where you added another currency entry goes into the right
direction, but there's an error

Error: CurrencySymbol "YTL" flagged as usedInCompatibleFormatCodes doesn't match "TL" determined from format codes.
Error: Currency: more than one currency flagged as usedInCompatibleFormatCodes.

The entry used in the format codes usually stays the same, the number
formatter exchanges symbols in the format codes, but since the older
symbol is now reused it would duplicate the list of formats. I fixed
that, and since the ISO 4217 code TRY actually stays the same and only
the currency symbol changes another attribute legacyOnly="true" is
needed to correctly load documents using the old currency symbol and not
offer it in the dialog otherwise. Using legacyOnly="true" on the old TL
entry and makeing the new one default prevents duplication of the
currency formats.
 
That part is little bit challenging for me.
 
Much of weird stuff happens if some organizations decide to reuse
symbols ;-)

Yes i recognized it. :-)
 
> There is also a new currency sign for Turkish Lira. The sign can be
> implemented later.

I would had preferred if we could had added it now, as we're on it
anyway and for changing the symbol again later we would have to
introduce yet another entry and declare the current as legacy, but the
new Unicode code point U+20BA assigned to the symbol isn't in yet and
won't be displayed properly by systems (it is some generic "₺" currency
symbol now) so we'll have to do that later, see also
https://en.wikipedia.org/wiki/Turkish_lira_sign

By the way new currency sign is just a character inside of a font.
http://www.tcmb.gov.tr/yeni/eng/
 

I commited your patch as d09b4e30d7e87f181fa3913e81c6d38c04a8f5f8

and my follow-up changes cb7c34f3bcd4df7a67f1a9d31b3bf849af4f79e4

(sorry, the fdo machine where cgit runs on is currently down, otherwise
I'd give you browsable URLs)

Thank you.


Btw, please configure your git to use a correct email address, in the
patch I changed <efe@efe-HP-Ubuntu.(none)> to <[hidden email]>

git config --global user.email [hidden email]

I recognized after i sending patches. sorry.


As a convention, if a patch fixes a bug we also mention fdo#... in the
commit summary to have a patch assigned to a bug, in this case
fdo#53002, I added that in the commit.
 
Last but not least, apparently we don't have your license statement on
file, https://wiki.documentfoundation.org/Development/Developers

Could you please send a mail to the mailing list with a blanket
statement that you contribute this and further patches under LGPLv3+ and
MPL 1.1 licenses?

I will.
 

Thanks
 
It was challenging for me as a 1. grade computer engineering student. I learned a lot from you.

Thank you again.

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD



--
Efe Gürkan YALAMAN
http://about.me/efegurkan


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED]fdo#53002:Turkish Default Currency to be changed YTL to TL

Hi Efe,

On Thursday, 2012-08-02 23:43:51 +0300, Efe Gürkan YALAMAN wrote:

> > [... much stuff about legacyOnly="true" ...]
>
> That part is little bit challenging for me.

I can imagine.. long story short: the number formatter generates
currency format codes taking the format codes from the locale data and
inserting the CurrenySymbol from each Currency element in turn. The
legacyOnly="true" attribute tells the formatter to not generate formats
for that Currency element. A format code for such a Currency is only
displayed if a document is loaded that uses it. Not having
legacyOnly="true" on the old TRL/TL Currency made the formatter display
a duplicated list with TL formats, along with TRY/TL.

Maybe clearer, if not then just forget it ;-)


> > new Unicode code point U+20BA assigned to the symbol isn't in yet and
> > won't be displayed properly by systems (it is some generic "₺" currency
> > symbol now) so we'll have to do that later, see also
> > https://en.wikipedia.org/wiki/Turkish_lira_sign
>
> By the way new currency sign is just a character inside of a font.
> http://www.tcmb.gov.tr/yeni/eng/

Sure, but so far existing fonts do not have that glyph and display
whatever they have there, e.g. what you see here for U+20BA: ₺

Even on http://www.tcmb.gov.tr/yeni/iletisimgm/TurkishLira.php the sign
in the text is displayed only as a graphical image, not a font glyph,
http://www.tcmb.gov.tr/yeni/iletisimgm/TLSimge/TLSimge.jpg


> > Could you please send a mail to the mailing list with a blanket
> > statement that you contribute this and further patches under LGPLv3+ and
> > MPL 1.1 licenses?
> >
>
> I will.

Thanks.

> It was challenging for me as a 1. grade computer engineering student. I
> learned a lot from you.
>
> Thank you again.

Well, thank you :-)

  Eike


--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment