[PATCH] fdo#64455 Handle unknown color in color line toolbox

classic Classic list List threaded Threaded
6 messages Options
Laurent BP Laurent BP
Reply | Threaded
Open this post in threaded view
|

[PATCH] fdo#64455 Handle unknown color in color line toolbox

Hi,

Following Ivan suggestion
http://nabble.documentfoundation.org/PATCH-fdo-64455-Add-default-line-color-to-standard-soc-tt4071038.html

here is my proposition to have the color line toolbox of "Line and filling" toolbar be able to handle unknown color, like the color filling does.
0001-fdo-64455-Handle-unknown-color-in-color-line.patch
LibreOffice 5.3.5
Ivan Timofeev Ivan Timofeev
Reply | Threaded
Open this post in threaded view
|

[PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox

Hi Laurent,

Thanks, I fixed the indentation and pushed it. Sadly I forgot to amend
the author while pushing to 4-1 and stole your commit :( sorry for that.

Regards,
Ivan
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Laurent BP Laurent BP
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox

Hi Ivan,

Thanks for this good news. I was wondering if I could use the same code as for Fill toolbox, but I did not understand all the links between classes. So I duplicate the code.

Moreover, I realized afterwards it may be better to use OUString than String? I saw many patches proposing to replace String by OUString.

Laurent BP
PS Do not worry for the authoring of this patch. ;)
LibreOffice 5.3.5
Ivan Timofeev Ivan Timofeev
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox

On 17.09.2013 17:37, Laurent BP [via Document Foundation Mail Archive]
wrote:
> Moreover, I realized afterwards it may be better to use OUString than
> String? I saw many patches proposing to replace String by OUString.

Yes, OUString should be used in new code instead of String. You can help
with this long-standing conversion btw. :)

Regards,
Ivan
Laurent BP Laurent BP
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox




>________________________________
> De : Ivan Timofeev [via Document Foundation Mail Archive] <[hidden email]>
>À : Laurent BP <[hidden email]>
>Envoyé le : Mardi 17 septembre 2013 17h08
>Objet : Re: [PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox
>
>
>
>On 17.09.2013 17:37, Laurent BP [via Document Foundation Mail Archive]
>wrote:
>> Moreover, I realized afterwards it may be better to use OUString than
>> String? I saw many patches proposing to replace String by OUString.
>
>Yes, OUString should be used in new code instead of String. You can help
>with this long-standing conversion btw. :) 
I will have a look at it tonight. And if I change also for Fill toolbox, I will contribute to this long-standing conversion ;)

Laurent BP

LibreOffice 5.3.5
Laurent BP Laurent BP
Reply | Threaded
Open this post in threaded view
|

[PATCH] Convert String to OUString in itemwin.cxx

Hi,

Here is a new patch to correct my previous one and change String to OUString in svx/source/tbxctrls/itemwin.cxx
0001-String-to-OUString-in-itemwin.cxx.patch

Regards

Laurent BP
LibreOffice 5.3.5