[PATCH] proposed patch for fdo56549 CRASH in menu 'Format → Autocorrect → Apply and Edit Changes'

classic Classic list List threaded Threaded
2 messages Options
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

[PATCH] proposed patch for fdo56549 CRASH in menu 'Format → Autocorrect → Apply and Edit Changes'

Hello,

I propose a patch for fdo#56549 (see https://bugs.freedesktop.org/show_bug.cgi?id=56549):
https://bugs.freedesktop.org/attachment.cgi?id=70538

I think (not sure at all) that the problem was that at the end _GetAutoFmtNameLst(), destructor ~ImpAutoFmtNameListLoader for aTmp is called and must destroy (i don't know how) pLst vector
     239 void ShellResource::_GetAutoFmtNameLst() const
    240 {
    241     std::vector<String>* pLst(pAutoFmtNameLst);
    242     pLst = new std::vector<String>;
    243     pLst->reserve(STR_AUTOFMTREDL_END);
    244     ImpAutoFmtNameListLoader aTmp( *pLst );
    245 }
see http://opengrok.libreoffice.org/xref/core/sw/source/ui/utlui/initui.cxx#244

Again, I'm not sure at all of this.
So I tried to find a way to avoid ImpAutoFmtNameListLoader. I'm waiting confirmation that behaviour is ok but for the moment,  I can say that, with this patch, it doesn't crash and the autocorrect seems to work.

Could someone take a look?

Julien
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH][RESOLVED] proposed patch for fdo56549 CRASH in menu 'Format → Autocorrect → Apply and Edit Changes'

On Sun, 2012-11-25 at 05:40 -0800, julien2412 wrote:
> Hello,
>
> I propose a patch for fdo#56549 (see
> https://bugs.freedesktop.org/show_bug.cgi?id=56549):
> https://bugs.freedesktop.org/attachment.cgi?id=70538

Just marking this thread as resolved with
32c26ffb1f7585318a11f684a9886b58cea5b307

C.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice