Questions about Bug 33773 (chart)

classic Classic list List threaded Threaded
6 messages Options
Rafael Dominguez Rafael Dominguez
Reply | Threaded
Open this post in threaded view
|

Questions about Bug 33773 (chart)

Hello, i been working on bug 33773 for a few days already,  and i got to the point where i can display and manipulate
X Error bars, but theres a few issues i dont know how to proceed.

1.- How i should handle export/import??? It seems ODF 1.2 and below, only support working with Y error bars,
XLS import/export code, already supports having both bars. Tested it by exporting to xls and then importing it.

Is there any way we can add features not implemented in the ODF spec???

2.- What is the code inside chart2/source/controller/charapiwrapper for??? Backward compability with chart API???

3.- Should i push my code to a feature branch??? So other people can review my work??

Any suggestion or code pointers is also welcome!

Thanks all

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Markus Mohrhard Markus Mohrhard
Reply | Threaded
Open this post in threaded view
|

Re: Questions about Bug 33773 (chart)

Hello Rafael,

2012/3/21 Rafael Dominguez <[hidden email]>:
> Hello, i been working on bug 33773 for a few days already,  and i got to the
> point where i can display and manipulate
> X Error bars, but theres a few issues i dont know how to proceed.

Great. Sounds interesting.

>
> 1.- How i should handle export/import??? It seems ODF 1.2 and below, only
> support working with Y error bars,
> XLS import/export code, already supports having both bars. Tested it by
> exporting to xls and then importing it.
>
> Is there any way we can add features not implemented in the ODF spec???

I think to be conform with the spec we need to export it into an own
namespace and maybe propose it to OASIS for 1.3.

>
> 2.- What is the code inside chart2/source/controller/charapiwrapper for???
> Backward compability with chart API???

Yes. Our current chart code is a mixture of chart and chart2 api interfaces.

>
> 3.- Should i push my code to a feature branch??? So other people can review
> my work??

This sounds like a good idea for such a complex feature. It makes it
easier for us to help you with upcoming problems.

Regards,
Markus
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Rafael Dominguez Rafael Dominguez
Reply | Threaded
Open this post in threaded view
|

Re: Questions about Bug 33773 (chart)



On Tue, Mar 20, 2012 at 10:45 PM, Markus Mohrhard <[hidden email]> wrote:
Hello Rafael,

2012/3/21 Rafael Dominguez <[hidden email]>:
> Hello, i been working on bug 33773 for a few days already,  and i got to the
> point where i can display and manipulate
> X Error bars, but theres a few issues i dont know how to proceed.

Great. Sounds interesting.

>
> 1.- How i should handle export/import??? It seems ODF 1.2 and below, only
> support working with Y error bars,
> XLS import/export code, already supports having both bars. Tested it by
> exporting to xls and then importing it.
>
> Is there any way we can add features not implemented in the ODF spec???

I think to be conform with the spec we need to export it into an own
namespace and maybe propose it to OASIS for 1.3.

Any pointers on how to proceed with this??? Export code seems to be scattered, but i can concentrate
on calc since its the most critical area and then proceed with the rest.


>
> 2.- What is the code inside chart2/source/controller/charapiwrapper for???
> Backward compability with chart API???

Yes. Our current chart code is a mixture of chart and chart2 api interfaces.

>
> 3.- Should i push my code to a feature branch??? So other people can review
> my work??

This sounds like a good idea for such a complex feature. It makes it
easier for us to help you with upcoming problems.

Pushed to feature/chart_errorbars branch.
 

Regards,
Markus


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Markus Mohrhard Markus Mohrhard
Reply | Threaded
Open this post in threaded view
|

Re: Questions about Bug 33773 (chart)

Hello Rafael,

>> >
>> > 1.- How i should handle export/import??? It seems ODF 1.2 and below,
>> > only
>> > support working with Y error bars,
>> > XLS import/export code, already supports having both bars. Tested it by
>> > exporting to xls and then importing it.
>> >
>> > Is there any way we can add features not implemented in the ODF spec???
>>
>> I think to be conform with the spec we need to export it into an own
>> namespace and maybe propose it to OASIS for 1.3.
>
>
> Any pointers on how to proceed with this??? Export code seems to be
> scattered, but i can concentrate
> on calc since its the most critical area and then proceed with the rest.

Ok. Chart export code is shared between all applications.

You'll find the source code in xmloff/source/chart. What we need to do
to follow ODF is adding the relevant entries to
http://opengrok.libreoffice.org/xref/core/xmloff/source/chart/PropertyMap.hxx
and write the export code similar to the y error bar export code.

I hope this helps you a bit more.

Thorsten, is there a preferable namespace for our custom
elements/properties? Something like libo:?

>
> Pushed to feature/chart_errorbars branch.
>

I saw it and the code looks really great. I will test build it and
have a quick look through the code and have a quick test but IMHO it
is ready to hit master even without the ODF import/export.

It would be great if you could add some test documents for your new
feature to http://cgit.freedesktop.org/libreoffice/contrib/test-files/
that will allow us to check that we did not introduce regressions in
the future and as soon as I finally get the chart test working add
them to in-build tests.

Thanks a lot for this great work. Do you have already have an idea
what you want to hack next? Chart2 needs a lot of love and if you want
we can find some more tasks there.

Regards,
Markus
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Thorsten Behrens-4 Thorsten Behrens-4
Reply | Threaded
Open this post in threaded view
|

Re: Questions about Bug 33773 (chart)

Markus Mohrhard wrote:
> Thorsten, is there a preferable namespace for our custom
> elements/properties? Something like libo:?
>
Hi there,

if you implement ODF extensions, please also update

 http://wiki.documentfoundation.org/Development/ODF_Implementer_Notes

with as much information as possible.

As for the namespace, we have a healthy mixture there, what I
generally like better than individual product names is something
like 'calcext', 'chartext', 'msointerop' etc -

Also note that the namespace prefix is ~arbitrary, every odf
producer can pick whatever it likes - the namespace urn is what
counts, e.g. something like

 urn:org:documentfoundation:names:experimental:<my_fancy_subsystem>:xmlns:<prefix>:1.0

looks appropriate - or, if you want to publish some actual content
(RDDL or whatnot) about your new namespace, an actual url like

 http://xml-names.documentfoundation.org/bleh/blah

would work (personally, I'd go with the former, though).

HTH,

--

Thorsten Behrens

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment
Markus Mohrhard Markus Mohrhard
Reply | Threaded
Open this post in threaded view
|

Re: Questions about Bug 33773 (chart)

In reply to this post by Markus Mohrhard
Hello Rafael,

>
> I saw it and the code looks really great. I will test build it and
> have a quick look through the code and have a quick test but IMHO it
> is ready to hit master even without the ODF import/export.
>
> It would be great if you could add some test documents for your new
> feature to http://cgit.freedesktop.org/libreoffice/contrib/test-files/
> that will allow us to check that we did not introduce regressions in
> the future and as soon as I finally get the chart test working add
> them to in-build tests.
>
> Thanks a lot for this great work. Do you have already have an idea
> what you want to hack next? Chart2 needs a lot of love and if you want
> we can find some more tasks there.
>

And merged it into master. Had a quick review and the code looks
really good and tested it.

Thanks a lot for this great work. Could you please add this to
http://wiki.documentfoundation.org/ReleaseNotes/3.6?

Regards,
Markus
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice