[REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

classic Classic list List threaded Threaded
4 messages Options
Korrawit Pruegsanusak Korrawit Pruegsanusak
Reply | Threaded
Open this post in threaded view
|

[REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

Hello all,

First, sorry for not using gerrit. I've tried it but got "invalid
author" error as I tried to push Muthu's patch.

The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
on master, so I propose this review for the inclusion in both -3-6 and
-3-5 branches.

Branch -3-5 didn't apply cleanly, because conflict by getLength() to
isEmpty() change, so patch attached, for both branches. I also deleted
code-indent change, which is already in master, in
oox/source/ppt/pptshapegroupcontext.cxx.

Last, sorry to say this, but I didn't have time to test if it could be
build or even fix the problem. (I didn't test in both branches, but
tested in master that this really fixes the problem, please see
comment 11 in fdo bugzilla).

Thanks :-)
Best Regards,
--
Korrawit Pruegsanusak

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0001-n-759210-Certain-smartart-drawings-weren-t-imported-3-5.patch (7K) Download Attachment
0001-n-759210-Certain-smartart-drawings-weren-t-imported-3-6.patch (7K) Download Attachment
Korrawit Pruegsanusak Korrawit Pruegsanusak
Reply | Threaded
Open this post in threaded view
|

Re: [REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

Hello all,

On Tue, Jul 10, 2012 at 8:59 PM, Korrawit Pruegsanusak
<[hidden email]> wrote:
> The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
> on master, so I propose this review for the inclusion in both -3-6 and
> -3-5 branches.
[snip]
> Last, sorry to say this, but I didn't have time to test if it could be
> build or even fix the problem. (I didn't test in both branches, but
> tested in master that this really fixes the problem, please see
> comment 11 in fdo bugzilla).

I've tested a build in -3-6 branch, with the attached patch on top of
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=0054c76b0f3d5bdbaef73a696ce3cf930be9c16b
and it really fix fdo#50907.

I didn't test with other pptx files, nor in -3-5 branch.

Best Regards,
--
Korrawit Pruegsanusak
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Korrawit Pruegsanusak Korrawit Pruegsanusak
Reply | Threaded
Open this post in threaded view
|

Re: [REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

Hello all,

Bumping this one, would be nice to get it backported :-)
Please find patches attached in the first mail of this thread.

Thanks very much!
Best Regards,

On Mon, Jul 16, 2012 at 12:08 PM, Korrawit Pruegsanusak
<[hidden email]> wrote:

> Hello all,
>
> On Tue, Jul 10, 2012 at 8:59 PM, Korrawit Pruegsanusak
> <[hidden email]> wrote:
>> The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
>> on master, so I propose this review for the inclusion in both -3-6 and
>> -3-5 branches.
> [snip]
>> Last, sorry to say this, but I didn't have time to test if it could be
>> build or even fix the problem. (I didn't test in both branches, but
>> tested in master that this really fixes the problem, please see
>> comment 11 in fdo bugzilla).
>
> I've tested a build in -3-6 branch, with the attached patch on top of
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=0054c76b0f3d5bdbaef73a696ce3cf930be9c16b
> and it really fix fdo#50907.
>
> I didn't test with other pptx files, nor in -3-5 branch.


--
Korrawit Pruegsanusak
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

In reply to this post by Korrawit Pruegsanusak
Hi Korrawit,

it seems that we have somehow missed this request.

Korrawit Pruegsanusak píše v Po 16. 07. 2012 v 12:08 +0700:

> Hello all,
>
> On Tue, Jul 10, 2012 at 8:59 PM, Korrawit Pruegsanusak
> <[hidden email]> wrote:
> > The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
> > on master, so I propose this review for the inclusion in both -3-6 and
> > -3-5 branches.
> [snip]
> > Last, sorry to say this, but I didn't have time to test if it could be
> > build or even fix the problem. (I didn't test in both branches, but
> > tested in master that this really fixes the problem, please see
> > comment 11 in fdo bugzilla).
>
> I've tested a build in -3-6 branch, with the attached patch on top of
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=0054c76b0f3d5bdbaef73a696ce3cf930be9c16b
> and it really fix fdo#50907.

Yup, it worked and looked fine, so pushed to 3-6, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=dc29a85982a4b54657be3f448dd8d37d2144a020

> I didn't test with other pptx files, nor in -3-5 branch.

It caused some crashes there. After discussion with Muthu I added one
more fix and pushed it there as well, see:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=0a7453043f35a9a49f0482168b48d378a099a238
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=f3826fda8ac280d20f70ae273f20a438d6040453


Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice