[REVIEW] fdo#33773 - Enable exporting X errorbars in odf

classic Classic list List threaded Threaded
3 messages Options
Rafael Dominguez Rafael Dominguez
Reply | Threaded
Open this post in threaded view
|

[REVIEW] fdo#33773 - Enable exporting X errorbars in odf

This patches add functionality to export X errorbars in ODF files > =1.2, im not sure if its ok to include 1.2 version too or just export when having extension enabled.
To set the bar direction im just using the attribute dimension in the chart:error-indicator element like its on 1.2, so it should be backward compatible.

Thanks

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0003-Move-exporting-chart-errorbars-code-to-its-own-metho.patch (13K) Download Attachment
0004-Export-chart-X-Y-errorbars.patch (10K) Download Attachment
Markus Mohrhard Markus Mohrhard
Reply | Threaded
Open this post in threaded view
|

Re: [REVIEW][PUSHED] fdo#33773 - Enable exporting X errorbars in odf

2012/4/4 Rafael Dominguez <[hidden email]>:
> This patches add functionality to export X errorbars in ODF files > =1.2, im
> not sure if its ok to include 1.2 version too or just export when having
> extension enabled.
> To set the bar direction im just using the attribute dimension in the
> chart:error-indicator element like its on 1.2, so it should be backward
> compatible.
>

Looks correct to me. Thanks a lot for this great work.

So just two small remaining tasks. Could you please add this great new
feature to http://wiki.documentfoundation.org/ReleaseNotes/3.6 and
could you add a test document for this feature to fdo#47667?

Regards,
Markus
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Rafael Dominguez Rafael Dominguez
Reply | Threaded
Open this post in threaded view
|

Re: [REVIEW][PUSHED] fdo#33773 - Enable exporting X errorbars in odf



On Wed, Apr 11, 2012 at 11:26 AM, Markus Mohrhard <[hidden email]> wrote:
2012/4/4 Rafael Dominguez <[hidden email]>:
> This patches add functionality to export X errorbars in ODF files > =1.2, im
> not sure if its ok to include 1.2 version too or just export when having
> extension enabled.
> To set the bar direction im just using the attribute dimension in the
> chart:error-indicator element like its on 1.2, so it should be backward
> compatible.
>

Looks correct to me. Thanks a lot for this great work.

So just two small remaining tasks. Could you please add this great new
feature to http://wiki.documentfoundation.org/ReleaseNotes/3.6 and
could you add a test document for this feature to fdo#47667?

Regards,
Markus

ill do them after i finish exporting and importing functionality. Thanks for reviewing!


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice