REVIEW for fix#37211

classic Classic list List threaded Threaded
7 messages Options
Noel Power Noel Power
Reply | Threaded
Open this post in threaded view
|

REVIEW for fix#37211

Hi,

following patch fixes regressions reported in
https://bugs.freedesktop.org/show_bug.cgi?id=37211 &
https://bugs.freedesktop.org/show_bug.cgi?id=37170

https://bugs.freedesktop.org/attachment.cgi?id=46831

it would be great to get the 1 review for libreoffice-3-4  ( not
critical so no point pushing for the release branch I think )

thanks,

Noel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Clio-2 Clio-2
Reply | Threaded
Open this post in threaded view
|

Re: REVIEW for fix#37211

17.05.2011 12:47, Noel Power пишет:

> ( not critical
> so no point pushing for the release branch I think )
>
If it is not fixed in 3.4.0, you can't Select All neither with the menu
nor with Ctrl A. And Delete key not working would be very annoing too.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Noel Power Noel Power
Reply | Threaded
Open this post in threaded view
|

Re: REVIEW for fix#37211

On 17/05/11 20:13, Clio wrote:
> 17.05.2011 12:47, Noel Power пишет:
>
>> ( not critical
>> so no point pushing for the release branch I think )
>>
> If it is not fixed in 3.4.0, you can't Select All neither with the menu
Select All from the menu has been broken forever, see
http://openoffice.org/bugzilla/show_bug.cgi?id=5048 (  about to
celebrate it's 7th birthday  )
> nor with Ctrl A.
you can temporarily use cntrl-shift-A  which is an undocumented
hardcoded accelerator that this patch will remove
> And Delete key not working would be very annoing too.
I don't believe that not being able to use the delete key is a major
impediment, you can always use backspace.
In anycase this should be fixed at the latest in 3.4.1, if we get the
right amount of reviewers it will appear in 3.4.0.

Noel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan Holesovsky Jan Holesovsky
Reply | Threaded
Open this post in threaded view
|

[PUSHED] Re: REVIEW for fix#37211

In reply to this post by Noel Power
Hi Noel,

On 2011-05-17 at 17:47 +0100, Noel Power wrote:

> following patch fixes regressions reported in
> https://bugs.freedesktop.org/show_bug.cgi?id=37211 &
> https://bugs.freedesktop.org/show_bug.cgi?id=37170
>
> https://bugs.freedesktop.org/attachment.cgi?id=46831
>
> it would be great to get the 1 review for libreoffice-3-4  ( not
> critical so no point pushing for the release branch I think )

Thank you for that, reviewed & pushed :-)

Regards,
Kendy

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Clio-2 Clio-2
Reply | Threaded
Open this post in threaded view
|

Re: REVIEW for fix#37211

In reply to this post by Noel Power
18.05.2011 04:40, Noel Power пишет:

> In anycase this should be fixed at the latest in 3.4.1, if we get the
> right amount of reviewers it will appear in 3.4.0.
>

With libreoffice-3.4.0.1 branch + Linux I tested this patch and it seems
to be OK: Del key works fine and also i#50481# (A short cut Ctrl-A
works, but Edit - Select All is disable.
http://openoffice.org/bugzilla/show_bug.cgi?id=50481 (fdo
https://bugs.freedesktop.org/show_bug.cgi?id=36832) seems to be resolved
too.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Clio-2 Clio-2
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED] Re: REVIEW for fix#37211

In reply to this post by Jan Holesovsky
18.05.2011 05:24, Jan Holesovsky пишет:

> Hi Noel,
>
> On 2011-05-17 at 17:47 +0100, Noel Power wrote:
>
>> following patch fixes regressions reported in
>> https://bugs.freedesktop.org/show_bug.cgi?id=37211&
>> https://bugs.freedesktop.org/show_bug.cgi?id=37170
>>
>> https://bugs.freedesktop.org/attachment.cgi?id=46831
>>
>> it would be great to get the 1 review for libreoffice-3-4  ( not
>> critical so no point pushing for the release branch I think )
>
> Thank you for that, reviewed&  pushed :-)
>
> Regards,
> Kendy
> .
>
Please, can anyone make third review to this patch (if my review counts)
and push it to libreoffice-3-4-0 ?
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Thorsten Behrens Thorsten Behrens
Reply | Threaded
Open this post in threaded view
|

Re: [PUSHED] Re: REVIEW for fix#37211

Clio wrote:
> >>it would be great to get the 1 review for libreoffice-3-4  ( not
> >>critical so no point pushing for the release branch I think )
> >
> Please, can anyone make third review to this patch (if my review
> counts) and push it to libreoffice-3-4-0 ?
>
Hi Clio,

that branch is effectively closed, for anything not regarded a
showstopper. The fix will be in 3.4.1 though.

Cheers,

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment