Re: A research study on abandoned code reviews

classic Classic list List threaded Threaded
3 messages Options
jan iversen jan iversen
Reply | Threaded
Open this post in threaded view
|

Re: A research study on abandoned code reviews

Hi

Copying our mailing list, to make the answer publicly available.

Sounds like an interesting topic, but looking at the one you asked me about it seems to me, you look at the abandoned ones only in a statistical sense, that will not do. I am actually curious, why do you look at abandoned patches, the right question (at least to me) is “why do some patches not get merged”, for LibreOffice the result is the same, but for other projects it is very different.

33697 was submitted and abandoned by myself, because it had some problems…you will see a lot of people submit patches, to get them tested on our build boxes, and if there is a problem they either submit a second patch set or (as in my case) abandon the patch and submit a new one.

I trust you are also aware that TDF (in contrary to most other foundations) actively monitor gerrit. Patches who are untouched for 4 weeks, get a “polite ping”, and 4 weeks later still untouched gets abandoned. This procedure gives a lot more abandoned patches compared to other projects.

If you speak generally you need to look more carefully at the reasons.

1) Submitter abandons patch. This is quite natural as described above.

2) People with committer status, typically submit a patch and forget it, so the system catches it and they typically abandon it, when they see the “polite ping”.

3) New people submit a patch (some without having compiled the code) receive a review and decide not to continue. This is only true for first time patches.

4) New people do a good job of making their patch work, but get review comments e.g. due to the user experience not being correct, and stop working

Again compared to other projects, we ensure that all patches get reviewed, so no patch is abandoned due to lack of review (something I see happening in another Foundation I work with).

Have fun with your study, and please share the outcome on our dev list, and I think it will be interesting reading.

rgds
jan I.


On 10 Mar 2017, at 07:00, [hidden email] wrote:

Dear jan, 

Sorry to bother you!

I am a Ph.D student in Zhejiang University, China. Currently, we are doing a research study on identifying root causes of abandoned code reviews. As we noticed, code reviews are abandoned for various reasons, e.g., build failed, wrong branch, duplicate patch, and so on. 

Since you are an expert in libreoffice, and I'm writing to ask you the reason why the following code review was abandoned (https://gerrit.libreoffice.org/#/c/33697/). Also, it would be great if you can tell us some more reasons why a code review is abandoned:-) I would be really grateful if you could reply me.

Please kindly advice.

Thank you very much for your help and happy holidays!

Yours sincerely,

Qingye Wang


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Tor Lillqvist-2 Tor Lillqvist-2
Reply | Threaded
Open this post in threaded view
|

Re: A research study on abandoned code reviews

Also, please note that the exactly same machine-generated email was sent to every committer who had abandoned a gerrit patch. Asking for information that would in many cases have been readily available in the comments in the patch, or in the abandon message itself. Basically the "PhD" student is asking us to do his/her work.

There is a word for machine-generated email sent to lots of people who did not ask for it, it's on the top of my tongue, starts with s, I think?

Happy Holidays (?)! (Perhaps the anniversary of the February Revolution? (Which took place 100 years ago, in March in the Gregorian calendar))

--tml

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jiri Danek Jiri Danek
Reply | Threaded
Open this post in threaded view
|

Re: A research study on abandoned code reviews

Yeah, the greeting caught my attention as well ;)

On Sat, Mar 11, 2017 at 9:28 AM, Tor Lillqvist <[hidden email]> wrote:
Happy Holidays (?)! (Perhaps the anniversary of the February Revolution? (Which took place 100 years ago, in March in the Gregorian calendar))

Unlikely. As far as I know*, China was never that friendly with the SSSR to celebrate their internal coups. It was more like deeply suspicious of them.

Could be the New Year (January/February) or International Woman's Day (which is supposedly a half-day holiday for all women in China, at least the Internet says so)

*) from two books (one was fiction with historical overtones) and http://www.smithsonianmag.com/history/khrushchev-in-water-wings-on-mao-humiliation-and-the-sino-soviet-split-80852370/
--
Jiří Daněk

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice