Re: [Libreoffice-commits] .: basic/inc basic/source

classic Classic list List threaded Threaded
2 messages Options
Kevin Hunter Kevin Hunter
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] .: basic/inc basic/source

At 7:19am -0500 Tue, 15 Nov 2011, Fridrich Štrba wrote:

> New commits:
> commit 1f2d0c83d07b2c877722069c0075ba35860a0400
> Author: Fridrich Štrba
> Date:   Tue Nov 15 13:19:24 2011 +0100
>
>      Put back a method needed by Windows and reformat a bit
>
> diff --git a/basic/inc/basic/sbxvar.hxx b/basic/inc/basic/sbxvar.hxx
> index 485c33e..08e8002 100644
> --- a/basic/inc/basic/sbxvar.hxx
> +++ b/basic/inc/basic/sbxvar.hxx
> @@ -212,6 +212,7 @@ public:
>
>               // Special methods
>       sal_Bool PutDecimal( com::sun::star::bridge::oleautomation::Decimal&  rAutomationDec );
> +    sal_Bool PutDecimal( SbxDecimal* pDecimal ); // This function is needed for Windows build, don't remove
>       sal_Bool fillAutomationDecimal( com::sun::star::bridge::oleautomation::Decimal&  rAutomationDec );

Naive question: if it's only needed for Windows, is this not a place for
an #ifdef ?

Kevin

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Fridrich Strba-4 Fridrich Strba-4
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] .: basic/inc basic/source

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Maybe it is. As much as some other methods related to it. But as a
matter of fact, we simply need a PutDecimal method that can take the
result of GetDecimal :) So, either we ifdef them both, or none :)

Cheers

F.

On 15/11/11 15:36, Kevin Hunter wrote:

> At 7:19am -0500 Tue, 15 Nov 2011, Fridrich Štrba wrote:
>> New commits: commit 1f2d0c83d07b2c877722069c0075ba35860a0400
>> Author: Fridrich Štrba Date:   Tue Nov 15 13:19:24 2011 +0100
>>
>> Put back a method needed by Windows and reformat a bit
>>
>> diff --git a/basic/inc/basic/sbxvar.hxx
>> b/basic/inc/basic/sbxvar.hxx index 485c33e..08e8002 100644 ---
>> a/basic/inc/basic/sbxvar.hxx +++ b/basic/inc/basic/sbxvar.hxx @@
>> -212,6 +212,7 @@ public:
>>
>> // Special methods sal_Bool PutDecimal(
>> com::sun::star::bridge::oleautomation::Decimal&  rAutomationDec
>> ); +    sal_Bool PutDecimal( SbxDecimal* pDecimal ); // This
>> function is needed for Windows build, don't remove sal_Bool
>> fillAutomationDecimal(
>> com::sun::star::bridge::oleautomation::Decimal&  rAutomationDec
>> );
>
> Naive question: if it's only needed for Windows, is this not a
> place for an #ifdef ?
>
> Kevin
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7Cev8ACgkQu9a1imXPdA/KVQCeKIAv2aaCQuv5pXU58hQkwi1p
o+sAn1mmUlbWArb0gVSpgZFgEi815tPe
=Z/YT
-----END PGP SIGNATURE-----
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice