Re: [Libreoffice-commits] core.git: avmedia/Library_avmediagst.mk avmedia/source vcl/qt5

classic Classic list List threaded Threaded
4 messages Options
Rene Engelhard Rene Engelhard
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: avmedia/Library_avmediagst.mk avmedia/source vcl/qt5

Hi,

On Sun, Jun 09, 2019 at 03:30:12AM +0000, Michael Weghorn (via logerrit) wrote:

> diff --git a/avmedia/Library_avmediagst.mk b/avmedia/Library_avmediagst.mk
> index cd651c82e60b..027123911e87 100644
> --- a/avmedia/Library_avmediagst.mk
> +++ b/avmedia/Library_avmediagst.mk
> @@ -31,6 +31,16 @@ $(eval $(call gb_Library_add_libs,avmediagst,\
>  ))
>  endif
>  
> +ifneq ($(ENABLE_QT5),)
> +$(eval $(call gb_Library_add_cxxflags,avmediagst,\
> +    $$(QT5_CFLAGS) \
> +))
> +
> +$(eval $(call gb_Library_add_libs,avmediagst,\
> +    $(QT5_LIBS) \
> +))
> +endif
> +
>  $(eval $(call gb_Library_use_external,avmediagst,boost_headers))
>  
>  $(eval $(call gb_Library_use_sdk_api,avmediagst))
[...]
> +#if ENABLE_QT5
> +                    // try to use qwidget5videosink for qt5 on Wayland, which requires the Qt5 packages for QtGStreamer to be installed
> +                    if (aToolkit == "qt5" && aPlatform == "wayland")
> +                    {
[...]

Thought of this a few days and I don't like this. This would make the
whole office (well, the package where the gstreamer thingy is in)
dependent on qt5. (Yes, I know it's already the case for gtk3, but that
imho is not a that big issue.)

I could hack around it but that doesn't scale
- needs 3 builds of avmedia (gtk3, qt5, neither)
- would need dpkg-divert and this effectively means you cannot coinstall
  the -gtk3 and -qt5 plugin packages (and thus not even -gtk3 and
  -kde5).

Can't the qt5 (and gtk3) libraries not dynamically loaded in some way?

Regards,

Rene
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan-Marek Glogowski Jan-Marek Glogowski
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: avmedia/Library_avmediagst.mk avmedia/source vcl/qt5

Am 10.06.19 um 12:21 schrieb Rene Engelhard:
[... avmedia now depending on Gtk3 and Qt5]

> Thought of this a few days and I don't like this. This would make the
> whole office (well, the package where the gstreamer thingy is in)
> dependent on qt5. (Yes, I know it's already the case for gtk3, but that
> imho is not a that big issue.)

From my POV it's the same problem / issue.

> I could hack around it but that doesn't scale
> - needs 3 builds of avmedia (gtk3, qt5, neither)
> - would need dpkg-divert and this effectively means you cannot coinstall
>   the -gtk3 and -qt5 plugin packages (and thus not even -gtk3 and
>   -kde5).
>
> Can't the qt5 (and gtk3) libraries not dynamically loaded in some way?

The only halfway sane way I could come up with would be to move an abstract
interface of the gstreamer sink loading into VCL, and just use symbol lookup in
there, so no gstreamer linkage for VCL. avmedia already depends on VCL. I don't
think we support any other avmedia backend then gstreamer on Linux, so that
should be fine. At the point of avmedia usage, all required libraries are
already loaded by the VCL plugin and avmedia.

The whole backend depending code just uses one gstreamer symbol:
gst_element_factory_make.

Happy hacking, Rene :-)

Jan-Marek
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Rene Engelhard Rene Engelhard
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: avmedia/Library_avmediagst.mk avmedia/source vcl/qt5

Hi,

On Mon, Jun 10, 2019 at 02:19:05PM +0200, Jan-Marek Glogowski wrote:
> Am 10.06.19 um 12:21 schrieb Rene Engelhard:
> [... avmedia now depending on Gtk3 and Qt5]
>
> > Thought of this a few days and I don't like this. This would make the
> > whole office (well, the package where the gstreamer thingy is in)
> > dependent on qt5. (Yes, I know it's already the case for gtk3, but that
> > imho is not a that big issue.)
>
> From my POV it's the same problem / issue.

Depends. Given chromium and firefox pull in gtk3 every desktop basically
will have it anyway.
But yes, you are right, for people who want to avoid gtk3 installed it's
the same :-)

> > I could hack around it but that doesn't scale
> > - needs 3 builds of avmedia (gtk3, qt5, neither)
> > - would need dpkg-divert and this effectively means you cannot coinstall
> >   the -gtk3 and -qt5 plugin packages (and thus not even -gtk3 and
> >   -kde5).
> >
> > Can't the qt5 (and gtk3) libraries not dynamically loaded in some way?
>
> The only halfway sane way I could come up with would be to move an abstract
> interface of the gstreamer sink loading into VCL, and just use symbol lookup in
> there, so no gstreamer linkage for VCL. avmedia already depends on VCL. I don't
> think we support any other avmedia backend then gstreamer on Linux, so that
> should be fine. At the point of avmedia usage, all required libraries are
> already loaded by the VCL plugin and avmedia.
>
> The whole backend depending code just uses one gstreamer symbol:
> gst_element_factory_make.
>
> Happy hacking, Rene :-)

Grmpf. :)

Regads,

Rene
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Weghorn Michael Weghorn
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: avmedia/Library_avmediagst.mk avmedia/source vcl/qt5

In reply to this post by Jan-Marek Glogowski
On 10/06/2019 14.19, Jan-Marek Glogowski wrote:
> The only halfway sane way I could come up with would be to move an abstract
> interface of the gstreamer sink loading into VCL, and just use symbol lookup in
> there, so no gstreamer linkage for VCL. avmedia already depends on VCL. I don't
> think we support any other avmedia backend then gstreamer on Linux, so that
> should be fine. At the point of avmedia usage, all required libraries are
> already loaded by the VCL plugin and avmedia.
>
> The whole backend depending code just uses one gstreamer symbol:
> gst_element_factory_make.

For the record, Jan-Marek has implemented this in commit [1] ("Don't
link avmediagst with gtk3 and qt5").

Regards,
  Michael


[1]
https://gerrit.libreoffice.org/plugins/gitiles/core/+/a6201725d760cbce832d4de029b418bb7334df6a%5E!
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice