Request for review of draft: Resolvable comments in Writer

classic Classic list List threaded Threaded
6 messages Options
Jim MacArthur Jim MacArthur
Reply | Threaded
Open this post in threaded view
|

Request for review of draft: Resolvable comments in Writer

I have a draft patch series which adds the ability to mark comments in Writer as resolved. This has had some discussion on https://bugs.documentfoundation.org/show_bug.cgi?id=119228.

The patches are https://gerrit.libreoffice.org/#/c/74455/ and the related changes.

At the moment, this only works for Writer. We haven't established where to store the resolved flag in the document format, so temporarily this series adds a new XML tag called 'resolved'. Ignoring this for the time being, does the rest of the patch series look viable?

Jim MacArthur



_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Regina Henschel Regina Henschel
Reply | Threaded
Open this post in threaded view
|

Re: Request for review of draft: Resolvable comments in Writer

Hi Jim,

Jim MacArthur schrieb am 20-Jun-19 um 17:30:
> I have a draft patch series which adds the ability to mark comments in
> Writer as resolved. This has had some discussion on
> https://bugs.documentfoundation.org/show_bug.cgi?id=119228.
> <https://bugs.documentfoundation.org/show_bug.cgi?id=119228>
>
> The patches are https://gerrit.libreoffice.org/#/c/74455/ and the
> related changes.

I cannot see the patches. Do you have used "submit-draft"? In that case
you need to add reviewer.

Kind regards
Regina
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jim MacArthur Jim MacArthur
Reply | Threaded
Open this post in threaded view
|

Re: Request for review of draft: Resolvable comments in Writer


On 20/06/2019 18:35, Regina Henschel wrote:

> Hi Jim,
>
> Jim MacArthur schrieb am 20-Jun-19 um 17:30:
>> I have a draft patch series which adds the ability to mark comments
>> in Writer as resolved. This has had some discussion on
>> https://bugs.documentfoundation.org/show_bug.cgi?id=119228.
>> <https://bugs.documentfoundation.org/show_bug.cgi?id=119228>
>>
>> The patches are https://gerrit.libreoffice.org/#/c/74455/ and the
>> related changes.
>
> I cannot see the patches. Do you have used "submit-draft"? In that
> case you need to add reviewer.
>
Apologies. I did use submit-draft. I have added you as a reviewer of
those patches. I can resubmit it as a non-draft patch series, if that is
more appropriate.

Jim


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan-Marek Glogowski Jan-Marek Glogowski
Reply | Threaded
Open this post in threaded view
|

Re: Request for review of draft: Resolvable comments in Writer

In reply to this post by Regina Henschel
Am 20.06.19 um 19:35 schrieb Regina Henschel:
> I cannot see the patches. Do you have used "submit-draft"? In that case you need
> to add reviewer.

The better idea would be to just publish them and set yourself a -2 review (AKA
no merge). That's how we commonly push WIP and draft stuff, if we really think
they are not merge-able yet. You don't know who might be interested in reviewing
them.

The Gerrit draft feature is really primary for personal work, which should not
disturb reviewers and should be hidden. Not sure if that is changeable.

Jan-Marek
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jim MacArthur Jim MacArthur
Reply | Threaded
Open this post in threaded view
|

Re: Request for review of draft: Resolvable comments in Writer


On 20/06/2019 18:44, Jan-Marek Glogowski wrote:

> Am 20.06.19 um 19:35 schrieb Regina Henschel:
>> I cannot see the patches. Do you have used "submit-draft"? In that case you need
>> to add reviewer.
> The better idea would be to just publish them and set yourself a -2 review (AKA
> no merge). That's how we commonly push WIP and draft stuff, if we really think
> they are not merge-able yet. You don't know who might be interested in reviewing
> them.
>
> The Gerrit draft feature is really primary for personal work, which should not
> disturb reviewers and should be hidden. Not sure if that is changeable.
>
> Jan-Marek
>
Thank you for your help. I've now published the set and added a -1
review (Gerrit does not give me the option of -2 yet).

Jim

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jim MacArthur Jim MacArthur
Reply | Threaded
Open this post in threaded view
|

Re: Request for review of draft: Resolvable comments in Writer

In reply to this post by Regina Henschel
Hi Regina,

On 20/06/2019 18:35, Regina Henschel wrote:

> Hi Jim,
>
> Jim MacArthur schrieb am 20-Jun-19 um 17:30:
>> I have a draft patch series which adds the ability to mark comments
>> in Writer as resolved. This has had some discussion on
>> https://bugs.documentfoundation.org/show_bug.cgi?id=119228.
>> <https://bugs.documentfoundation.org/show_bug.cgi?id=119228>
>>
>> The patches are https://gerrit.libreoffice.org/#/c/74455/ and the
>> related changes.
>
> I cannot see the patches. Do you have used "submit-draft"? In that
> case you need to add reviewer.
>
>
(This is now public and has been reviewed)

Thank you very much for your review, and for the pointer to Microsoft's
scheme for resolved flags on tdf#119228. I may have to pass this job
onto a colleague, but we'll come back with your points addressed.

Jim

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice