Review for "improve import/export of line styles"

classic Classic list List threaded Threaded
5 messages Options
Regina Henschel Regina Henschel
Reply | Threaded
Open this post in threaded view
|

Review for "improve import/export of line styles"

Hi all,

please have a look at https://gerrit.libreoffice.org/#/c/78372/

An important question is whether you agree that I have changed the
import and export of our own line styles so that no prstDash line styles
are used for them. Instead I export them as custDash elements and
reconstruct them in the import.

I have not added tests yet. Please tell me, what you think would be good
to test.

You know I always have a hard time with C++. So I welcome hints on how
to implement something better.

And technical question: What do I need to do locally in Git, so that the
information, that the no longer needed file "lo_preset_dashes.odt" has
to be deleted, is included in my commit?

Kind regards
Regina
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Weghorn Michael Weghorn
Reply | Threaded
Open this post in threaded view
|

Re: Review for "improve import/export of line styles"

Hi Regina,

On 01/09/2019 19.44, Regina Henschel wrote:

> please have a look at https://gerrit.libreoffice.org/#/c/78372/
>
> An important question is whether you agree that I have changed the
> import and export of our own line styles so that no prstDash line styles
> are used for them. Instead I export them as custDash elements and
> reconstruct them in the import.
>
> I have not added tests yet. Please tell me, what you think would be good
> to test.
>
> You know I always have a hard time with C++. So I welcome hints on how
> to implement something better.

I can't really say anything about your questions regarding line styles...

>
> And technical question: What do I need to do locally in Git, so that the
> information, that the no longer needed file "lo_preset_dashes.odt" has
> to be deleted, is included in my commit?

You can use 'git rm <SOME_PATH>/lo_preset_dashes.odt' to mark that file
for deletion.

Kind regards,
Michael
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Németh László-2 Németh László-2
Reply | Threaded
Open this post in threaded view
|

Re: Review for "improve import/export of line styles"

In reply to this post by Regina Henschel
Németh László <[hidden email]> ezt írta (időpont: 2019. szept. 2., H, 8:19):
Hi Regina,

Regina Henschel <[hidden email]> ezt írta (időpont: 2019. szept. 1., V, 19:44):
Hi all,

please have a look at https://gerrit.libreoffice.org/#/c/78372/

An important question is whether you agree that I have changed the
import and export of our own line styles so that no prstDash line styles
are used for them. Instead I export them as custDash elements and
reconstruct them in the import.

The original idea with binding preset styles of LO and MSO was to support some kind of interoperability: using the same or similar UI to check and modify the line styles.
I can imagine easily, that StarOffice/OpenOffice.org copied the preset styles of the old MSO originally. So maybe modifying/extending the preset styles of LibreOffice would be the final step to create a better interoperability again, and your nice improvement is the first step in this direction.
 

I have not added tests yet. Please tell me, what you think would be good
to test.

I believe, testing import/export of preset styles of LO and MSO are the most important,
but only unit testing can guarantee keeping the improvements, so maybe it's worth to extend the list.
 

You know I always have a hard time with C++. So I welcome hints on how
to implement something better.

And technical question: What do I need to do locally in Git, so that the
information, that the no longer needed file "lo_preset_dashes.odt" has
to be deleted, is included in my commit?

If you deleted the file accidentally,

git checkout sw/qa/extras/ooxmlexport/data/lo_preset_dashes.odt

and

git rm sw/qa/extras/ooxmlexport/data/lo_preset_dashes.odt

and add deletion to the actual commit:

git commit --amend

Best regards,
László

 

Kind regards
Regina
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Mike Kaganski Mike Kaganski
Reply | Threaded
Open this post in threaded view
|

Re: Review for "improve import/export of line styles"

On 02.09.2019 9:20, Németh László wrote:

>>         And technical question: What do I need to do locally in Git, so
>>         that the
>>         information, that the no longer needed file
>>         "lo_preset_dashes.odt" has
>>         to be deleted, is included in my commit?
>
>
>     If you deleted the file accidentally,
>
>     git checkout sw/qa/extras/ooxmlexport/data/lo_preset_dashes.odt
>
>     and
>
>     git rm sw/qa/extras/ooxmlexport/data/lo_preset_dashes.odt
>
>     and add deletion to the actual commit:
>
>     git commit --amend

If you have already deleted the file, there's no need to restore it then
git rm. Just add its current (deleted) state to the index using

   git add path/to/removed/file

and proceed as usual (actually, using git commit -a --amend (when
appropriate) also picks the removal correctly).

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Regina Henschel Regina Henschel
Reply | Threaded
Open this post in threaded view
|

Re: Review for "improve import/export of line styles"

Hi,

thank you all for the technical help. I have not removed the file yet.
And now I know, that 'git rm' will be the correct way.

Kind regards
Regina

Kaganski Mike schrieb am 02-Sep-19 um 12:25:

> On 02.09.2019 9:20, Németh László wrote:
>>>          And technical question: What do I need to do locally in Git, so
>>>          that the
>>>          information, that the no longer needed file
>>>          "lo_preset_dashes.odt" has
>>>          to be deleted, is included in my commit?
>>
>>
>>      If you deleted the file accidentally,
>>
>>      git checkout sw/qa/extras/ooxmlexport/data/lo_preset_dashes.odt
>>
>>      and
>>
>>      git rm sw/qa/extras/ooxmlexport/data/lo_preset_dashes.odt
>>
>>      and add deletion to the actual commit:
>>
>>      git commit --amend
>
> If you have already deleted the file, there's no need to restore it then
> git rm. Just add its current (deleted) state to the index using
>
>     git add path/to/removed/file
>
> and proceed as usual (actually, using git commit -a --amend (when
> appropriate) also picks the removal correctly).
>

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice