[TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

classic Classic list List threaded Threaded
37 messages Options
12 « Prev
Fitoschido Fitoschido
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Missatge de Kaganski Mike <[hidden email]> del dia dt., 23
d’oct. 2018 a les 4:40:

> Well - e.g.,
> https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986
> shows the individual links for each file like this:
>
> icon-themes/breeze/links.txt[diff]
> icon-themes/breeze_dark/links.txt[diff]
> icon-themes/breeze_svg/links.txt[diff]
> icon-themes/colibre/links.txt[diff]
> icon-themes/karasa_jaga/links.txt[diff]
> officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu[diff]
> sw/uiconfig/sglobal/popupmenu/frame.xml[diff]
> sw/uiconfig/sweb/popupmenu/frame.xml[diff]
> sw/uiconfig/swform/popupmenu/frame.xml[diff]
> sw/uiconfig/swreport/popupmenu/frame.xml[diff]
> sw/uiconfig/swriter/popupmenu/frame.xml[diff]
> sw/uiconfig/swxform/popupmenu/frame.xml[diff]
> 12 files changed

Yeah, but those links all open the same page with the complete diff,
just jumping to the relevant file. That way it slows down my computer
to a crawl. Gitweb, on the other hand, just loads the relevant file’s
diff.

Adolfo
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Christian Lohmaier-3 Christian Lohmaier-3
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Adolfo,
On Tue, Oct 23, 2018 at 1:15 PM Adolfo Jayme Barrientos
<[hidden email]> wrote:

>
> Missatge de Kaganski Mike <[hidden email]> del dia dt., 23
> d’oct. 2018 a les 4:40:
> > Well - e.g.,
> > https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986
> > shows the individual links for each file like this:
> >
> > icon-themes/breeze/links.txt[diff]
> > icon-themes/breeze_dark/links.txt[diff]
> > icon-themes/breeze_svg/links.txt[diff]
> > icon-themes/colibre/links.txt[diff]
> > icon-themes/karasa_jaga/links.txt[diff]
> > officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu[diff]
> > sw/uiconfig/sglobal/popupmenu/frame.xml[diff]
> > sw/uiconfig/sweb/popupmenu/frame.xml[diff]
> > sw/uiconfig/swform/popupmenu/frame.xml[diff]
> > sw/uiconfig/swreport/popupmenu/frame.xml[diff]
> > sw/uiconfig/swriter/popupmenu/frame.xml[diff]
> > sw/uiconfig/swxform/popupmenu/frame.xml[diff]
> > 12 files changed
>
> Yeah, but those links all open the same page with the complete diff,
> just jumping to the relevant file.

gitiles has the feature, e.g.
https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986%5E%21/icon-themes/karasa_jaga/links.txt

would show the diff of only the icon-themes/karasa_jaga/links.txt file

or https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986%5E%21/icon-themes/

would limit the view to just those in icon-themes directory.

ciao
Christian
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Guilhem Moulin Guilhem Moulin
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Lionel Elie Mamane
On Tue, 23 Oct 2018 at 09:42:54 +0200, Lionel Elie Mamane wrote:

> On Tue, Oct 23, 2018 at 07:34:54AM +0200, Guilhem Moulin wrote:
>> On Mon, 22 Oct 2018 at 17:25:11 +0200, Lionel Elie Mamane wrote:
>>> On Mon, Oct 22, 2018 at 04:33:21PM +0200, Guilhem Moulin wrote:
>>>> Might be orthogonal to the git:// vs. https:// vs. ssh://
>>>> discussion.  Gerrit uses JGit as Git implementation, while
>>>> git-daemon(1) spawns “normal” (C-based) git-upload-pack(1)
>>>> processes.
>
>>> For us developers of LibreOffice, and thus consumers of the Gerrit
>>> / Git service of freedesktop.org and TDF, whether the difference
>>> comes from the protocol itself or a different git implementation on
>>> the server to serve the different protocols is intellectually
>>> interesting (thanks for that!), but materially inconsequential: if
>>> using git: will be faster, we will use git:.
>
>> Following the same logic, you want gerrit.libreoffice.org to serve
>> content over plain http:// so you can save the two round-trips when
>> you launch your browser to submit your reviews? Oo
>
> Submission (write access) is something else entirely than code
> download (read access); the security requirements are massively
> different. (Yes, I would prefer to be certain that the code I get is
> the right one; however, if I don't and try to submit a patch on top of
> code that is not the on in the TDF repo, it will fail. Unless the
> attacker also constructed git that exploits SHA collisions?)
Another (theoretic) attack vector is to strip a reference from the
initial git-upload-pack advertisement so the dev doesn't get a bugfix or
something; at least not until said dev relocates to a safer network.
 
> (The above analysis does not apply to gerrit-as-a-website, because
> there the link between the code I see and the code I approve is not
> on my local machine, but depends on the security of the connection;
> and because I don't know how to secure reading but not writing on a
> website.)

One way is to add https:// to form action fields.  Not suggesting that
we do that, though :-)  If GET requests are served over plaintext links
even for authenticated users, then an eavesdropper could sniff session
cookies and hijack connections.
 
> If the two round trips are multiplied by many many requests to serve
> one operation, then I may notice. Where "operation" is one action for
> the user, not one action for the program. E.g., "git fetch", "git
> push",

One has to pay the the full TLS overhead for each `git fetch` (AFAIK
libcurl doesn't do session sharing across processes.).  And the full
SSH2 overhead for each `git push`, modulo connection multiplexing.

> "load a complete web page with all images, javascript, dependencies,
> etc", "post an answer to a gerrit change",

Login form aside, all content is served from the gerrit box, so a single
connection is used to serve all resources on a given page.  And our
server is configured to cache TLS sessions IDs, so clicking around
doesn't cost an extra handshake for each page.

>> Things have changed since 2012, encryption is faster (there are
>> modern stream ciphers and hardware acceleration is more widespread),
>> and for situations like this one there is no reason not to encrypt
>> data in transit.
>
> I would have thought symmetric encryption already wasn't a bottlneck,
> at least on the client side (maybe on the server side it was?) in
> 2012; I think one could even back then easily saturate a 100Mbps
> connection using less than 100% of one core of an entry-level desktop
> CPU.
You're right, it was probably a few years before that.  Perhaps the main
changes of the past few years is public perception.  For reference,
GMail defaulted to https:// in early 2010 [0], Facebook in summer 2013
[1] (feeling the heat of the Snowden leaks?), Wikipedia in early 2015
(2013 for authenticated users) [2]

> Many public key crypto operations per seconds is (was?) another issue
> altogether.

Is, esp. for RSA (we're not using EdDSA currently).

--
Guilhem.

[0] https://gmail.googleblog.com/2010/01/default-https-access-for-gmail.html
    https://transparencyreport.google.com/https/overview
[1] https://www.facebook.com/notes/facebook-engineering/secure-browsing-by-default/10151590414803920/
[2] https://blog.wikimedia.org/2015/06/12/securing-wikimedia-sites-with-https/

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Guilhem Moulin Guilhem Moulin
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Kaganski Mike
On Tue, 23 Oct 2018 at 09:40:20 +0000, Kaganski Mike wrote:
> What seems odd to me is why the log like
> https://gerrit.libreoffice.org/plugins/gitiles/core/+log/HEAD shows
> commit creatin time that is different from the time the commit was
> pushed to the branch. I would like to see just-pushed commits to tell "5
> minutes ago" instead "3 days ago" like it might be now.

It's shows the authored date, not the commit date.  We can easily tweak
the template, but IMHO it's more consistent to show the authored date
given that the name that's beside it is the author's not the committer.
Gitweb, on the other hand, shows the *commit* date along with the
*author* name.  Compare

    https://gerrit.libreoffice.org/plugins/gitiles/core/+log/e50f90bd21dc1116e5f1defc73f230ef1b687315 and
    https://gerrit.libreoffice.org/gitweb?p=core.git;a=log;h=e50f90bd21dc1116e5f1defc73f230ef1b687315

for this commit (authored by Serge Krot on Oct 5, committed by bubli on
Oct 22):

    https://gerrit.libreoffice.org/plugins/gitiles/core/+/e50f90bd21dc1116e5f1defc73f230ef1b687315
    https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=e50f90bd21dc1116e5f1defc73f230ef1b687315

--
Guilhem.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Guilhem Moulin Guilhem Moulin
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Christian Lohmaier-3
On Tue, 23 Oct 2018 at 13:42:34 +0200, Christian Lohmaier wrote:

> On Tue, Oct 23, 2018 at 1:15 PM Adolfo Jayme Barrientos <[hidden email]> wrote:
>> Missatge de Kaganski Mike <[hidden email]> del dia dt., 23 d’oct. 2018 a les 4:40:
>>> Well - e.g.,
>>> https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986
>>> shows the individual links for each file like this:
>>>
>>> icon-themes/breeze/links.txt[diff]
>>> icon-themes/breeze_dark/links.txt[diff]
>>> icon-themes/breeze_svg/links.txt[diff]
>>> icon-themes/colibre/links.txt[diff]
>>> icon-themes/karasa_jaga/links.txt[diff]
>>> officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu[diff]
>>> sw/uiconfig/sglobal/popupmenu/frame.xml[diff]
>>> sw/uiconfig/sweb/popupmenu/frame.xml[diff]
>>> sw/uiconfig/swform/popupmenu/frame.xml[diff]
>>> sw/uiconfig/swreport/popupmenu/frame.xml[diff]
>>> sw/uiconfig/swriter/popupmenu/frame.xml[diff]
>>> sw/uiconfig/swxform/popupmenu/frame.xml[diff]
>>> 12 files changed
>>
>> Yeah, but those links all open the same page with the complete diff,
>> just jumping to the relevant file.
>
> gitiles has the feature, e.g.
> https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986%5E%21/icon-themes/karasa_jaga/links.txt
>
> would show the diff of only the icon-themes/karasa_jaga/links.txt file
>
> or https://gerrit.libreoffice.org/plugins/gitiles/core/+/b0c6d587405af9e2263dc5073a9a965db46ff986%5E%21/icon-themes/
>
> would limit the view to just those in icon-themes directory.
Right, I'll tweak the template so the “[diff]” anchors in the log page
link to these per-files diffs then, to match what gitweb is doing :-)

--
Guilhem.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Guilhem Moulin Guilhem Moulin
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Guilhem Moulin
Hi Eike,

On Wed, 17 Oct 2018 at 21:03:45 +0200, Guilhem Moulin wrote:
> On Wed, 17 Oct 2018 at 14:05:27 +0200, Eike Rathke wrote:
>> For diffs I much prefer the gerrit view because it highlights changes
>> within changed lines, for example
>>
>> https://gerrit.libreoffice.org/plugins/gitiles/core/+/9672d034b9e760f24ac9a6652ab45dee15ee260a%5E%21/
>> vs
>> https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=9672d034b9e760f24ac9a6652ab45dee15ee260a
>>
>> Would that be possible also with gitiles?

They both show marked changes now :-)

> Not that I know of, and looking at the source I don't think so
>
> https://gerrit.googlesource.com/gitiles/+/master/java/com/google/gitiles/HtmlDiffFormatter.java#142

I patched this file to make use of Neil Fraser's ‘diff-match-patch’
library and find the array of differences to mark (with semantic
cleanups so the result is readable).  That array is also what's used to
compute the Levenshtein distance, so it should be quite accurate ;-)

On the other hand, gitweb's algorithm is rather dumb and crude.  Only
edits with the same number of deleted & inserted lines are considered;
the marked part is what's left after removing the longest common prefix
& suffix between a removed line is its corresponding insertion.  It's
therefore not possible to have more than one mark per line, and code
reflowing might not marked properly.

Complexity wise gitweb's algorithm has a lower worst case bound (linear
vs. quadratic), but it shouldn't matter in practice as in our case the
marks don't need to be optimal, and the algorithm will give up and
return a sub-optimal solution if it hasn't found the best one under
50ms.

Unfortunately that change is most likely not upstreamable since I had to
abuse the JGit API quite heavily… :-/

--
Guilhem.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Guilhem Moulin Guilhem Moulin
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Fitoschido
On Tue, 23 Oct 2018 at 04:29:05 -0500, Adolfo Jayme Barrientos wrote:
> Since loading the whole diff for a commit would potentially crash my
> browser, I find it very helpful to load each file’s individual diff in
> a commit like this [1]. Also, I can open per-file diffs in separate
> tabs for better organization.

You'll now find links to per-file diffs at
https://gerrit.libreoffice.org/plugins/gitiles/translations/+/master .
Is your workflow covered, Adolfo?

--
Guilhem.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Bjoern Michaelsen-3 Bjoern Michaelsen-3
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Guilhem Moulin
Hi,
On Wed, Oct 17, 2018 at 04:27:54AM +0200, Guilhem Moulin wrote:
>   * diff: https://gerrit.libreoffice.org/plugins/gitiles/core/+/master%5E%21/
>     vs. https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=refs/heads/master

that looks great!

Can we have it as the link in these "commit notifications" like:

 https://bugs.documentfoundation.org/show_bug.cgi?id=120906#c1

too?

Best,

Bjoern
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Guilhem Moulin Guilhem Moulin
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Björn,

On Sun, 28 Oct 2018 at 10:55:01 +0100, Bjoern Michaelsen wrote:
> Can we have it as the link in these "commit notifications"

Sure, done: https://bugs.documentfoundation.org/show_bug.cgi?id=119410#c6 .

Cheers,
--
Guilhem.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
slacka slacka
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Guilhem Moulin

Now that gitiles is linked to bugzilla instead of cgit, I'm giving it a good workout. From a QA perspective, it's missing 2 key features that interfere with my workflow.

The date gitiles displays in the log is the author date, rather than the much more useful commit date. When trying to track down regressions, you care about the order of commits, not when they were authored.

Also, how do you search a range and author? I used both of these searches very often. Without them, gitiles shouldn't be the default. I keep finding myself manually switching back to cgit to access these.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Guilhem Moulin Guilhem Moulin
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On Tue, 30 Oct 2018 at 16:18:36 +0000, Luke Benes wrote:
> The date gitiles displays in the log is the author date, rather than
> the much more useful commit date.

Quoting my own <[hidden email]>:

| It's shows the authored date, not the commit date.  We can easily tweak
| the template, but IMHO it's more consistent to show the authored date
| given that the name that's beside it is the author's not the committer.
| Gitweb, on the other hand, shows the *commit* date along with the
| *author* name.

> When trying to track down regressions, you care about the order of
> commits, not when they were authored.

I'm confused, neither commit date nor author date give any guaranty
regarding the order of commits.  AFAICT the only thing that helps here
is to follow the Merkel tree (child → ancestor) back to the root.
Unlike ordering by date, performing a topological order of the tree
(e.g., following the output from git-log(1)) is reliable, as the
relations are cryptographically secured.

That being said, I don't care which of author or committer is shown in
the log view.  I believe it should be both committer name + date, or
both author name + date for consistency, but if QA wants to mix the two
then so be it.

> Also, how do you search a range and author? I used both of these
> searches very often.

It's been asked and replied earlier in this thread, too.  Authors and
committers are links to their respective filtered log (by adding
author=$AUTHOR or committer=$COMMITTER to the query string).

Ranges are obtained with $COMMIT_ID1..$COMMIT_ID2 (similar to GitHub),
for instance

    https://git.libreoffice.org/core/+log/647fc4..044122d (oneline)
    https://git.libreoffice.org/core/+log/647fc4..044122d?pretty=full (log + commit messages)
    https://git.libreoffice.org/core/+/647fc4..044122d (diff)

> Without them, gitiles shouldn't be the default. I keep finding myself
> manually switching back to cgit to access these.

FWIW, Moggi hinted that there were good reasons for pointing bugzilla
notifications to FreeDesktop, and he's planing to revert the change.

--
Guilhem.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Guilhem Moulin
Hi Guilhem,

On Friday, 2018-10-26 15:44:53 +0200, Guilhem Moulin wrote:

> On Wed, 17 Oct 2018 at 21:03:45 +0200, Guilhem Moulin wrote:
> > On Wed, 17 Oct 2018 at 14:05:27 +0200, Eike Rathke wrote:
> >> For diffs I much prefer the gerrit view because it highlights changes
> >> within changed lines, for example
> >>
> >> https://gerrit.libreoffice.org/plugins/gitiles/core/+/9672d034b9e760f24ac9a6652ab45dee15ee260a%5E%21/
> >> vs
> >> https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=9672d034b9e760f24ac9a6652ab45dee15ee260a
> >>
> >> Would that be possible also with gitiles?
>
> They both show marked changes now :-)
Hey great, thanks!

> Unfortunately that change is most likely not upstreamable since I had to
> abuse the JGit API quite heavily… :-/

Nice work however, appreciated.

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (849 bytes) Download Attachment
Kaganski Mike Kaganski Mike
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Guilhem Moulin
On 10/31/2018 9:15 AM, Guilhem Moulin wrote:

> On Tue, 30 Oct 2018 at 16:18:36 +0000, Luke Benes wrote:
>> The date gitiles displays in the log is the author date, rather than
>> the much more useful commit date.
>
> Quoting my own <[hidden email]>:
>
> | It's shows the authored date, not the commit date.  We can easily tweak
> | the template, but IMHO it's more consistent to show the authored date
> | given that the name that's beside it is the author's not the committer.
> | Gitweb, on the other hand, shows the *commit* date along with the
> | *author* name.
>
>> When trying to track down regressions, you care about the order of
>> commits, not when they were authored.
>
> I'm confused, neither commit date nor author date give any guaranty
> regarding the order of commits.  AFAICT the only thing that helps here
> is to follow the Merkel tree (child → ancestor) back to the root.
> Unlike ordering by date, performing a topological order of the tree
> (e.g., following the output from git-log(1)) is reliable, as the
> relations are cryptographically secured.

Well - of course, there's no guarantees; but given the workflow, when we
have the author date recorded when the first version of commit was
created, which might be months before the commit gets into the final
shape (which can be drastically different from the first version), the
"author date" has ~no value, while commit date has at least some, and is
actually helpful.

Thus, given that

> I don't care which of author or committer is shown in
> the log view.  I believe it should be both committer name + date, or
> both author name + date for consistency, but if QA wants to mix the two
> then so be it.

please do the change :-)

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Miklos Vajna-4 Miklos Vajna-4
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

Hi Mike,

On Tue, Nov 06, 2018 at 07:30:45AM +0000, Kaganski Mike <[hidden email]> wrote:
> Well - of course, there's no guarantees; but given the workflow, when we
> have the author date recorded when the first version of commit was
> created, which might be months before the commit gets into the final
> shape (which can be drastically different from the first version), the
> "author date" has ~no value, while commit date has at least some, and is
> actually helpful.

Sure, commit date is useful to see as well. But I think both dates are
already shown e.g. here:

https://gerrit.libreoffice.org/plugins/gitiles/core/+/dc80d60dc8dab1a124e2f4b33618b3a40cb1cbfa

> please do the change :-)

So what to change?

Regards,

Miklos

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (201 bytes) Download Attachment
Kaganski Mike Kaganski Mike
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

On 11/6/2018 4:12 PM, Miklos Vajna wrote:
> So what to change?

https://git.libreoffice.org/core/+log/HEAD

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
sberg sberg
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Guilhem Moulin
One minor thing that cgit.freedesktop.org provides is a "Diffstat" block
(listing all files changed) between the commit message and the
individual files' diffs, see e.g.
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=ddcd36d9d6191bfba7dea179067767a9ee192608>.

That's not present at the corresponding
<https://gerrit.libreoffice.org/plugins/gitiles/core/+/ddcd36d9d6191bfba7dea179067767a9ee192608%5E!/>.
  Is there a way to add that, or a different form of URL that would show it?
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
sberg sberg
Reply | Threaded
Open this post in threaded view
|

Re: [TDF infra] Announcing Gitiles VCS browser (gitweb replacement) and https:// anon git URIs

In reply to this post by Eike Rathke-2
On 17/10/2018 14:05, Eike Rathke wrote:
> For diffs I much prefer the gerrit view because it highlights changes
> within changed lines, for example
>
> https://gerrit.libreoffice.org/plugins/gitiles/core/+/9672d034b9e760f24ac9a6652ab45dee15ee260a%5E%21/
>
> vs
>
> https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=9672d034b9e760f24ac9a6652ab45dee15ee260a

Is the original content of that second link (resp. other such
<https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=...>)
still visible somewhere?  It now redirects to the first link.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
12 « Prev