Trying to put LO Firebird patches upstream, license issue?

classic Classic list List threaded Threaded
16 messages Options
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

Trying to put LO Firebird patches upstream, license issue?

Hello,

Following my abandoning of Firebird 3.0.4 upgrade, I wonder if it may help
to try to submit some LO Firebird patches upstream.
For example, Cygwin  is still not present in configure.ac file of Firebird
master sources.
Is it ok to submit a patch or is there license/agreement issue to take into
account?

Julien



--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Mike Kaganski Mike Kaganski
Reply | Threaded
Open this post in threaded view
|

Re: Trying to put LO Firebird patches upstream, license issue?

Hi,

On 04.02.2019 22:36, julien2412 wrote:
> Following my abandoning of Firebird 3.0.4 upgrade, I wonder if it may help
> to try to submit some LO Firebird patches upstream.
> For example, Cygwin  is still not present in configure.ac file of Firebird
> master sources.
> Is it ok to submit a patch or is there license/agreement issue to take into
> account?

Well - since our patches are modifications to Firebird, which requires
all modifications to have IDPL licensing, then all our modifications
cannot be under a different license? (And I seem to remember something
in these lines from some recent discussion here.)

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

Re: Trying to put LO Firebird patches upstream, license issue?

On 04/02/2019 20:48, Kaganski Mike wrote:

> Hi,
>
> On 04.02.2019 22:36, julien2412 wrote:
>> ...
>> Is it ok to submit a patch or is there license/agreement issue to take into
>> account?
> Well - since our patches are modifications to Firebird, which requires
> all modifications to have IDPL licensing, then all our modifications
> cannot be under a different license? (And I seem to remember something
> in these lines from some recent discussion here.)

Thank you Mike for your quick feedback.

Could there be any compatibility between these licenses ? (perhaps only
1 way : submit an LO patch on Firebird or submit a Firebird patch on LO)

For example, I think LO can retrieve patches from ApacheOpenOffice but
the reverse isn't possible (except if all the authors from the patch are
ok). In the worst case and it would mean, considering
https://cgit.freedesktop.org/libreoffice/core/commit/?id=45f42681f4d1260c42140a313560534e605f81a4,
I should ask to Tamas and Lionel (let's put them in cc) if they accept
to submit the configure part of this patch upstream?

Julien

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks-5 Michael Meeks-5
Reply | Threaded
Open this post in threaded view
|

Re: Trying to put LO Firebird patches upstream, license issue?

Hi Julien,

On 04/02/2019 21:15, Julien Nabet wrote:
>> Well - since our patches are modifications to Firebird, which requires
>> all modifications to have IDPL licensing, then all our modifications
>> cannot be under a different license?

        So - Mike is right; but I expect no problems here. We should contribute
to Firebird under their own license, respecting that. This may mean that
whomever wrote the patch / worked on it should contribute it up-stream
to Firebird, and/or give permission for that.
        > Could there be any compatibility between these licenses ? (perhaps only
> 1 way : submit an LO patch on Firebird or submit a Firebird patch on LO)

        We really don't want long-lasting patches in external/ that don't go
up-stream.

> I should ask to Tamas and Lionel (let's put them in cc) if they accept
> to submit the configure part of this patch upstream?

        Sure; and interestingly TDF and/or Collabora may own rights in that,
and may need to help out with the Firebird side if it is non-trivial.

        Then again - that is something we should definitely do! it's really
good to work on this, please do find out how best we can help contribute
those and fold them into Firebird.

        Thanks !

                Michael.

--
[hidden email] <><, GM Collabora Productivity
Hangout: [hidden email], Skype: mmeeks
(M) +44 7795 666 147 - timezone usually UK / Europe
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Mike Kaganski Mike Kaganski
Reply | Threaded
Open this post in threaded view
|

Re: Trying to put LO Firebird patches upstream, license issue?

On 09.02.2019 22:19, Michael Meeks wrote:

> Hi Julien,
>
> On 04/02/2019 21:15, Julien Nabet wrote:
>>> Well - since our patches are modifications to Firebird, which requires
>>> all modifications to have IDPL licensing, then all our modifications
>>> cannot be under a different license?
>
> So - Mike is right; but I expect no problems here. We should contribute
> to Firebird under their own license, respecting that. This may mean that
> whomever wrote the patch / worked on it should contribute it up-stream
> to Firebird, and/or give permission for that.

Hmm... I'm sorry for not being clear. My point was that since our
patches (in our tree) were changing Firebird, they *automatically*
follow Firebird license - or otherwise we couldn't have modified it. So
I meant that whatever LibreOffice licensing is, the patches in Firebird
External subdirectory are already license-compatible with upstream Firebird.

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

[ABANDONED] Re: Trying to put LO Firebird patches upstream, license issue?

On 09/02/2019 21:33, Kaganski Mike wrote:
> On 09.02.2019 22:19, Michael Meeks wrote:
>> ...
> Hmm... I'm sorry for not being clear. My point was that since our
> patches (in our tree) were changing Firebird, they *automatically*
> follow Firebird license - or otherwise we couldn't have modified it. So
> I meant that whatever LibreOffice licensing is, the patches in Firebird
> External subdirectory are already license-compatible with upstream Firebird.

So it seems, there may be some issue to use external patches. I don't
anything about law, even less in international law, so I won't try to
put any external patches upstream.

Thank you for your feedback Michael and Mike.

Julien

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Lionel Elie Mamane Lionel Elie Mamane
Reply | Threaded
Open this post in threaded view
|

Re: Trying to put LO Firebird patches upstream, license issue?

In reply to this post by julien2412
On Mon, Feb 04, 2019 at 09:15:00PM +0100, Julien Nabet wrote:

> I should ask to Tamas and Lionel (let's put them in cc) if they
> accept to submit the configure part of this patch upstream?

Any patch / modification that I made to Firebird or its build system
or JDBC / ODBC / ... drivers or whatever, has my authorisation to be
integrated into the upstream project under the licence the respective
upstream project was under as of 1 February 2019.

I'm happy for that to happen, and I'm sorry I didn't organise this
myself as is good practice.

Best Regards,

Lionel
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks-5 Michael Meeks-5
Reply | Threaded
Open this post in threaded view
|

Re: Trying to put LO Firebird patches upstream, license issue?

In reply to this post by Mike Kaganski

On 09/02/2019 21:33, Kaganski Mike wrote:
> Hmm... I'm sorry for not being clear. My point was that since our
> patches (in our tree) were changing Firebird, they *automatically*

        IANAL - but I suspect this process very much depends on the license in
question, and the contribution policy for firebird - as an aside the:

        https://firebirdsql.org/en/get-involved/

        has an unhelpful 404 for "contributing patches" today.

        Either way this is certainly -not- the right forum to discuss legal /
licensing questions.

        As a general yard-stick, (and depending on the project) - encouraging
those who create the patches to submit them up-stream themselves is a
good idea. We really do want to get these things up-stream - so it's a
great initiative Julien.

        ATB,
       
                Michael.

--
[hidden email] <><, GM Collabora Productivity
Hangout: [hidden email], Skype: mmeeks
(M) +44 7795 666 147 - timezone usually UK / Europe
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Lionel Elie Mamane Lionel Elie Mamane
Reply | Threaded
Open this post in threaded view
|

Re: Trying to put LO Firebird patches upstream, license issue?

In reply to this post by julien2412
On Sat, Feb 09, 2019 at 11:16:11PM +0100, Julien Nabet wrote:
> On 09/02/2019 21:33, Kaganski Mike wrote:

>> Hmm... I'm sorry for not being clear. My point was that since our
>> patches (in our tree) were changing Firebird, they *automatically*
>> follow Firebird license - or otherwise we couldn't have modified
>> it. So I meant that whatever LibreOffice licensing is, the patches
>> in Firebird External subdirectory are already license-compatible
>> with upstream Firebird.

> So it seems, there may be some issue to use external patches. I
> don't anything about law, even less in international law, so I won't
> try to put any external patches upstream.

Julien, what Mike is saying is that there is *no* legal / licensing
issue to upstream the firebird external patches now in the LibreOffice
code tree, since per the firebird licence, the people that wrote those
patches already agreed to putting them under the same licence as
firebird.

I have no reason not to believe Mike; we might want to mail the
authors anyway, just to be legally sure they don't oppose the
upstreaming; I cannot imagine any of them would.

Best Regards,

Lionel
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Lionel Elie Mamane Lionel Elie Mamane
Reply | Threaded
Open this post in threaded view
|

Upstreaming LO Firebird patches

In reply to this post by Michael Meeks-5
Hi everyone,

Your name/email appears as "Author" in a git commit that changes one
of the "patch" files in external/firebird.

Do you agree that these patches be contributed upstream? Thank you in
advance for your confirmation. Please keep
Julien Nabet <[hidden email]>
CCed in your answers.

(This email follows some discussion on whether you did or not
 implicitly giving that permission by committing the patch in the
 LibreOffice git...)

Thanks in advance,

Lionel Mamane
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
David Ostrovsky-3 David Ostrovsky-3
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming LO Firebird patches

On Mon, 2019-02-11 at 12:26 +0100, Lionel Elie Mamane wrote:
> Hi everyone,
>
> Your name/email appears as "Author" in a git commit that changes one
> of the "patch" files in external/firebird.
>
> Do you agree that these patches be contributed upstream?

Yes.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks-5 Michael Meeks-5
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming LO Firebird patches

In reply to this post by Lionel Elie Mamane
Hi Lionel,

On 11/02/2019 12:26, Lionel Elie Mamane wrote:
> Do you agree that these patches be contributed upstream? Thank you in
> advance for your confirmation. Please keep
> Julien Nabet <[hidden email]>
> CCed in your answers.
>
> (This email follows some discussion on whether you did or not
>  implicitly giving that permission by committing the patch in the
>  LibreOffice git...)

        Fine for all the Collabora commits (of course).

        ATB,

                Michael.

--
[hidden email] <><, GM Collabora Productivity
Hangout: [hidden email], Skype: mmeeks
(M) +44 7795 666 147 - timezone usually UK / Europe
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
sberg sberg
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming LO Firebird patches

In reply to this post by Lionel Elie Mamane
On 11/02/2019 12:26, Lionel Elie Mamane wrote:
> Your name/email appears as "Author" in a git commit that changes one
> of the "patch" files in external/firebird.
>
> Do you agree that these patches be contributed upstream? Thank you in
> advance for your confirmation. Please keep
> Julien Nabet <[hidden email]>
> CCed in your answers.

yes, I agree
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Khaled Hosny-2 Khaled Hosny-2
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming LO Firebird patches

In reply to this post by Lionel Elie Mamane
Hi Lionel,

I'm pretty sure I never changed any firebird patches, I only moved them
to external/firebird.

Regards,
Khaled

On Mon, Feb 11, 2019 at 12:26:53PM +0100, Lionel Elie Mamane wrote:

> Hi everyone,
>
> Your name/email appears as "Author" in a git commit that changes one
> of the "patch" files in external/firebird.
>
> Do you agree that these patches be contributed upstream? Thank you in
> advance for your confirmation. Please keep
> Julien Nabet <[hidden email]>
> CCed in your answers.
>
> (This email follows some discussion on whether you did or not
>  implicitly giving that permission by committing the patch in the
>  LibreOffice git...)
>
> Thanks in advance,
>
> Lionel Mamane
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming LO Firebird patches

In reply to this post by Lionel Elie Mamane
On Mon, 2019-02-11 at 12:26 +0100, Lionel Elie Mamane wrote:
> Do you agree that these patches be contributed upstream?

yeah

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Stahl-4 Michael Stahl-4
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming LO Firebird patches

In reply to this post by Lionel Elie Mamane

On 11.02.19 12:26, Lionel Elie Mamane wrote:
> Your name/email appears as "Author" in a git commit that changes one
> of the "patch" files in external/firebird.
>
> Do you agree that these patches be contributed upstream? Thank you in
> advance for your confirmation. Please keep
> Julien Nabet <[hidden email]>
> CCed in your answers.
>
i'm not sure what the point is since AFAIK Firebird is licensed under a
weak-copyleft license (some MPLv1 clone), but anyway:

i'm hereby clarifying that my CIB patches to Firebird are licensed under
whatever license the upstream Firebird project uses and may thus be
contributed upstream.

with regard to my Red Hat patches, my understanding is they were covered
by Red Hat's usual policy of using the same license as the upstream
project in question, so they may also be contributed upstream.


--
Michael Stahl
Senior Software-Entwickler LibreOffice
–––
CIB software GmbH
Geschäftsstelle Hamburg
Flachsland 10
22083 Hamburg
–––
T +49 (40) / 28 48 42 -296
F +49 (40) / 28 48 42 -100
[hidden email]
www.cib.de
–––
Sitz: München
Registergericht München, HRB 123286
Geschäftsführer: Dipl.-Ing. Ulrich Brandner

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice