fdo#46037, about newerverwarn (uui module) and UpdateCheckJob

classic Classic list List threaded Threaded
3 messages Options
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

fdo#46037, about newerverwarn (uui module) and UpdateCheckJob

Hello,

I'm trying to remove comphelper/configurationhelper.hxx as required for fdo#46037 (see https://bugs.freedesktop.org/show_bug.cgi?id=46037) in uui/source/newerverwarn.cxx
Here's the original code:
    106             // TODO: do we need to respect the bUpdateCheckEnabled flag? Finally, its meaning is "are automatic
    107             // updates enabled", but this here is not an automatic update, but one triggered explicitly by the user.
    108
    109             uno::Any aVal = ::comphelper::ConfigurationHelper::readDirectKey(
    110                                     xContext,
    111                                     "org.openoffice.Office.Addons/",
    112                                     "AddonUI/OfficeHelp/UpdateCheckJob",
    113                                     "URL",
    114                                     ::comphelper::ConfigurationHelper::E_READONLY );
    115             util::URL aURL;
    116             if ( aVal >>= aURL.Complete )

So I tried to replace this by:
uno::Any aVal = officecfg::Office::Addons::AddonUI::OfficeHelp::UpdateCheckJob::URL::get();
(of course with:
1) #include <officecfg/Office/Addons.hxx>
2) $(eval $(call gb_Library_use_custom_headers,uui,\
     officecfg/registry \
    )) in uui/Library_uui.mk

but I got this:
error: ‘officecfg::Office::Addons::AddonUI::OfficeHelp::UpdateCheckJob’ has not been declared

Indeed, there's nothing in officecfg/registry/schema/org/openoffice/Office/Addons.xcs about this.
The problem is I don't know how to declare "UpdateCheckJob" in xcs and how to regenerate ./workdir/unxlngx6/CustomTarget/officecfg/registry/officecfg/Office/Addons.hxx (just "make officecfg" ?)

Any idea?

Julien
sberg sberg
Reply | Threaded
Open this post in threaded view
|

Re: fdo#46037, about newerverwarn (uui module) and UpdateCheckJob

On 07/23/2013 09:14 AM, julien2412 wrote:

> I'm trying to remove comphelper/configurationhelper.hxx as required for
> fdo#46037 (see https://bugs.freedesktop.org/show_bug.cgi?id=46037) in
> uui/source/newerverwarn.cxx
> Here's the original code:
>      106             // TODO: do we need to respect the bUpdateCheckEnabled
> flag? Finally, its meaning is "are automatic
>      107             // updates enabled", but this here is not an automatic
> update, but one triggered explicitly by the user.
>      108
>      109             uno::Any aVal =
> ::comphelper::ConfigurationHelper::readDirectKey(
>      110                                     xContext,
>      111                                     "org.openoffice.Office.Addons/",
>      112
> "AddonUI/OfficeHelp/UpdateCheckJob",
>      113                                     "URL",
>      114
> ::comphelper::ConfigurationHelper::E_READONLY );
>      115             util::URL aURL;
>      116             if ( aVal >>= aURL.Complete )
>
> So I tried to replace this by:
> uno::Any aVal =
> officecfg::Office::Addons::AddonUI::OfficeHelp::UpdateCheckJob::URL::get();
> (of course with:
> 1) #include <officecfg/Office/Addons.hxx>
> 2) $(eval $(call gb_Library_use_custom_headers,uui,\
>       officecfg/registry \
>      )) in uui/Library_uui.mk
>
> but I got this:
> error: ‘officecfg::Office::Addons::AddonUI::OfficeHelp::UpdateCheckJob’ has
> not been declared
>
> Indeed, there's nothing in
> officecfg/registry/schema/org/openoffice/Office/Addons.xcs about this.
> The problem is I don't know how to declare "UpdateCheckJob" in xcs and how
> to regenerate
> ./workdir/unxlngx6/CustomTarget/officecfg/registry/officecfg/Office/Addons.hxx
> (just "make officecfg" ?)

/org.openoffice.Office.Addons/AddonUI/OfficeHelp is a set, so
officecfg/Office/Addons.hxx contains struct
officecfg::Office::Addons::OfficeHelp deriving from
comphelper::ConfigurationSet (comphelper/configuration.hxx) that has a
member function named "get" to obtain read-only access to the set
members as a "raw" css::container::XNameAccess.

Stephan
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
julien2412 julien2412
Reply | Threaded
Open this post in threaded view
|

[SOLVED] Re: fdo#46037, about newerverwarn (uui module) and UpdateCheckJob

Thank you Stephan, it has been reviewed and pushed on master (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=20430c74f391ceffd8a063c0b6b8a8fd615abac0).

Julien