minutes of ESC call ...

classic Classic list List threaded Threaded
4 messages Options
Michael Meeks-5 Michael Meeks-5
Reply | Threaded
Open this post in threaded view
|

minutes of ESC call ...

* Present:
    + Stephan, Caolan, Eike, Heiko, Olivier, Thorsten, Armin, Xisco,
      Michael M, Miklos, Michael S, Sophie, Christian, Jan-Marek

* Completed Action Items:

* Pending Action Items:
    + build concrete, deliverable plan for live-screenshots (Olivier, Armin)
        [ stalled
          what is missing wrt. estimating it ? (Thorsten)
             + plan needed to implement automation of screenshots
               at install-time for local help (Olivier)
             + please write this as a wiki page so people can jump in (Thorsten)]

* Release Engineering update (Christian)
    + 5.4.0 RC2
      + delayed a bit – 32bit Windows for XP –
        required patch reversion wrt. Font-rendering settings.
        + will make this 32bit / XP specific.
      + build failure on OS/X wrt. expat configure.
        + back-ported from master.
      + RC2 is a week late.
      + but built and branched.
      + three reviews later this week after RC2, on the release branch
      + 5.4.0 final
        + tagging is next-week, after that is final – last week of July.
      + feature pages: please update:
        + https://wiki.documentfoundation.org/ReleaseNotes/5.4
    + 5.3.5 RC1
      + tagged yesterday, builds for Linux done,
        Windows + Mac due later today.
      + will apply mac patches for RC2 – in gerrit.
    + Android & iOS Remote
    + online
        + 5.4.0 RC2 release done by Andras

* Documentation (Olivier)
+ New layout of help online (TDF#97745)
    + check it: https://helponline.libreoffice.org
    + now responsive (read LO help in your mobile)
    + All TDF languages that are built are listed
    + thanks to buovjaga for helping out
    + TODO: Finish the Contents tab (tree files)
    + TODO: make it local (file:///)
    + TODO: Working on a blog post about.

+ New Authors showing at summer times

+ do we get paid for google custom search ? (Heiko)
    + get a lot of external links from that (Olivier)
        + we get Excel pivot tables eg.
    + solution for internal search is a bit further out.

* Theodore (Shinnok) intro
    + new development mentor for TDF
    + just starting, getting feet wet, doing admin
    + several open-source contributions
    + GSOC student + mentor etc.
    + C++ developer, based in Romania – EU timezone.

* SSRLabs Interns (Michael)
    + eight new hacking interns around: performance & quality
    + starting on their first easy-hacks.
    + Any ideas on quality ? (Xisco)
        + can write UI test; can take a couple.
    + Extending performance test-suite (Markus?)
    + XML filter pieces (Michael)
        + continue & expand Azorpid’s work.
    + other misc. threading / perf. Ideas (Michael)
    + UX pieces (Heiko)
        + problem is: need a coding mentor here.
        + missing table styles, area style types etc.
        + page background etc.
    + build performance on windows ? (Thorsten)

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        260(260) (topicUI) bugs open, 474(474) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month    3 months   12 months  
             added      2(-2)     12(-5)     38(0)      406(-3)
         commented     22(-21)   151(-13)   542(-5)    3324(-24)
           removed      0(0)       3(0)       6(0)       43(0)  
          resolved      0(-3)     12(-3)     37(-4)     244(0)  
    + top 10 contributors:
          Thomas Lendo made 195 changes in 1 month, and 389 changes in 1 year
          Philips, Yousuf made 94 changes in 1 month, and 1530 changes in 1 year
          Tietze, Heiko made 50 changes in 1 month, and 1503 changes in 1 year
          Foote, V Stuart made 36 changes in 1 month, and 582 changes in 1 year
          Timur made 22 changes in 1 month, and 66 changes in 1 year
          Cor Nouws made 15 changes in 1 month, and 351 changes in 1 year
          Buovjaga made 12 changes in 1 month, and 361 changes in 1 year
          Faulí Tarazona, Xisco made 11 changes in 1 month, and 417 changes in 1 y
          Henschel, Regina made 9 changes in 1 month, and 132 changes in 1 year
          Mehrbrodt, Samuel made 7 changes in 1 month, and 110 changes in 1 year

    + Not much to report
    + Missing participants in the weekly call, esp. devs
    + would appreciate developer input in the call.
    + have a couple of tasks that could be easy-hacks
       + line-spacing in calc ? Not sure where to start.
       + https://bugs.documentfoundation.org/show_bug.cgi?id=108891 (easyhack or not?)

* Crash Testing (Caolan)
    + 2(-8) import failure, 6(+3) export failures
      + exploded for a while, now down – run due in the next hours
    + bigptrarray issues got fixed ? (Michael)
      + yes, Noel reverted the problematic change (Miklos)
    + oss-fuzz: 31 fuzzers active
      + no new fuzzers added, last was Qpro
      + lots of calc filters to add yet
      + getting lots of OOM results from MS Word filters
    + coverity: 14

* RSC death (Caolan)
    + as per the E-mail – porting to gettext
    + have a patch that moves us to boost’s gettext at runtime
    + boost reads the binary .mo file format
    + translations only a little bigger than before
    + now zipped – so size is not an issue.
    + don’t want to break l10n
       + have a script to run over existing translations
       + tested it on a tar-ball from cloph.
    + if no objections & cloph is happy & l10n is ok with msg-context
       + would like to get it in: because maintaining merging is a pain.
    + think it’s really great (Sophie)
       + need to dig into last mail Caolan sent to the list
       + main problem was msg-context; but seems now answered.
    + msg-contexts:
       + one use – to dis-ambiguate between 2 translations
       + another – a kind of documentation: what it’s for
       + made it as small as possible to be meaningful.
       + current msg-ctx is extracted when strings are extracted from the src
       + we auto-generate this and put them into the source now.
       + from here-on-in – can add human-meaningful context.
       + if STR_FOO “foo” → NC_(“FOO”, “foo”) – etc.
       + an equivalent XML field in the .ui file format.
       + sounds great (Sophie)
    + what’s not done yet:
       + support gettext plurals
         + so can get translations of copying 3 or 1 file.
         + easy to add later on.
         + it is an advantage of gettext (Sophie)
       + key-id
         + was difficult to support, but is
         + still will be a key-id translation; but done at run-time
         + will take the context + string and generate the string.
    + no objections to merging it (Cloph)
    => will wait 1 more day for screaming
       + cloph run scripts on strings
       + after merging master into pootle.

* New scheduler (finally) landed (Jan-Marek)
    + now back from vacation & able to support this
    + Changed a lot of task priorities to default
        - if you change default priorities,
          please add a comment to the code
    + Additional documentation commit currently working on
        - Had to fix the GLIB fallout first – wasn’t caught by Jenkins.
          Can this be fixed?
    + Defaults to round-robin; no more special case waiting
    + No idea about the general performances changes
        - but better interactivity during MM / high load for me
    + What is new ? (Miklos)
        + lots of special cases were dropped
        + wait a few ms & process next stuff
          – was no reasoning
        + now round-robins between the same priority tasks
        + thread-safety ? (Michael)
          + no, since we don’t own the task objects (Jmux)
             + lots of locking problems here.
             + other loops work with ‘ids’ instead.
             + tried, but got lots of deadlocks.
        + documentation is coming too ...

* Hackfests & Events (Bjoern)
    + next venues / suggestions
    + Akademy: 22nd-27th July (Thorsten)
        + Xisco, Gabriele, Jeff, Shinnok and Franklin attending.
         + We’ll run a booth over the weekend
    + GUADEC: 28th July - 2nd Aug (Michael)

* Call for Papers for the LibreOffice conference
    + deadline August 15th.
    + http://conference.libreoffice.org/2017/call-for-papers-3/ 5*0.04

* mentoring/easyhack update
          committer...   1 week   1 month     3 months     12 months    
                  open      0(0)      0(0)       116(-1)       124(0)  
               reviews      0(0)      0(0)      2660(-331)   14890(-313)
                merged      0(0)      0(0)      1330(-268)    8900(-159)
             abandoned      0(0)      0(0)        66(-14)      525(-10)
           own commits     17(5)    112(-104)   2856(-403)   15346(-296)
        review commits      4(3)     11(-22)     564(-66)     3101(-76)
        contributor...   1 week   1 month   3 months     12 months    
                  open     0(0)     0(0)        56(-1)        59(0)  
               reviews     0(0)     0(0)      2732(-487)   17015(-375)
                merged     0(0)     0(0)       190(-33)     1012(-19)
             abandoned     0(0)     0(0)        22(-6)       212(-6)  
           own commits     4(4)     8(-15)     237(-29)      845(-14)
        review commits     0(0)     0(0)         0(0)          0(0)  
    + easyHack statistics:
       needsDevEval 24(24)   needsUXEval 0(0)   cleanup_comments 187(187)  
       total 232(232)   assigned 16(16)   open 189(189)  
    + top 5 contributors:
          Dewan Aditya made 8 patches in 1 month, and 31 patches in 1 year
          Kara made 0 patches in 1 month, and 0 patches in 1 year
           made 0 patches in 1 month, and 0 patches in 1 year
          Nil made 0 patches in 1 month, and 0 patches in 1 year
          Zambon Jean-Marc made 0 patches in 1 month, and 2 patches in 1 year
    + top 5 reviewers:
          Kara made 0 review comments in 1 month, and 0 in 1 year
           made 0 review comments in 1 month, and 0 in 1 year
          Nil made 0 review comments in 1 month, and 0 in 1 year
          Zambon Jean-Marc made 0 review comments in 1 month, and 0 in 1 year
          Kim, Don made 0 review comments in 1 month, and 0 in 1 year

* GSoC update (Thorsten / Markus / JanI)
    + timeline:
         + July 24 - second eval
         + August 21- 29: pens down, wrap up
         + August 29 - September 5: final evaluations of students
         + September 6: passing projects announced

* crash reporter news (Xisco)
    + http://crashreport.libreoffice.org/stats/?days=128 
    + http://crashreport.libreoffice.org/stats/version/5.2.7.2
        + 1920 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.3.3.2
        + 3304 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.3.4.2
        + 1348 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.4.0.0
        + 9 (last 7 days)
    + Open bugs with a signature : 32 (+1)
         + http://bit.ly/2qZIC1H

* Commit Access

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + sleeping for 11 weeks

* Jenkins / CI update (Norbert/Markus)
    + some infra-issue with Mac build-farm
    + Problems with OSX jenkins bots
      => No gerrit OSX verification builds for now
    + Please pay attention to OSX tinderboxes
    + ETA for return of that ? (Miklos)
       + should Justin wait for that ?
       + no, expect– several weeks more (Michael)
       + can we re-dedicate existing TDF macs ? (Thorsten)
         + could it be done on demand ?
    + Clang catching the same errors (Michael)
    + Jenkins runs with rhel7 not rhel6 (Miklos)
       + is there a reason for that ? (Thorsten)
         + thought they ran CentOS6 (Cloph)
         + tinderbox@70 was showing the breakage -
         + Cloph/Jmux to look into that, fix needed if there’s fundamental             difference between CI builders and baseline

* l10n (Sophie)
    + nothing new; quiet.

* QA update (Xisco)

    + Reset all old bugs with an assignee and not in ASSIGNED status to default assignee → ~200 bugs.

    + office-interoperability-tools: Test ODT export
          + https://github.com/x1sc0/office-interoperability-tools/commit/94d76b25872b182d4c5471b97b852730189d6627
          + now also exporting to ODT, perhaps we find some issues there

    + UNCONFIRMED: 433 (+13)
        + enhancements: 60  (+6)
        + needsUXEval: 5 (-1)
        + haveBackTrace: 8 (+0)
        + needsDevAdvice: 33 (+0)
        + documentation:  2 (+0)


    + Most Pressing Bugs: http://tdf.io/mostressingbugs
          + New:
          + Crash in: SfxItemPool::IsInRange(unsigned short)
                + https://bugs.documentfoundation.org/show_bug.cgi?id=108881
                    + http://crashreport.libreoffice.org/stats/signature/SfxItemPool::IsInRange(unsigned%20short)
                        + Total: 363
                    + Assigned to Dennis Francis

          + CALC - crashes on COPYing 3+ whole rows to clipboard with OpenGL
                + https://bugs.documentfoundation.org/show_bug.cgi?id=108299
                + crash-reporter shows similar issues:
                  Windows - dumping clipboard to OS before final exit.
                + apparently shutdown / exit ordering nightmare wrt. Clipboard
                  already fixed by Moggi (?)

          + Older:
          + CRASH - SEGFAULT 11 attempting to open any document on master
                + macOS only – crashes rendering text ...
                + https://bugs.documentfoundation.org/show_bug.cgi?id=108793 
                => Tamas Bund.

          + Text is invisible, both in UI and in editor on update to 5.3.2,
            older AMD and Intel GPUs
                + https://bugs.documentfoundation.org/show_bug.cgi?id=107166
                + something poisons GDI / any sort of rendering at all
                + presumed fixed – thanks to Tomaz Vajngerl
                + back-port reviews for -5-4 appreciated:
                    + https://gerrit.libreoffice.org/#/c/39902/ 

          + CRASH: Crash after undo operation (BigPtrArray::Index2Block(...
                + https://bugs.documentfoundation.org/show_bug.cgi?id=107975
                    + http://crashreport.libreoffice.org/stats/signature/BigPtrArray::Index2Block(unsigned%20long)
                          + Total: 4420
                + Initially introduced by 2903d85d6197829633d7f96c95cd55821c2c20ff ( Luboš Luňák )
                    + Fixed in 9099e21b89184bd4e39def497e483cac4a77ec5a ( Jan-Marek Glogowski )
                    + reverted by e84f0a9b3223f49b0829f2f55dacbf11ae201c1e ( Michael Stahl )
                + Michael S - looked at it a couple of weeks ago.
                   + someone fixed problem deleting part of para – then the
                     at-character anchored objects are not deleted – but moved
                     to index 0
                   + the oldest commit - changed that so they are actually deleted
                   + other parts of the code expect them not to be deleted.
                   + 2 different undo classes crash in this case.
                   + unfortunately, not had enough time to look at it.
                   + alternative – just revert that commit.

          + Fixed:

          + CRASH: LibreOffice crashes while clicking on Show Signatures button
                + https://bugs.documentfoundation.org/show_bug.cgi?id=108852
                    + thanks to Bubli.

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +124  +7 (-72) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             9
       V Stuart Foote          7
       Samuel Mehrbrodt        6
       Buovjaga                5
       Timur                   4
       Alex Thurgood           4
       Justin L                3
       Mike Kaganski           3
       Adolfo Jayme            2
       Thomas Lendo            2
       Julien Nabet            2
       Michael Meeks           2
       Dennis Francis          1
       Szymon Kłos             1
       Chris Sherlock          1

    + top 10 bugs reporters:
       krishna [:kr1shna]      18
       Xisco Faulí             11
       Telesto                 7
       Thomas Lendo            4
       Ben                     3
       Timur                   3
       Mike Kaganski           3
       Samuel Mehrbrodt        3
       Marco A.G.Pinto         2
       Justin L                2
       Tamás Zolnai            2
       Kenneth Hanson          2
       Aron Budea              2
       bureautiquelibre        1
       Jean-Francois Nifenecker 1

    + top 10 bugs fixers:
       krishna [:kr1shna]      18
       Xisco Faulí             11
       Telesto                 7
       Thomas Lendo            4
       Ben                     3
       Timur                   3
       Mike Kaganski           3
       Samuel Mehrbrodt        3
       Marco A.G.Pinto         2
       Justin L                2
       Tamás Zolnai            2
       Kenneth Hanson          2
       Aron Budea              2
       bureautiquelibre        1
       Jean-Francois Nifenecker 1


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     5.3 : 4/43 -     9 %  (-2)
     5.2 : 2/37 -     5 %  (+0)
     5.1 : 1/34 -     2 %  (+0)
     5.0 : 2/60 -     3 %  (+0)
     4.4 : 4/76 -     5 %  (+0)
     4.3 : 6/73 -     8 %  (+0)
     4.2 : 6/134 -    4 %  (+0)
     4.1 : 4/82 -     4 %  (+0)
     4.0 : 5/82 -     6 %  (+2)
     old : 28/256 -   10 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 385/1485 376/1471 368/1458 372/1448 383/1441 386/1435 385/1425

     done by:
        Faulí Tarazona, Xisco  13
        Budea, Áron             1
        Justin L                1
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 475/2071 466/2056 457/2042 463/2032 470/2018 473/2008 470/1994

     done by:
        Faulí Tarazona, Xisco  14
        Budea, Áron             1
        Justin L                1


* all bugs tagged with 'regression'
   + 860(+12) bugs open of 6140(+21) total 13(-1) high prio.

     done by:
        Faulí Tarazona, Xisco  14
        Buovjaga                3
        Alex Thurgood           2
        Philips, Yousuf         1
        Justin L                1
        Telesto                 1
        zahra                   1
        robert                  1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     LibreOffice   - 4(+1)
     Writer        - 3(+0)
     Calc          - 2(-1)
     Impress       - 2(+0)
     graphics stack - 1(+0)
     Extensions    - 1(+0)
     Base          - 0(-1)

   by OS:
     Mac OS X      - 4(-1)
     Windows       - 1(+0)
     All           - 8(+0)
     Linux         - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 141(+4)
     Calc                     - 138(+0)
     Impress                  - 80(+0)
     Writer: docx filter      - 73(+1)
     LibreOffice              - 68(+2)
     UI                       - 47(+0)
     Writer: doc filter       - 43(-1)
     graphics stack           - 40(+0)
     Draw                     - 35(+0)
     Writer: perf             - 33(+0)
     Base                     - 32(+0)
     Writer: other filter     - 31(+7)
     Borders                  - 30(+0)
     Chart                    - 23(+0)
     filters and storage      - 22(+0)
     Crashes                  - 18(-2)
     Printing and PDF export  - 17(+0)
     BASIC                    - 13(+0)
     Extensions               - 4(+0)
     Installation             - 3(+0)
     framework                - 2(-1)
     Linguistic               - 2(+0)
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Markus Mohrhard Markus Mohrhard
Reply | Threaded
Open this post in threaded view
|

Re: minutes of ESC call ...



On Fri, Jul 14, 2017 at 11:34 AM, Michael Meeks <[hidden email]> wrote:


* SSRLabs Interns (Michael)
    + eight new hacking interns around: performance & quality
    + starting on their first easy-hacks.
    + Any ideas on quality ? (Xisco) 
        + can write UI test; can take a couple.
 
So there is also one additional idea around that. I already started adding some code that generates a log file with all the user interaction in the hope of automatically transforming that data to UI tests (or automatic replication of bug reports). So if there is a student interested in that he could work on making sure that all the relevant information is in the log file, writing a DSL (domain specific language) that represents the information and a script to automatically convert the generated log file to something based on the DSL.

This can be combined with the task of writing UI tests and extending the UI testing to some more complex cases. The huge advantage is that this is a task that is quite self contained and the code is well maintained. Long term having the ability to log what a user does in the UI and replay it on a developer machine would provide some huge benefits for us.


    + Extending performance test-suite (Markus?)

So we have at least two features that I would like to see but both are more web development related. The current perf.libreoffice.org already has the ability to store a comment for a specific data point but this currently requires manual execution of a shell script on the server. We should add a front-end for this feature making it easy to annotate data points with commits that caused performance changes.

The second feature that I think would be quite useful is to have the ability to get kcachegrind results for a specific test case and build ID. Currently there is no way to get useful info from the scripts and it is quite painful to debug performance problems. the VM is mostly idle during the European night and could produce the required data. This might also make it easier for QA and related fields to get good (symbols build, correct callgrind config) callgrind output. Obviously this requires some additional concept work.

All in all we can easily keep one student busy with some work here. The work would be mostly python, scripting, html, js work. The advantage is that it is a fairly contained project and a student will not need that much introduction time.

    + XML filter pieces (Michael)
        + continue & expand Azorpid’s work.
    + other misc. threading / perf. Ideas (Michael)
    + UX pieces (Heiko)
        + problem is: need a coding mentor here.
        + missing table styles, area style types etc.
        + page background etc.
    + build performance on windows ? (Thorsten)



_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Terrence Enger Terrence Enger
Reply | Threaded
Open this post in threaded view
|

Re: minutes of ESC call ...

On Sun, 2017-07-16 at 02:29 +0200, Markus Mohrhard wrote:
> On Fri, Jul
14, 2017 at 11:34 AM, Michael Meeks <michael.meeks@collab

> ora.com
> > wrote:
> > 
> > 
> > * SSRLabs Interns (Michael)
> >     + eight new hacking interns around: performance & quality
> >     + starting on their first easy-hacks.
> >     + Any ideas on quality ? (Xisco)

>         + can write UI test; can take a couple.
> > 

> So there is also one additional idea around that. I already started
> adding
> some code that generates a log file with all the user interaction in
> the
> hope of automatically transforming that data to UI tests (or
> automatic
> replication of bug reports).

It would be particularly good if this logging was sufficiently
performant that a dedicated tester could have it on routinely.  This
would help in the situation when I am surprised without knowing
exactly what I did.

For example, right now I am unable to reproduce a rendering problem in
Writer that I stumbled over while I was doing real work.  Perhaps it
depends on just what edits I made, how I moved the cursor around, what
I undo'd (Let us hope that never becomes a word. <scowl />), or even
the content of the document.  As it is now, I have just about given
up.

Terry.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Heiko Tietze-2 Heiko Tietze-2
Reply | Threaded
Open this post in threaded view
|

Re: minutes of ESC call ...

In reply to this post by Markus Mohrhard
On 16.07.2017 02:29, Markus Mohrhard wrote:
>> * SSRLabs Interns (Michael)
> So there is also one additional idea around that. I already started
> adding some code that generates a log file with all the user
> interaction in the hope of automatically transforming that data to UI
> tests (or automatic replication of bug reports).

Can we abuse this data for user metrics? Would be another most-wanted task, whether or not based on these log files.


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (499 bytes) Download Attachment