move external builds into subfolder (fdo#70393)

classic Classic list List threaded Threaded
4 messages Options
Bjoern Michaelsen Bjoern Michaelsen
Reply | Threaded
Open this post in threaded view
|

move external builds into subfolder (fdo#70393)

Hi,

is there any violent opposition to:

 https://bugs.freedesktop.org/show_bug.cgi?id=70393

if so, we can discuss on the ESC on Thurday. If nobody objects in 24 hours, Ill
make that an Easy Hack and push:

 https://gerrit.libreoffice.org/#/c/6231/

to master.

Best,

Bjoern
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|

Re: move external builds into subfolder (fdo#70393)

Hi Bjoern,

On Tuesday, 2013-10-15 13:40:21 +0200, Bjoern Michaelsen wrote:

> is there any violent opposition to:
>
>  https://bugs.freedesktop.org/show_bug.cgi?id=70393

No opposition, just please move the current content, i.e. external/*.mk,
out of the way to have it one level deeper (is it all Windows related?
then have windows/ subdir or some such), as is it would be quite
confusing to have *.mk files there that are completely unrelated to all
the external modules below then.

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (853 bytes) Download Attachment
Bjoern Michaelsen Bjoern Michaelsen
Reply | Threaded
Open this post in threaded view
|

Re: move external builds into subfolder (fdo#70393)

Hi,

On Tue, Oct 15, 2013 at 05:30:37PM +0200, Eike Rathke wrote:
> No opposition, just please move the current content, i.e. external/*.mk,
> out of the way to have it one level deeper (is it all Windows related?
> then have windows/ subdir or some such), as is it would be quite
> confusing to have *.mk files there that are completely unrelated to all
> the external modules below then.

done with:

 https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=29a5707821f9ec386d5f6b90f7838db9cdff1263
 https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=82a3c3f702e78232ebd4671c0061aa817bbd146b
 https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=98404a843198c532c5639b073a3a83ff3529615b

thus there should be now ~50 top-level dirs that can be moved to "external". To
anyone who is interested:

 https://bugs.freedesktop.org/show_bug.cgi?id=70393

Good Hunting!

Bjoern
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Khaled Hosny Khaled Hosny
Reply | Threaded
Open this post in threaded view
|

Re: move external builds into subfolder (fdo#70393)

CONTENTS DELETED
The author has deleted this message.