sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

classic Classic list List threaded Threaded
5 messages Options
Kaganski Mike Kaganski Mike
Reply | Threaded
Open this post in threaded view
|

sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

Hi!

I see sw_uiwriter hanging locally in
testDateFormFieldCurrentDateInvalidation (added in commit
d0ff1090762ac61ce08f54bc76685232699d98a0), never returning from
Scheduler::ProcessEventsToIdle. Killing the test after some time
produces multiple lines in console:

> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 1000
> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 2000
> ...
> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 845000

I believe that's the reason for massive number of aborted Windows
jenkins builds that lately affect our CI (just the last few are builds
#34586, #34587, #34588, #34589, #34590, #34591).

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan-Marek Glogowski Jan-Marek Glogowski
Reply | Threaded
Open this post in threaded view
|

Re: sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

Am 14.07.19 um 13:28 schrieb Kaganski Mike:

> I see sw_uiwriter hanging locally in
> testDateFormFieldCurrentDateInvalidation (added in commit
> d0ff1090762ac61ce08f54bc76685232699d98a0), never returning from
> Scheduler::ProcessEventsToIdle. Killing the test after some time
> produces multiple lines in console:
>
>> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 1000
>> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 2000
>> ...
>> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 845000
>
> I believe that's the reason for massive number of aborted Windows
> jenkins builds that lately affect our CI (just the last few are builds
> #34586, #34587, #34588, #34589, #34590, #34591).

Just see the list in https://ci.libreoffice.org/job/gerrit_windows/

And https://gerrit.libreoffice.org/75463 was force-pushed after an Abort.

I know there are still problems with the Scheduler code on Windows, eventually
the AnyInput handling. Probably it's the same then
https://bugs.documentfoundation.org/show_bug.cgi?id=123583
My guess is LO is generating system events, so processing is always interrupted.

Also see https://gerrit.libreoffice.org/#/c/75568/

I can help debugging the general problem, but since I don't have Windows or a
Windows build, I can't do it myself.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Tamas Zolnai-2 Tamas Zolnai-2
Reply | Threaded
Open this post in threaded view
|

Re: sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

Thanks for the note! I disabled the test for now, let's see if it fix tinderboxes. I'll check the test on Windows locally and fix it or remove it if this ProcessEventsToIdle() does not work correctly.
I force pushed it because every second Windows build fails on gerrit, which is not very useful when trying to merge a feature branch to master.

Vasárnap, Július 14, 2019 12:47 BST dátummal, Jan-Marek Glogowski <[hidden email]> ezt írta:
 

> Am 14.07.19 um 13:28 schrieb Kaganski Mike:
> > I see sw_uiwriter hanging locally in
> > testDateFormFieldCurrentDateInvalidation (added in commit
> > d0ff1090762ac61ce08f54bc76685232699d98a0), never returning from
> > Scheduler::ProcessEventsToIdle. Killing the test after some time
> > produces multiple lines in console:
> >
> >> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 1000
> >> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 2000
> >> ...
> >> warn:vcl.schedule:5488:13820:vcl/source/app/svapp.cxx:470: ProcessEventsToIdle: 845000
> >
> > I believe that's the reason for massive number of aborted Windows
> > jenkins builds that lately affect our CI (just the last few are builds
> > #34586, #34587, #34588, #34589, #34590, #34591).
>
> Just see the list in https://ci.libreoffice.org/job/gerrit_windows/
>
> And https://gerrit.libreoffice.org/75463 was force-pushed after an Abort.
>
> I know there are still problems with the Scheduler code on Windows, eventually
> the AnyInput handling. Probably it's the same then
> https://bugs.documentfoundation.org/show_bug.cgi?id=123583
> My guess is LO is generating system events, so processing is always interrupted.
>
> Also see https://gerrit.libreoffice.org/#/c/75568/
>
> I can help debugging the general problem, but since I don't have Windows or a
> Windows build, I can't do it myself.

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jan-Marek Glogowski Jan-Marek Glogowski
Reply | Threaded
Open this post in threaded view
|

Re: sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation


Am 14.07.19 um 14:11 schrieb Tamas Zolnai:
> Thanks for the note! I disabled the test for now, let's see if it fix tinderboxes. I'll check the test on Windows locally and fix it or remove it if this ProcessEventsToIdle() does not work correctly.

It should be sufficient to use #ifndef _WIN32 for the moment, as all other OS
seem to pass the test. If you want to debug Windows AnyInput handling, feel free
to contact me on IRC (or even mail), if you have questions.

> I force pushed it because every second Windows build fails on gerrit, which is not very useful when trying to merge a feature branch to master.

It's one thing to have a test failure, but ABORTED due to timeout are very rare.

And hopefully the general situation has improved on Windows since my Windows
font registration fixes and the gbuild instdir font dependencies.


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Kaganski Mike Kaganski Mike
Reply | Threaded
Open this post in threaded view
|

Re: sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

On 14.07.2019 22:23, Jan-Marek Glogowski wrote:
>
> If you want to debug Windows AnyInput handling, feel free
> to contact me on IRC (or even mail), if you have questions.

I have tried putting some tracing breakpoints to
WinSalInstance::AnyInput, and I can say that at least when the process
is already hung (emitting all those "ProcessEventsToIdle: 100500"
warnings), the function isn't called at all.

--
Best regards,
Mike Kaganski
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice